From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5B3FC41535 for ; Tue, 19 Dec 2023 16:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RaAlatyO8++DHRWD4Okxc5wGQ1gtDOGaXSO6QuqX3fw=; b=nB9h1Oe86Xs9e1 Xpr0VUhpZbplYqnJX0YlFsaiZKhNyCfy58oyK5K9g3QgLf3ei5j9Yt4K+HOU1pFZuFyf2PJcNAZ3W missy1tvK1/HGR+Wm3OnF9Fkl8nOkSahQQjg3SOBtcoQbnsRl5X8rca6c/LQQTEhR96TXcjGAn27q jHEBb+TPCfAL8KM8wGtd8bjdA/k/103yXqbg2NfLXSsJaE0O+G50eGyWec8uOKMzge3SqV8Sh6CQz /SwRAx+ny450T8DeEIQihm2mWvrNfKaDG/A6rYpSpkGXotcwVq7De9mu0qCeImLewstoIxSJDtJnn G402W1BmMQARNPaOrgRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFdMQ-00EmY5-25; Tue, 19 Dec 2023 16:54:26 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFdMO-00EmWt-12 for linux-arm-kernel@lists.infradead.org; Tue, 19 Dec 2023 16:54:25 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a23350cd51cso371034866b.2 for ; Tue, 19 Dec 2023 08:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703004862; x=1703609662; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hnbv43rPSyuI7Tjsf1jCy999PgtXeEb5DS5jkSFPK+Y=; b=OLCiVJvA6hKgiKYHFkyBbTcsZ7QRqyqMTEU88MVxdOdhBpCSZ8esGpO3hDV8wWWPJz 2z5znlGYSzjIN3AKwOJzgG7qCC6p0QB3MQudftdfs7YdaPcsaWcs+sDWZ8Mw0hKWrhCy QOdA5BnKpZBAeq8NWVAMlyyh/tXhAYVG3r0E80m34DpYpr08N/BYvr06ovTEDoYc2g91 LLjIFkjdssLQGair5ZjaRi2CA5vR7D2gE0d68HUDoxOqHLybzWbXu7+8apv6vMqvCr+U 97PDAlFlmYzWnYyicJl72Cqq/y8L0YzkRaB/awdWWRQqQP/OohTBAnv/G/84/CvKfvH4 wK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703004862; x=1703609662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hnbv43rPSyuI7Tjsf1jCy999PgtXeEb5DS5jkSFPK+Y=; b=U4bSpf9olB0RChpKh3traP0QITU5fWSj4Esov9lQPfiNsGaPZHayMttkIgQZT67Uo+ NnjEauiERBufgdWxJrP6dcyqpij/ymXfa5y2eEzM6TMMy7riukIip7L+xY46ohPOTn4/ em/L932/Esf0TqU6Mx4cc6E7NUtOAe7W+RANuKpf2e0/ILvF5Ja2aLQmLW3kdmZQvEHC nJB4KY9IJLVYcRLJk9WAG247Y3NrkLmBYqfdZ9iY1BNEmCVQhrRtUq87/Qg163/bXxiT 1G662uu5kaBEfh4pVlTYiwsd/55LenDEWC1nzYmAvM7GBcqWEfITNmFppJBrCjKF0mdI C3zQ== X-Gm-Message-State: AOJu0YxKndZAQzbcntULkzOPRzzwWp4nju6r8q45wLBhiVXIG3yh0fMD W2FB48GYLNk2oj4ROGQfi9s= X-Google-Smtp-Source: AGHT+IFGpPOrKgiesvyt3dvb35pzq6oOzYVmDiF0hcfrJBLGErG46GoedhJeqiXAL1OIyI4NZrBVxQ== X-Received: by 2002:a17:906:2611:b0:a23:48d2:be33 with SMTP id h17-20020a170906261100b00a2348d2be33mr1859295ejc.128.1703004861755; Tue, 19 Dec 2023 08:54:21 -0800 (PST) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id s19-20020a170906c31300b00a236e9cfe74sm1381021ejz.103.2023.12.19.08.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 08:54:21 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?ISO-8859-1?Q?G=FCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Frank Oltmanns Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Frank Oltmanns Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio Date: Tue, 19 Dec 2023 17:54:19 +0100 Message-ID: <13411739.uLZWGnKmhe@jernej-laptop> In-Reply-To: <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_085424_358519_971102B7 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns napisal(a): > The Allwinner A64 manual lists the following constraint for the > PLL-VIDEO0 clock: 8 <= N/M <= 25 > > Use this constraint. > > Signed-off-by: Frank Oltmanns > --- > drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c > index c034ac027d1c..75d839da446c 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c > @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_base_clk, "pll-audio-base", > BIT(28), /* lock */ > CLK_SET_RATE_UNGATE); > > -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk, "pll-video0", > +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_video0_clk, > + "pll-video0", > "osc24M", 0x010, > 192000000, /* Minimum rate */ > 1008000000, /* Maximum rate */ > @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk, "pll-vid > 297000000, /* frac rate 1 */ > BIT(31), /* gate */ > BIT(28), /* lock */ > - CLK_SET_RATE_UNGATE); > + CLK_SET_RATE_UNGATE, > + CCU_FEATURE_FRACTIONAL | > + CCU_FEATURE_CLOSEST_RATE, Above flags are unrelated change, put them in new patch if needed. Best regards, Jernej > + 8, 25); /* min/max nm ratio */ > > static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", > "osc24M", 0x018, > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel