* [PATCH 0/2] arm: imx/mxs: enable flexcan driver
@ 2012-07-01 20:46 Marc Kleine-Budde
2012-07-01 20:46 ` [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q Marc Kleine-Budde
2012-07-01 20:46 ` [PATCH 2/2] arm: mxs: enable flexcan on imx28 Marc Kleine-Budde
0 siblings, 2 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2012-07-01 20:46 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
as the flexcan driver has DT binding for some time now. This patch makes
the flexcan driver available in the can drivers menu if a SOC with flexcan
is enabled.
These patches apply to 3.5-rc5.
regards, Marc
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q
2012-07-01 20:46 [PATCH 0/2] arm: imx/mxs: enable flexcan driver Marc Kleine-Budde
@ 2012-07-01 20:46 ` Marc Kleine-Budde
2012-07-02 7:50 ` Sascha Hauer
2012-07-01 20:46 ` [PATCH 2/2] arm: mxs: enable flexcan on imx28 Marc Kleine-Budde
1 sibling, 1 reply; 7+ messages in thread
From: Marc Kleine-Budde @ 2012-07-01 20:46 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Sascha Hauer <sha@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
arch/arm/mach-imx/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index eff4db5..c296851 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -52,6 +52,7 @@ config SOC_IMX25
select ARCH_MX25
select COMMON_CLK
select CPU_ARM926T
+ select HAVE_CAN_FLEXCAN if CAN
select ARCH_MXC_IOMUX_V3
select MXC_AVIC
@@ -79,6 +80,7 @@ config SOC_IMX35
select HAVE_EPIT
select MXC_AVIC
select SMP_ON_UP if SMP
+ select HAVE_CAN_FLEXCAN if CAN
config SOC_IMX5
select CPU_V7
@@ -105,6 +107,7 @@ config SOC_IMX53
select SOC_IMX5
select ARCH_MX5
select ARCH_MX53
+ select HAVE_CAN_FLEXCAN if CAN
if ARCH_IMX_V4_V5
@@ -826,6 +829,7 @@ config SOC_IMX6Q
select COMMON_CLK
select CPU_V7
select HAVE_ARM_SCU
+ select HAVE_CAN_FLEXCAN if CAN
select HAVE_IMX_GPC
select HAVE_IMX_MMDC
select HAVE_IMX_SRC
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q
2012-07-01 20:46 ` [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q Marc Kleine-Budde
@ 2012-07-02 7:50 ` Sascha Hauer
2012-07-02 7:54 ` Marc Kleine-Budde
0 siblings, 1 reply; 7+ messages in thread
From: Sascha Hauer @ 2012-07-02 7:50 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jul 01, 2012 at 10:46:04PM +0200, Marc Kleine-Budde wrote:
> Cc: Sascha Hauer <sha@pengutronix.de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> arch/arm/mach-imx/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index eff4db5..c296851 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -52,6 +52,7 @@ config SOC_IMX25
> select ARCH_MX25
> select COMMON_CLK
> select CPU_ARM926T
> + select HAVE_CAN_FLEXCAN if CAN
Do we need the 'if CAN' here? It seems yes, since HAVE_CAN_FLEXCAN is
inside the "CAN Device Drivers" menu which depends on CAN. Shouldn't the
HAVE_CAN_FLECAN be outside the menu?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q
2012-07-02 7:50 ` Sascha Hauer
@ 2012-07-02 7:54 ` Marc Kleine-Budde
2012-07-02 8:06 ` Sascha Hauer
0 siblings, 1 reply; 7+ messages in thread
From: Marc Kleine-Budde @ 2012-07-02 7:54 UTC (permalink / raw)
To: linux-arm-kernel
On 07/02/2012 09:50 AM, Sascha Hauer wrote:
> On Sun, Jul 01, 2012 at 10:46:04PM +0200, Marc Kleine-Budde wrote:
>> Cc: Sascha Hauer <sha@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> arch/arm/mach-imx/Kconfig | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index eff4db5..c296851 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -52,6 +52,7 @@ config SOC_IMX25
>> select ARCH_MX25
>> select COMMON_CLK
>> select CPU_ARM926T
>> + select HAVE_CAN_FLEXCAN if CAN
>
> Do we need the 'if CAN' here? It seems yes, since HAVE_CAN_FLEXCAN is
> inside the "CAN Device Drivers" menu which depends on CAN. Shouldn't the
> HAVE_CAN_FLECAN be outside the menu?
Yes, we can move the HAVE_CAN_FLEXCAN outside of that menu, but it still
depends on CONFIG_NET.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120702/ae72385b/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q
2012-07-02 7:54 ` Marc Kleine-Budde
@ 2012-07-02 8:06 ` Sascha Hauer
0 siblings, 0 replies; 7+ messages in thread
From: Sascha Hauer @ 2012-07-02 8:06 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 02, 2012 at 09:54:08AM +0200, Marc Kleine-Budde wrote:
> On 07/02/2012 09:50 AM, Sascha Hauer wrote:
> > On Sun, Jul 01, 2012 at 10:46:04PM +0200, Marc Kleine-Budde wrote:
> >> Cc: Sascha Hauer <sha@pengutronix.de>
> >> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >> ---
> >> arch/arm/mach-imx/Kconfig | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> >> index eff4db5..c296851 100644
> >> --- a/arch/arm/mach-imx/Kconfig
> >> +++ b/arch/arm/mach-imx/Kconfig
> >> @@ -52,6 +52,7 @@ config SOC_IMX25
> >> select ARCH_MX25
> >> select COMMON_CLK
> >> select CPU_ARM926T
> >> + select HAVE_CAN_FLEXCAN if CAN
> >
> > Do we need the 'if CAN' here? It seems yes, since HAVE_CAN_FLEXCAN is
> > inside the "CAN Device Drivers" menu which depends on CAN. Shouldn't the
> > HAVE_CAN_FLECAN be outside the menu?
>
> Yes, we can move the HAVE_CAN_FLEXCAN outside of that menu, but it still
> depends on CONFIG_NET.
Ok, then we have no choice. I just asked because it seems unnatural that
the presence of a hardware device depends on config options.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: mxs: enable flexcan on imx28
2012-07-01 20:46 [PATCH 0/2] arm: imx/mxs: enable flexcan driver Marc Kleine-Budde
2012-07-01 20:46 ` [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q Marc Kleine-Budde
@ 2012-07-01 20:46 ` Marc Kleine-Budde
2012-07-02 2:01 ` Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Marc Kleine-Budde @ 2012-07-01 20:46 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
arch/arm/mach-mxs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
index 91cf062..ccdf83b 100644
--- a/arch/arm/mach-mxs/Kconfig
+++ b/arch/arm/mach-mxs/Kconfig
@@ -16,6 +16,7 @@ config SOC_IMX28
bool
select ARM_AMBA
select CPU_ARM926T
+ select HAVE_CAN_FLEXCAN if CAN
select HAVE_PWM
select PINCTRL_IMX28
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: mxs: enable flexcan on imx28
2012-07-01 20:46 ` [PATCH 2/2] arm: mxs: enable flexcan on imx28 Marc Kleine-Budde
@ 2012-07-02 2:01 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2012-07-02 2:01 UTC (permalink / raw)
To: linux-arm-kernel
Suggested subject prefix is "ARM: mxs: ...".
On Sun, Jul 01, 2012 at 10:46:05PM +0200, Marc Kleine-Budde wrote:
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Can we fill the commit message with something like what we have in
the cover letter?
Regards,
Shawn
> ---
> arch/arm/mach-mxs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
> index 91cf062..ccdf83b 100644
> --- a/arch/arm/mach-mxs/Kconfig
> +++ b/arch/arm/mach-mxs/Kconfig
> @@ -16,6 +16,7 @@ config SOC_IMX28
> bool
> select ARM_AMBA
> select CPU_ARM926T
> + select HAVE_CAN_FLEXCAN if CAN
> select HAVE_PWM
> select PINCTRL_IMX28
>
> --
> 1.7.10
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-02 8:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-01 20:46 [PATCH 0/2] arm: imx/mxs: enable flexcan driver Marc Kleine-Budde
2012-07-01 20:46 ` [PATCH 1/2] arm: imx: enable flexcan on imx25, imx35, imx53, imx6q Marc Kleine-Budde
2012-07-02 7:50 ` Sascha Hauer
2012-07-02 7:54 ` Marc Kleine-Budde
2012-07-02 8:06 ` Sascha Hauer
2012-07-01 20:46 ` [PATCH 2/2] arm: mxs: enable flexcan on imx28 Marc Kleine-Budde
2012-07-02 2:01 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).