[PATCH 0/2] Add pinctrl support to AM33XX family of devices

[PATCH 0/2] Add pinctrl support to AM33XX family of devices

[AnilKumar Ch]

Adds pinctrl support to AM33XX family of devices. This patch is
based on the pinctrl-simple driver submitted by Tony L
here: http://lwn.net/Articles/496075/

These patches were tested on AM335x-Bone and AM335x-EVM

AnilKumar Ch (2):
  arm/dts: Add AM33XX basic pinctrl support
  arm/dts: Configure pinmuxs for user leds control on Bone

 arch/arm/boot/dts/am335x-bone.dts |   24 ++++++++++++++++++++++++
 arch/arm/boot/dts/am33xx.dtsi     |   12 ++++++++++++
 2 files changed, 36 insertions(+)

-- 
1.7.9.5

[PATCH 1/2] arm/dts: Add AM33XX basic pinctrl support

[AnilKumar Ch]

Adds basic pinctrl support for AM33XX family of devices. This patch
is based on the pinctrl-simple driver submitted by Tony Lindgren's
here: http://lwn.net/Articles/496075/

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 59509c4..85def31 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -40,6 +40,18 @@
 		};
 	};
 
+	am3358_pinmux: pinmux at 44E10800 {
+		compatible = "ti,omap4-padconf";
+		reg = <0x44E10800 0x0338>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		#pinctrl-cells = <2>;
+		pinctrl-simple,register-width = <32>;
+		pinctrl-simple,function-mask = <0x7>;
+		pinctrl-simple,function-off = <0xffffffff>;
+		pinctrl-simple,pinconf-mask = <0x78>;
+	};
+
 	/*
 	 * XXX: Use a flat representation of the AM33XX interconnect.
 	 * The real AM33XX interconnect network is quite complex.Since
-- 
1.7.9.5

[PATCH 2/2] arm/dts: Configure pinmuxs for user leds control on Bone

[AnilKumar Ch]

Adds GPIO pinctrl nodes to am3358_pinmux master node to control
user leds (USR0, USR1, USR2 and USR3) present on BeagleBone.

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 arch/arm/boot/dts/am335x-bone.dts |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index a9af4db..c3810b7 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -18,3 +18,27 @@
 		reg = <0x80000000 0x10000000>; /* 256 MB */
 	};
 };
+
+&am3358_pinmux {
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&userled_pins>;
+
+	userled_pins: pinmux_userled_pins {
+		gpmc_a5.gpio1_21 {
+			pinctrl-simple,cells = <0x54 0x7>;	/* OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */
+		};
+
+		gpmc_a6.gpio1_22 {
+			pinctrl-simple,cells = <0x58 0x17>;	/* OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */
+		};
+
+		gpmc_a7.gpio1_23 {
+			pinctrl-simple,cells = <0x5C 0x7>;	/* OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */
+		};
+
+		gpmc_a8.gpio1_24 {
+			pinctrl-simple,cells = <0x60 0x17>;	/* OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */
+		};
+	};
+};
-- 
1.7.9.5

[PATCH 1/2] arm/dts: Add AM33XX basic pinctrl support

[Tony Lindgren]

* AnilKumar Ch <anilkumar@ti.com> [120705 02:18]:
> Adds basic pinctrl support for AM33XX family of devices. This patch
> is based on the pinctrl-simple driver submitted by Tony Lindgren's
> here: http://lwn.net/Articles/496075/
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 59509c4..85def31 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -40,6 +40,18 @@
>  		};
>  	};
>  
> +	am3358_pinmux: pinmux at 44E10800 {
> +		compatible = "ti,omap4-padconf";
> +		reg = <0x44E10800 0x0338>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		#pinctrl-cells = <2>;
> +		pinctrl-simple,register-width = <32>;
> +		pinctrl-simple,function-mask = <0x7>;
> +		pinctrl-simple,function-off = <0xffffffff>;
> +		pinctrl-simple,pinconf-mask = <0x78>;
> +	};
> +

You might want to update to the latest version, which is now called
pinctrl-single instead of pinctrl-simple. Should be easy to update,
note that we're still waiting on people to comment on the binding,
so you might want to wait a bit before reposting so we have the
driver merged.

Regards,

Tony

[PATCH 1/2] arm/dts: Add AM33XX basic pinctrl support

[AnilKumar, Chimata]

Hi Tony,

Thanks for reviewing.

On Fri, Jul 06, 2012 at 13:53:44, Tony Lindgren wrote:
> * AnilKumar Ch <anilkumar@ti.com> [120705 02:18]:
> > Adds basic pinctrl support for AM33XX family of devices. This patch
> > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > here: http://lwn.net/Articles/496075/
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> >  arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 59509c4..85def31 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -40,6 +40,18 @@
> >  		};
> >  	};
> >  
> > +	am3358_pinmux: pinmux at 44E10800 {
> > +		compatible = "ti,omap4-padconf";
> > +		reg = <0x44E10800 0x0338>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		#pinctrl-cells = <2>;
> > +		pinctrl-simple,register-width = <32>;
> > +		pinctrl-simple,function-mask = <0x7>;
> > +		pinctrl-simple,function-off = <0xffffffff>;
> > +		pinctrl-simple,pinconf-mask = <0x78>;
> > +	};
> > +
> 
> You might want to update to the latest version, which is now called
> pinctrl-single instead of pinctrl-simple. Should be easy to update,
> note that we're still waiting on people to comment on the binding,
> so you might want to wait a bit before reposting so we have the
> driver merged.

In that case, I will submit the patches with respect to pinctrl-single
after it is available in linux-next tree.

Thanks
AnilKumar