From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] pinctrl: pinctrl-nomadik: Fix possible memory leak
Date: Thu, 5 Jul 2012 14:06:04 +0100 [thread overview]
Message-ID: <1341493572-29735-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1341493572-29735-1-git-send-email-lee.jones@linaro.org>
If the Nomadik Pin Control driver is continuously bound and unbound
from the same device a number of times the kzalloc() will leak
memory. Replacing it with devm_kzalloc() will ensure memory is
freed automatically in the event of failure and unbinding.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pinctrl/pinctrl-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c
index 3e7e47d..af0389f 100644
--- a/drivers/pinctrl/pinctrl-nomadik.c
+++ b/drivers/pinctrl/pinctrl-nomadik.c
@@ -1194,7 +1194,7 @@ static int __devinit nmk_gpio_probe(struct platform_device *dev)
}
if (np) {
- pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
+ pdata = devm_kzalloc(&dev->dev, sizeof(*pdata), GFP_KERNEL);
if (!pdata)
return -ENOMEM;
--
1.7.9.5
next prev parent reply other threads:[~2012-07-05 13:06 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 13:06 [PATCH 0/9] Final batch of clean-ups bound for v3.6 Lee Jones
2012-07-05 13:06 ` Lee Jones [this message]
2012-07-06 7:03 ` [PATCH 1/9] pinctrl: pinctrl-nomadik: Fix possible memory leak Linus Walleij
2012-07-05 13:06 ` [PATCH 2/9] pinctrl: pinctrl-nomadik: Append sleepmode property with vendor specific prefixes Lee Jones
2012-07-06 7:04 ` Linus Walleij
2012-07-05 13:06 ` [PATCH 3/9] ARM: ux500: Remove AB8500 regulator register initialisation information Lee Jones
2012-07-05 13:51 ` Arnd Bergmann
2012-07-05 13:55 ` Lee Jones
2012-07-05 21:21 ` Linus Walleij
2012-07-06 6:55 ` Linus Walleij
2012-07-06 7:45 ` Lee Jones
2012-07-06 11:23 ` Mark Brown
2012-07-06 11:52 ` Lee Jones
2012-07-06 12:34 ` Mark Brown
2012-07-05 13:06 ` [PATCH 4/9] ARM: ux500: Ensure vendor specific properties have the vendor's identifier Lee Jones
2012-07-06 7:10 ` Linus Walleij
2012-07-05 13:06 ` [PATCH 5/9] ARM: ux500: Remove temporary snowball_of_platform_devs enablement structure Lee Jones
2012-07-06 7:10 ` Linus Walleij
2012-07-05 13:06 ` [PATCH 6/9] ARM: ux500: Remove PMU platform registration when booting with DT Lee Jones
2012-07-06 7:11 ` Linus Walleij
2012-07-05 13:06 ` [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Lee Jones
2012-07-06 7:18 ` Linus Walleij
2012-07-05 13:06 ` [PATCH 8/9] ARM: ux500: Clean-up temporary Device Tree enablement helpers Lee Jones
2012-07-06 7:23 ` Linus Walleij
2012-07-06 8:33 ` Lee Jones
2012-07-08 19:11 ` Linus Walleij
2012-07-09 18:50 ` Lee Jones
2012-07-09 20:36 ` Linus Walleij
2012-07-05 13:06 ` [PATCH 9/9] ARM: ux500: Over-ride the DT device naming scheme for pinctrl Lee Jones
2012-07-06 7:25 ` Linus Walleij
2012-07-06 7:52 ` [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Lee Jones
2012-07-06 17:39 ` Dmitry Torokhov
2012-07-06 17:51 ` Lee Jones
2012-07-09 18:53 ` Lee Jones
2012-07-09 20:14 ` Dmitry Torokhov
2012-07-09 20:34 ` Lee Jones
2012-07-09 20:35 ` Lee Jones
2012-07-09 20:37 ` Linus Walleij
2012-07-09 20:42 ` Lee Jones
2012-07-09 20:46 ` Dmitry Torokhov
2012-07-09 20:56 ` Lee Jones
2012-07-09 20:59 ` Lee Jones
2012-07-09 21:03 ` Linus Walleij
2012-07-09 21:21 ` Lee Jones
2012-07-10 21:08 ` Linus Walleij
2012-07-12 16:37 ` Mark Brown
2012-07-13 13:43 ` Lee Jones
2012-07-14 21:36 ` Linus Walleij
2012-07-10 6:17 ` Dmitry Torokhov
2012-07-10 6:22 ` Lee Jones
2012-07-16 7:35 ` Lee Jones
2012-07-16 13:57 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341493572-29735-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).