From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: versatile: add DT based PCI detection
Date: Tue, 30 Dec 2014 22:37:01 +0100 [thread overview]
Message-ID: <13417872.31IhE1RbAx@wuerfel> (raw)
In-Reply-To: <1419967718-26909-4-git-send-email-robherring2@gmail.com>
On Tuesday 30 December 2014 13:28:32 Rob Herring wrote:
> From: Rob Herring <robh@kernel.org>
>
> Disable the Versatile PCI DT node when no PCI backplane is detected. This
> will prevent the Versatile PCI driver from probing when PCI is not
> populated.
Can you explain why the check is done in platform code instead of the PCI
driver probe function itself?
> + /* Check if PCI backplane is detected */
> + val = __raw_readl(base + VERSATILE_SYS_PCICTL_OFFSET);
> + if (val & 1)
> + goto err;
Using __raw_readl prevents this from working with big-endian kernels, so just
use readl here.
Arnd
next prev parent reply other threads:[~2014-12-30 21:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 19:28 [PATCH 0/9] ARM Versatile multi-platform support Rob Herring
2014-12-30 19:28 ` [PATCH 1/9] dt/bindings: add versatile PCI binding Rob Herring
2014-12-30 19:28 ` [PATCH 2/9] dts: versatile: add PCI controller binding Rob Herring
2014-12-30 19:28 ` [PATCH 3/9] ARM: versatile: add DT based PCI detection Rob Herring
2014-12-30 21:37 ` Arnd Bergmann [this message]
2014-12-30 23:05 ` Rob Herring
2014-12-31 15:23 ` Arnd Bergmann
2014-12-31 16:13 ` Peter Maydell
2014-12-31 19:22 ` Rob Herring
2014-12-31 21:07 ` Peter Maydell
2015-01-01 15:35 ` Arnd Bergmann
2015-01-01 15:52 ` Peter Maydell
2015-01-08 19:37 ` Linus Walleij
2015-01-08 21:34 ` Rob Herring
2014-12-30 19:28 ` [PATCH 4/9] pci: add DT based ARM Versatile PCI host driver Rob Herring
2014-12-30 21:58 ` Arnd Bergmann
2015-01-02 18:14 ` Rob Herring
2015-01-02 20:52 ` Arnd Bergmann
2015-01-02 23:13 ` Rob Herring
2015-01-05 9:35 ` Arnd Bergmann
2015-01-24 1:01 ` Bjorn Helgaas
2015-01-24 0:54 ` Bjorn Helgaas
2014-12-30 19:28 ` [PATCH 5/9] dts: versatile: add sysregs nodes Rob Herring
2015-01-08 19:44 ` Linus Walleij
2015-01-08 23:53 ` Rob Herring
2015-01-09 7:10 ` Linus Walleij
2015-01-09 11:53 ` Lorenzo Pieralisi
2015-01-15 16:06 ` Lorenzo Pieralisi
2015-01-19 10:25 ` Linus Walleij
2014-12-30 19:28 ` [PATCH 6/9] ARM: versatile: switch to DT only booting and remove legacy code Rob Herring
2014-12-30 19:28 ` [PATCH 7/9] ARM: versatile: move mach includes into mach directory Rob Herring
2014-12-30 22:05 ` Arnd Bergmann
2014-12-30 19:28 ` [PATCH 8/9] ARM: versatile: convert to multi-platform Rob Herring
2014-12-30 19:28 ` [PATCH 9/9] ARM: versatile: consolidate code to single file Rob Herring
2014-12-30 22:08 ` [PATCH 0/9] ARM Versatile multi-platform support Arnd Bergmann
2014-12-31 9:25 ` Peter Maydell
2015-01-05 9:50 ` Marc Zyngier
2015-01-05 10:08 ` Peter Maydell
2015-01-05 11:19 ` Marc Zyngier
2015-01-05 17:41 ` Peter Maydell
2015-01-08 19:47 ` Linus Walleij
2015-01-08 21:38 ` Rob Herring
2015-01-09 8:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13417872.31IhE1RbAx@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox