From: thomas.abraham@linaro.org (Thomas Abraham)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] mmc: dw_mmc: allow probe to succeed even if one slot is initialized
Date: Thu, 12 Jul 2012 18:24:24 +0530 [thread overview]
Message-ID: <1342097668-25243-3-git-send-email-thomas.abraham@linaro.org> (raw)
In-Reply-To: <1342097668-25243-1-git-send-email-thomas.abraham@linaro.org>
Instead of aborting the probe in case a slot initialization fails, allow
initialization of as many slots as possible. If there are atleast one
instance of slot that is successfully initialized, allow the driver probe
to succeed.
Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
---
drivers/mmc/host/dw_mmc.c | 23 +++++++++++++----------
1 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 948a7ac..cd58063 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1939,6 +1939,7 @@ int dw_mci_probe(struct dw_mci *host)
{
int width, i, ret = 0;
u32 fifo_size;
+ int init_slots = 0;
if (!host->pdata || !host->pdata->init) {
dev_err(host->dev,
@@ -2047,10 +2048,18 @@ int dw_mci_probe(struct dw_mci *host)
/* We need at least one slot to succeed */
for (i = 0; i < host->num_slots; i++) {
ret = dw_mci_init_slot(host, i);
- if (ret) {
- ret = -ENODEV;
- goto err_init_slot;
- }
+ if (ret)
+ dev_dbg(host->dev, "slot %d init failed\n", i);
+ else
+ init_slots++;
+ }
+
+ if (init_slots) {
+ dev_info(host->dev, "%d slots initialized\n", init_slots);
+ } else {
+ dev_dbg(host->dev, "attempted to initialize %d slots, "
+ "but failed on all\n", host->num_slots);
+ goto err_init_slot;
}
/*
@@ -2085,12 +2094,6 @@ int dw_mci_probe(struct dw_mci *host)
return 0;
err_init_slot:
- /* De-init any initialized slots */
- while (i > 0) {
- if (host->slot[i])
- dw_mci_cleanup_slot(host->slot[i], i);
- i--;
- }
free_irq(host->irq, host);
err_workqueue:
--
1.6.6.rc2
next prev parent reply other threads:[~2012-07-12 12:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 12:54 [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 1/6] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference Thomas Abraham
2012-07-12 12:54 ` Thomas Abraham [this message]
2012-07-12 12:54 ` [PATCH v3 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-07-13 9:11 ` Girish K S
2012-07-17 10:38 ` [PATCH 3/9] " Thomas Abraham
2012-07-19 10:27 ` Seungwon Jeon
2012-07-12 12:54 ` [PATCH v3 4/6] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 5/6] mmc: dw_mmc: add device tree support Thomas Abraham
2012-07-16 4:15 ` Girish K S
2012-07-16 4:30 ` Girish K S
2012-07-17 10:19 ` Thomas Abraham
2012-07-16 4:23 ` Chris Ball
2012-07-17 10:21 ` Thomas Abraham
2012-07-17 10:37 ` [PATCH 5/9] " Thomas Abraham
2012-07-12 12:54 ` [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions Thomas Abraham
2012-07-19 3:51 ` Seungwon Jeon
2012-07-19 18:48 ` Thomas Abraham
2012-07-20 10:38 ` Seungwon Jeon
2012-07-23 6:17 ` Thomas Abraham
2012-07-23 9:59 ` Seungwon Jeon
2012-07-19 15:28 ` [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation Jaehoon Chung
2012-07-19 18:59 ` Thomas Abraham
2012-07-19 22:47 ` Kukjin Kim
2012-07-23 1:57 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342097668-25243-3-git-send-email-thomas.abraham@linaro.org \
--to=thomas.abraham@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).