From: sedat.dilek@gmail.com (Sedat Dilek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] random: Remove remaining relicts of rand_initialize_irq()
Date: Tue, 17 Jul 2012 13:33:13 +0200 [thread overview]
Message-ID: <1342524793-2522-1-git-send-email-sedat.dilek@gmail.com> (raw)
rand_initialize_irq() was removed here:
commit 946672f548682905d8ecdab33bb6e2c705418505
"random: remove rand_initialize_irq()"
The AB3100 mfd-driver is the only driver still using it and breaks
with the following error-messages in linux-next (next-20120717):
...
drivers/built-in.o: In function `ab3100_probe':
ab3100-core.c:(.devinit.text+0xbf97): undefined reference to `rand_initialize_irq'
Fix this issue and remove all remaining relicts of rand_initialize_irq().
Might be worth to fold-in these changes into the original commit.
Tested against linux-next (next-20120717) on a Ubuntu/precise AMD64 host.
[ v2: Polish up subject and commit message ]
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
arch/ia64/kernel/irq_ia64.c | 1 -
drivers/mfd/ab3100-core.c | 2 --
include/linux/random.h | 2 --
3 files changed, 5 deletions(-)
diff --git a/arch/ia64/kernel/irq_ia64.c b/arch/ia64/kernel/irq_ia64.c
index 5c3e088..1034884 100644
--- a/arch/ia64/kernel/irq_ia64.c
+++ b/arch/ia64/kernel/irq_ia64.c
@@ -23,7 +23,6 @@
#include <linux/ioport.h>
#include <linux/kernel_stat.h>
#include <linux/ptrace.h>
-#include <linux/random.h> /* for rand_initialize_irq() */
#include <linux/signal.h>
#include <linux/smp.h>
#include <linux/threads.h>
diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c
index e799050..78fca29 100644
--- a/drivers/mfd/ab3100-core.c
+++ b/drivers/mfd/ab3100-core.c
@@ -934,8 +934,6 @@ static int __devinit ab3100_probe(struct i2c_client *client,
IRQF_ONESHOT, "ab3100-core", ab3100);
if (err)
goto exit_no_irq;
- /* This real unpredictable IRQ is of course sampled for entropy */
- rand_initialize_irq(client->irq);
err = abx500_register_ops(&client->dev, &ab3100_ops);
if (err)
diff --git a/include/linux/random.h b/include/linux/random.h
index 29e217a..ac621ce 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -48,8 +48,6 @@ struct rnd_state {
#ifdef __KERNEL__
-extern void rand_initialize_irq(int irq);
-
extern void add_device_randomness(const void *, unsigned int);
extern void add_input_randomness(unsigned int type, unsigned int code,
unsigned int value);
--
1.7.9.5
next reply other threads:[~2012-07-17 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 11:33 Sedat Dilek [this message]
2012-07-17 17:12 ` [PATCH -next] random: Remove remaining relicts of rand_initialize_irq() Theodore Ts'o
2012-07-17 18:57 ` Linus Walleij
2012-07-17 21:42 ` Theodore Ts'o
2012-07-23 14:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342524793-2522-1-git-send-email-sedat.dilek@gmail.com \
--to=sedat.dilek@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).