From mboxrd@z Thu Jan 1 00:00:00 1970 From: t-kristo@ti.com (Tero Kristo) Date: Wed, 18 Jul 2012 12:51:45 +0300 Subject: [PATCHv6 2/7] ARM: OMAP4460: Workaround for ROM bug because of CA9 r2pX GIC control register change. In-Reply-To: References: <1339428387-4800-1-git-send-email-t-kristo@ti.com> <1339428387-4800-3-git-send-email-t-kristo@ti.com> Message-ID: <1342605105.4672.95.camel@sokoban> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2012-07-18 at 03:17 -0600, Paul Walmsley wrote: > Hi > > one trivial comment > > On Mon, 11 Jun 2012, Tero Kristo wrote: > > > diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h > > index 46ab9d9..8d7de4f 100644 > > --- a/arch/arm/mach-omap2/pm.h > > +++ b/arch/arm/mach-omap2/pm.h > > @@ -88,6 +88,8 @@ extern void enable_omap3630_toggle_l2_on_restore(void); > > static inline void enable_omap3630_toggle_l2_on_restore(void) { } > > #endif /* defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP3) */ > > > > +#define PM_OMAP4_ROM_SMP_BOOT_ERRATUM_xxx (1 << 0) > > "xxx" isn't unique, nor is it descriptive :-) > > Looking at the mail threads on this one, it sounds like there may not be a > public erratum number associated with this. If there is, the 'xxx' should > be replaced with the number. If there isn't, then it would be good to > make up something short, like "GICD" to replace the "xxx". There isn't public erratum number for this, thats the reason for xxx. I can change the xxx to GICD though if that is better. -Tero