From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 3/7] ARM: OMAP4: hwmod: flag hwmods/modules not supporting module level context status
Date: Wed, 18 Jul 2012 19:23:26 +0300 [thread overview]
Message-ID: <1342628606.4672.112.camel@sokoban> (raw)
In-Reply-To: <CAOMWX4e9bpJivetsx-FD_U7BbjrWh0Xto-7MTUe5YK8Mjpi9Sg@mail.gmail.com>
On Tue, 2012-07-17 at 03:11 -0500, Menon, Nishanth wrote:
> On Mon, Jun 11, 2012 at 10:26 AM, Tero Kristo <t-kristo@ti.com> wrote:
> > On OMAP4 most modules/hwmods support module level context status. On
> > OMAP3 and earlier, we relied on the power domain level context status.
> > Identify all modules that don't support 'context_offs' by marking the
> > offset as USHRT_MAX. Rest have a valid 'context_offs' populated in
> > .prcm structure already.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > ---
> > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > index 86fc513..828e7b8 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > @@ -208,6 +208,7 @@ static struct omap_hwmod omap44xx_l4_abe_hwmod = {
> > .prcm = {
> > .omap4 = {
> > .clkctrl_offs = OMAP4_CM1_ABE_L4ABE_CLKCTRL_OFFSET,
> > + .context_offs = USHRT_MAX,
>
> OMAP4430_RM_ABE_AESS_CONTEXT? why not use LOSTMEM_AESSMEM ? ABE will
> need to know when it lost context to be able to reload it's firmware,
> no?
It looks like current hwmod data doesn't support specific bits to be
used for the context declaration, it is only specifying the register
offset. Also, the same register is used by aess hwmod, so this will
cause a conflict if I take the same register into use.
This could be fixed by adding a field for the context bits, but I guess
this should be commented upon by someone (Benoit / Paul) before I craft
some sort of patch for that.
Meanwhile, I will keep the USHRT_MAX here until better solution is
available.
-Tero
next prev parent reply other threads:[~2012-07-18 16:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 15:26 [PATCHv6 0/7] ARM: OMAP4: core retention support Tero Kristo
2012-06-11 15:26 ` [PATCHv6 1/7] ARM: OMAP4: PM: add errata support Tero Kristo
2012-06-11 15:26 ` [PATCHv6 2/7] ARM: OMAP4460: Workaround for ROM bug because of CA9 r2pX GIC control register change Tero Kristo
2012-07-18 9:17 ` Paul Walmsley
2012-07-18 9:51 ` Tero Kristo
2012-07-18 9:54 ` Paul Walmsley
2012-06-11 15:26 ` [PATCHv6 3/7] ARM: OMAP4: hwmod: flag hwmods/modules not supporting module level context status Tero Kristo
2012-07-17 8:11 ` Menon, Nishanth
2012-07-18 9:00 ` Tero Kristo
2012-07-18 16:23 ` Tero Kristo [this message]
2012-07-18 17:24 ` Paul Walmsley
2012-07-19 9:50 ` Tero Kristo
2012-06-11 15:26 ` [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count Tero Kristo
2012-07-17 7:59 ` Menon, Nishanth
2012-07-18 9:15 ` Tero Kristo
2012-07-19 5:55 ` Menon, Nishanth
2012-07-19 9:49 ` Tero Kristo
2012-07-19 10:27 ` Menon, Nishanth
2012-07-19 11:47 ` Tero Kristo
2012-07-19 10:35 ` Shilimkar, Santosh
2012-07-19 11:44 ` Tero Kristo
2012-07-19 7:00 ` Menon, Nishanth
2012-06-11 15:26 ` [PATCHv6 5/7] ARM: OMAP4: pwrdm: add support for reading prev logic and mem states Tero Kristo
2012-06-11 15:26 ` [PATCHv6 6/7] ARM: OMAP4: suspend: Program all domains to retention Tero Kristo
2012-06-11 15:26 ` [PATCHv6 7/7] ARM: OMAP4: PM: put all domains to OSWR during suspend Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342628606.4672.112.camel@sokoban \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).