From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ASoC: sgtl5000: remove unneeded snd_soc_dapm_new_widgets in probe
Date: Fri, 20 Jul 2012 17:20:26 +0800 [thread overview]
Message-ID: <1342776027-31758-4-git-send-email-b29396@freescale.com> (raw)
In-Reply-To: <1342776027-31758-1-git-send-email-b29396@freescale.com>
From: Dong Aisheng <dong.aisheng@linaro.org>
There's a driver bug that sgtl5000 dapm widget kcontrols do not work.
e.g. can not select capture mux with amixer tool(no error info prompted).
The root cause is that we still call snd_soc_dapm_new_widgets in
codec driver probe function afer converting to table based widgets.
This will cause the card dapm widgets are instantiated before the
dapm_routes are registered.
Then, no available dapm widget pathes can be found during instantiation
which finally will cause soc_dapm_mux_update_power to fail(can not find
correct path with kcontrol) in snd_soc_dapm_put_enum_double function.
Here we remove the unneeded snd_soc_dapm_new_widgets in codec probe
and let the soc core to handle the register sequence properly.
Then we can fix above issue.
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
sound/soc/codecs/sgtl5000.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 8af6a52..5c54b6f 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -1357,8 +1357,6 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)
if (ret)
goto err;
- snd_soc_dapm_new_widgets(&codec->dapm);
-
return 0;
err:
--
1.7.0.4
next prev parent reply other threads:[~2012-07-20 9:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 9:20 [PATCH 0/4] ASoC: fix saif record unwork issue Dong Aisheng
2012-07-20 9:20 ` [PATCH 1/4] ASoC: mxs-saif: fix clock prepare and enable unbalance issue Dong Aisheng
2012-07-21 7:03 ` [alsa-devel] " Shawn Guo
2012-07-24 19:18 ` Mark Brown
2016-01-16 16:24 ` Måns Rullgård
2012-07-20 9:20 ` [PATCH 2/4] ASoC: mxs-saif: set a base clock rate for EXTMASTER mode work Dong Aisheng
2012-07-21 7:20 ` [alsa-devel] " Shawn Guo
2012-07-24 19:18 ` Mark Brown
2012-07-20 9:20 ` Dong Aisheng [this message]
2012-07-21 8:37 ` [alsa-devel] [PATCH 3/4] ASoC: sgtl5000: remove unneeded snd_soc_dapm_new_widgets in probe Shawn Guo
2012-07-24 19:20 ` Mark Brown
2012-07-20 9:20 ` [PATCH 4/4] ARM: mx28evk: add missed clkmux select for saif Dong Aisheng
2012-07-21 7:40 ` [alsa-devel] " Shawn Guo
2012-07-23 2:36 ` Dong Aisheng
2012-07-28 8:25 ` Shawn Guo
2012-08-01 2:47 ` Dong Aisheng
2012-07-24 12:46 ` [alsa-devel] [PATCH 0/4] ASoC: fix saif record unwork issue Lauri Hintsala
2012-07-24 19:21 ` Mark Brown
2012-07-25 5:26 ` Lauri Hintsala
2012-07-25 6:44 ` Dong Aisheng
2012-07-25 8:55 ` Lauri Hintsala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342776027-31758-4-git-send-email-b29396@freescale.com \
--to=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).