* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. @ 2012-07-21 2:00 Tony Prisk 2012-07-21 2:00 ` [PATCHv3 2/2] ARM: vt8500: Add support for UHCI companion controller Tony Prisk 0 siblings, 1 reply; 8+ messages in thread From: Tony Prisk @ 2012-07-21 2:00 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Tony Prisk <linux@prisktech.co.nz> --- .../devicetree/bindings/usb/vt8500-ehci.txt | 10 ++++++++++ drivers/usb/host/ehci-vt8500.c | 9 +++++++++ 2 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt diff --git a/Documentation/devicetree/bindings/usb/vt8500-ehci.txt b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt new file mode 100644 index 0000000..74f75c6 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt @@ -0,0 +1,10 @@ +VIA VT8500 and Wondermedia WM8xxx SoC USB controllers. + +Required properties: + - compatible: Should be "via,vt8500-ehci" or "wm,prizm-ehci". + +usb: ehci at D8007100 { + compatible = "wm,prizm-ehci", "usb-ehci"; + reg = <0xD8007100 0x200>; + interrupts = <1>; +}; diff --git a/drivers/usb/host/ehci-vt8500.c b/drivers/usb/host/ehci-vt8500.c index c1eda73..4ba8f0c 100644 --- a/drivers/usb/host/ehci-vt8500.c +++ b/drivers/usb/host/ehci-vt8500.c @@ -16,6 +16,7 @@ * */ +#include <linux/of.h> #include <linux/platform_device.h> static int ehci_update_device(struct usb_hcd *hcd, struct usb_device *udev) @@ -162,6 +163,12 @@ static int vt8500_ehci_drv_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id vt8500_ehci_ids[] = { + { .compatible = "via,vt8500-ehci", }, + { .compatible = "wm,prizm-ehci", }, + {} +}; + static struct platform_driver vt8500_ehci_driver = { .probe = vt8500_ehci_drv_probe, .remove = vt8500_ehci_drv_remove, @@ -169,7 +176,9 @@ static struct platform_driver vt8500_ehci_driver = { .driver = { .name = "vt8500-ehci", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(vt8500_ehci_ids), } }; MODULE_ALIAS("platform:vt8500-ehci"); +MODULE_DEVICE_TABLE(of, vt8500_ehci_ids); -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCHv3 2/2] ARM: vt8500: Add support for UHCI companion controller 2012-07-21 2:00 [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Tony Prisk @ 2012-07-21 2:00 ` Tony Prisk 0 siblings, 0 replies; 8+ messages in thread From: Tony Prisk @ 2012-07-21 2:00 UTC (permalink / raw) To: linux-arm-kernel Add support for a generic non-pci UHCI companion controller. Existing board files for arch-vt8500 updated to include UHCI support. Signed-off-by: Tony Prisk <linux@prisktech.co.nz> --- V3: Added the missing commits for the board files. arch/arm/mach-vt8500/bv07.c | 1 + arch/arm/mach-vt8500/devices-vt8500.c | 5 + arch/arm/mach-vt8500/devices-wm8505.c | 4 + arch/arm/mach-vt8500/devices.c | 11 +++ arch/arm/mach-vt8500/devices.h | 1 + arch/arm/mach-vt8500/wm8505_7in.c | 1 + drivers/usb/host/Kconfig | 12 ++- drivers/usb/host/uhci-hcd.c | 5 + drivers/usb/host/uhci-platform.c | 157 +++++++++++++++++++++++++++++++++ 9 files changed, 195 insertions(+), 2 deletions(-) create mode 100644 drivers/usb/host/uhci-platform.c diff --git a/arch/arm/mach-vt8500/bv07.c b/arch/arm/mach-vt8500/bv07.c index a464c75..19d20d9 100644 --- a/arch/arm/mach-vt8500/bv07.c +++ b/arch/arm/mach-vt8500/bv07.c @@ -32,6 +32,7 @@ static struct platform_device *devices[] __initdata = { &vt8500_device_uart0, &vt8500_device_lcdc, &vt8500_device_ehci, + &vt8500_device_uhci, &vt8500_device_ge_rops, &vt8500_device_pwm, &vt8500_device_pwmbl, diff --git a/arch/arm/mach-vt8500/devices-vt8500.c b/arch/arm/mach-vt8500/devices-vt8500.c index 19519ae..def7fe3 100644 --- a/arch/arm/mach-vt8500/devices-vt8500.c +++ b/arch/arm/mach-vt8500/devices-vt8500.c @@ -48,6 +48,11 @@ void __init vt8500_set_resources(void) tmp[1] = wmt_irq_res(IRQ_EHCI); wmt_res_add(&vt8500_device_ehci, tmp, 2); + /* vt8500 uses a single IRQ for both EHCI and UHCI controllers */ + tmp[0] = wmt_mmio_res(VT8500_UHCI_BASE, SZ_512); + tmp[1] = wmt_irq_res(IRQ_EHCI); + wmt_res_add(&vt8500_device_uhci, tmp, 2); + tmp[0] = wmt_mmio_res(VT8500_GEGEA_BASE, SZ_256); wmt_res_add(&vt8500_device_ge_rops, tmp, 1); diff --git a/arch/arm/mach-vt8500/devices-wm8505.c b/arch/arm/mach-vt8500/devices-wm8505.c index db4594e..c810454 100644 --- a/arch/arm/mach-vt8500/devices-wm8505.c +++ b/arch/arm/mach-vt8500/devices-wm8505.c @@ -55,6 +55,10 @@ void __init wm8505_set_resources(void) tmp[1] = wmt_irq_res(IRQ_EHCI); wmt_res_add(&vt8500_device_ehci, tmp, 2); + tmp[0] = wmt_mmio_res(WM8505_UHCI_BASE, SZ_512); + tmp[1] = wmt_irq_res(IRQ_UHCI); + wmt_res_add(&vt8500_device_uhci, tmp, 2); + tmp[0] = wmt_mmio_res(WM8505_GEGEA_BASE, SZ_256); wmt_res_add(&vt8500_device_ge_rops, tmp, 1); diff --git a/arch/arm/mach-vt8500/devices.c b/arch/arm/mach-vt8500/devices.c index 1fcdc36..46ff82d 100644 --- a/arch/arm/mach-vt8500/devices.c +++ b/arch/arm/mach-vt8500/devices.c @@ -204,6 +204,17 @@ struct platform_device vt8500_device_ehci = { }, }; +static u64 uhci_dma_mask = DMA_BIT_MASK(32); + +struct platform_device vt8500_device_uhci = { + .name = "platform-uhci", + .id = 0, + .dev = { + .dma_mask = &uhci_dma_mask, + .coherent_dma_mask = DMA_BIT_MASK(32), + }, +}; + struct platform_device vt8500_device_ge_rops = { .name = "wmt_ge_rops", .id = -1, diff --git a/arch/arm/mach-vt8500/devices.h b/arch/arm/mach-vt8500/devices.h index 188d4e1..0e6d9f9 100644 --- a/arch/arm/mach-vt8500/devices.h +++ b/arch/arm/mach-vt8500/devices.h @@ -81,6 +81,7 @@ extern struct platform_device vt8500_device_uart5; extern struct platform_device vt8500_device_lcdc; extern struct platform_device vt8500_device_wm8505_fb; extern struct platform_device vt8500_device_ehci; +extern struct platform_device vt8500_device_uhci; extern struct platform_device vt8500_device_ge_rops; extern struct platform_device vt8500_device_pwm; extern struct platform_device vt8500_device_pwmbl; diff --git a/arch/arm/mach-vt8500/wm8505_7in.c b/arch/arm/mach-vt8500/wm8505_7in.c index cf910a9..302ae2f 100644 --- a/arch/arm/mach-vt8500/wm8505_7in.c +++ b/arch/arm/mach-vt8500/wm8505_7in.c @@ -31,6 +31,7 @@ static void __iomem *pmc_hiber; static struct platform_device *devices[] __initdata = { &vt8500_device_uart0, &vt8500_device_ehci, + &vt8500_device_uhci, &vt8500_device_wm8505_fb, &vt8500_device_ge_rops, &vt8500_device_pwm, diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 83e58df..3d153d0 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -450,7 +450,7 @@ config USB_OHCI_LITTLE_ENDIAN config USB_UHCI_HCD tristate "UHCI HCD (most Intel and VIA) support" - depends on USB && (PCI || SPARC_LEON) + depends on USB && (PCI || SPARC_LEON || ARCH_VT8500) ---help--- The Universal Host Controller Interface is a standard by Intel for accessing the USB hardware in the PC (which is also called the USB @@ -468,7 +468,15 @@ config USB_UHCI_HCD config USB_UHCI_SUPPORT_NON_PCI_HC bool depends on USB_UHCI_HCD - default y if SPARC_LEON + default y if (SPARC_LEON || ARCH_VT8500) + +config USB_UHCI_PLATFORM + bool "Generic UHCI Platform Driver support" + depends on USB_UHCI_SUPPORT_NON_PCI_HC + default y if ARCH_VT8500 + ---help--- + Enable support for generic UHCI platform devices that require no + additional configuration. config USB_UHCI_BIG_ENDIAN_MMIO bool diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c index e4db350..4b9e9ab 100644 --- a/drivers/usb/host/uhci-hcd.c +++ b/drivers/usb/host/uhci-hcd.c @@ -846,6 +846,11 @@ static const char hcd_name[] = "uhci_hcd"; #define PLATFORM_DRIVER uhci_grlib_driver #endif +#ifdef CONFIG_USB_UHCI_PLATFORM +#include "uhci-platform.c" +#define PLATFORM_DRIVER uhci_platform_driver +#endif + #if !defined(PCI_DRIVER) && !defined(PLATFORM_DRIVER) #error "missing bus glue for uhci-hcd" #endif diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c new file mode 100644 index 0000000..dafe42a --- /dev/null +++ b/drivers/usb/host/uhci-platform.c @@ -0,0 +1,157 @@ +/* + * Generic UHCI HCD (Host Controller Driver) for Platform Devices + * + * Copyright (c) 2011 Tony Prisk <linux@prisktech.co.nz> + * + * This file is based on uhci-grlib.c + * (C) Copyright 2004-2007 Alan Stern, stern at rowland.harvard.edu + */ + +#include <linux/of.h> +#include <linux/platform_device.h> + +static int uhci_platform_init(struct usb_hcd *hcd) +{ + struct uhci_hcd *uhci = hcd_to_uhci(hcd); + + uhci->rh_numports = uhci_count_ports(hcd); + + /* Set up pointers to to generic functions */ + uhci->reset_hc = uhci_generic_reset_hc; + uhci->check_and_reset_hc = uhci_generic_check_and_reset_hc; + + /* No special actions need to be taken for the functions below */ + uhci->configure_hc = NULL; + uhci->resume_detect_interrupts_are_broken = NULL; + uhci->global_suspend_mode_is_broken = NULL; + + /* Reset if the controller isn't already safely quiescent. */ + check_and_reset_hc(uhci); + return 0; +} + +static const struct hc_driver uhci_platform_hc_driver = { + .description = hcd_name, + .product_desc = "Generic UHCI Host Controller", + .hcd_priv_size = sizeof(struct uhci_hcd), + + /* Generic hardware linkage */ + .irq = uhci_irq, + .flags = HCD_MEMORY | HCD_USB11, + + /* Basic lifecycle operations */ + .reset = uhci_platform_init, + .start = uhci_start, +#ifdef CONFIG_PM + .pci_suspend = NULL, + .pci_resume = NULL, + .bus_suspend = uhci_rh_suspend, + .bus_resume = uhci_rh_resume, +#endif + .stop = uhci_stop, + + .urb_enqueue = uhci_urb_enqueue, + .urb_dequeue = uhci_urb_dequeue, + + .endpoint_disable = uhci_hcd_endpoint_disable, + .get_frame_number = uhci_hcd_get_frame_number, + + .hub_status_data = uhci_hub_status_data, + .hub_control = uhci_hub_control, +}; + + +static int __devinit uhci_hcd_platform_probe(struct platform_device *pdev) +{ + struct usb_hcd *hcd; + struct uhci_hcd *uhci; + struct resource *res; + int ret; + + if (usb_disabled()) + return -ENODEV; + + hcd = usb_create_hcd(&uhci_platform_hc_driver, &pdev->dev, + pdev->name); + if (!hcd) + return -ENOMEM; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + hcd->rsrc_start = res->start; + hcd->rsrc_len = resource_size(res); + + if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, hcd_name)) { + pr_err("%s: request_mem_region failed\n", __func__); + ret = -EBUSY; + goto err_rmr; + } + + hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len); + if (!hcd->regs) { + pr_err("%s: ioremap failed\n", __func__); + ret = -ENOMEM; + goto err_irq; + } + uhci = hcd_to_uhci(hcd); + + uhci->regs = hcd->regs; + + ret = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_DISABLED | + IRQF_SHARED); + if (ret) + goto err_uhci; + + return 0; + +err_uhci: + iounmap(hcd->regs); +err_irq: + release_mem_region(hcd->rsrc_start, hcd->rsrc_len); +err_rmr: + usb_put_hcd(hcd); + + return ret; +} + +static int uhci_hcd_platform_remove(struct platform_device *pdev) +{ + struct usb_hcd *hcd = platform_get_drvdata(pdev); + + usb_remove_hcd(hcd); + iounmap(hcd->regs); + release_mem_region(hcd->rsrc_start, hcd->rsrc_len); + usb_put_hcd(hcd); + platform_set_drvdata(pdev, NULL); + + return 0; +} + +/* Make sure the controller is quiescent and that we're not using it + * any more. This is mainly for the benefit of programs which, like kexec, + * expect the hardware to be idle: not doing DMA or generating IRQs. + * + * This routine may be called in a damaged or failing kernel. Hence we + * do not acquire the spinlock before shutting down the controller. + */ +static void uhci_hcd_platform_shutdown(struct platform_device *op) +{ + struct usb_hcd *hcd = dev_get_drvdata(&op->dev); + + uhci_hc_died(hcd_to_uhci(hcd)); +} + +static const struct of_device_id platform_uhci_ids[] = { + { .compatible = "of-uhci", }, + {} +}; + +static struct platform_driver uhci_platform_driver = { + .probe = uhci_hcd_platform_probe, + .remove = uhci_hcd_platform_remove, + .shutdown = uhci_hcd_platform_shutdown, + .driver = { + .name = "platform-uhci", + .owner = THIS_MODULE, + .of_match_table = of_match_ptr(platform_uhci_ids), + }, +}; -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. @ 2012-07-19 16:07 Tony Prisk 0 siblings, 0 replies; 8+ messages in thread From: Tony Prisk @ 2012-07-19 16:07 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Tony Prisk <linux@prisktech.co.nz> --- .../devicetree/bindings/usb/vt8500-ehci.txt | 12 ++++++++++++ drivers/usb/host/ehci-vt8500.c | 9 +++++++++ 2 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt diff --git a/Documentation/devicetree/bindings/usb/vt8500-ehci.txt b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt new file mode 100644 index 0000000..c14b38c --- /dev/null +++ b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt @@ -0,0 +1,12 @@ +VIA VT8500 and Wondermedia WM8xxx SoC USB controllers. + +EHCI + +Required properties: + - compatible: Should be "via,vt8500-ehci" or "wm,prizm-ehci". + +usb: ehci at D8007100 { + compatible = "wm,prizm-ehci", "usb-ehci"; + reg = <0xD8007100 0x200>; + interrupts = <1>; +}; diff --git a/drivers/usb/host/ehci-vt8500.c b/drivers/usb/host/ehci-vt8500.c index c1eda73..4ba8f0c 100644 --- a/drivers/usb/host/ehci-vt8500.c +++ b/drivers/usb/host/ehci-vt8500.c @@ -16,6 +16,7 @@ * */ +#include <linux/of.h> #include <linux/platform_device.h> static int ehci_update_device(struct usb_hcd *hcd, struct usb_device *udev) @@ -162,6 +163,12 @@ static int vt8500_ehci_drv_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id vt8500_ehci_ids[] = { + { .compatible = "via,vt8500-ehci", }, + { .compatible = "wm,prizm-ehci", }, + {} +}; + static struct platform_driver vt8500_ehci_driver = { .probe = vt8500_ehci_drv_probe, .remove = vt8500_ehci_drv_remove, @@ -169,7 +176,9 @@ static struct platform_driver vt8500_ehci_driver = { .driver = { .name = "vt8500-ehci", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(vt8500_ehci_ids), } }; MODULE_ALIAS("platform:vt8500-ehci"); +MODULE_DEVICE_TABLE(of, vt8500_ehci_ids); -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. @ 2012-07-19 13:31 Tony Prisk 2012-07-19 14:23 ` Arnd Bergmann 2012-07-19 14:45 ` Alexey Charkov 0 siblings, 2 replies; 8+ messages in thread From: Tony Prisk @ 2012-07-19 13:31 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Tony Prisk <linux@prisktech.co.nz> --- drivers/usb/host/ehci-vt8500.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-vt8500.c b/drivers/usb/host/ehci-vt8500.c index c1eda73..4ba8f0c 100644 --- a/drivers/usb/host/ehci-vt8500.c +++ b/drivers/usb/host/ehci-vt8500.c @@ -16,6 +16,7 @@ * */ +#include <linux/of.h> #include <linux/platform_device.h> static int ehci_update_device(struct usb_hcd *hcd, struct usb_device *udev) @@ -162,6 +163,12 @@ static int vt8500_ehci_drv_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id vt8500_ehci_ids[] = { + { .compatible = "via,vt8500-ehci", }, + { .compatible = "wm,prizm-ehci", }, + {} +}; + static struct platform_driver vt8500_ehci_driver = { .probe = vt8500_ehci_drv_probe, .remove = vt8500_ehci_drv_remove, @@ -169,7 +176,9 @@ static struct platform_driver vt8500_ehci_driver = { .driver = { .name = "vt8500-ehci", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(vt8500_ehci_ids), } }; MODULE_ALIAS("platform:vt8500-ehci"); +MODULE_DEVICE_TABLE(of, vt8500_ehci_ids); -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. 2012-07-19 13:31 Tony Prisk @ 2012-07-19 14:23 ` Arnd Bergmann 2012-07-19 14:45 ` Alexey Charkov 1 sibling, 0 replies; 8+ messages in thread From: Arnd Bergmann @ 2012-07-19 14:23 UTC (permalink / raw) To: linux-arm-kernel On Thursday 19 July 2012, Tony Prisk wrote: > > Signed-off-by: Tony Prisk <linux@prisktech.co.nz> > --- > drivers/usb/host/ehci-vt8500.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) The addition is straightforward and looks correct, but I would suggest you also add the new "compatible" values to Documentation/devicetree/bindings/usb-ehci.txt Arnd ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. 2012-07-19 13:31 Tony Prisk 2012-07-19 14:23 ` Arnd Bergmann @ 2012-07-19 14:45 ` Alexey Charkov 2012-07-19 14:51 ` Tony Prisk 2012-07-19 15:31 ` Tony Prisk 1 sibling, 2 replies; 8+ messages in thread From: Alexey Charkov @ 2012-07-19 14:45 UTC (permalink / raw) To: linux-arm-kernel 2012/7/19 Tony Prisk <linux@prisktech.co.nz>: > Signed-off-by: Tony Prisk <linux@prisktech.co.nz> > --- > drivers/usb/host/ehci-vt8500.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Have you tried to use ehci-platform on VIA/WMT devices? If it works (which I would expect), I believe it's better to include OF support into ehci-platform and drop ehci-vt8500 completely after existing boards are converted to Device Tree. When writing ehci-vt8500, I mostly only copied stuff from the PCI version and made it initialize from the platform bus (nothing specific to vt8500). Thanks, Alexey ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. 2012-07-19 14:45 ` Alexey Charkov @ 2012-07-19 14:51 ` Tony Prisk 2012-07-19 15:31 ` Tony Prisk 1 sibling, 0 replies; 8+ messages in thread From: Tony Prisk @ 2012-07-19 14:51 UTC (permalink / raw) To: linux-arm-kernel From: Alexey Charkov [alchark at gmail.com] Sent: 20 July 2012 02:45 To: vt8500-wm8505-linux-kernel at googlegroups.com Cc: Arnd Bergmann; linux-arm-kernel at lists.infradead.org; devicetree-discuss at lists.ozlabs.org; Tony Prisk Subject: Re: [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. 2012/7/19 Tony Prisk <linux@prisktech.co.nz>: > Signed-off-by: Tony Prisk <linux@prisktech.co.nz> > --- > drivers/usb/host/ehci-vt8500.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Have you tried to use ehci-platform on VIA/WMT devices? If it works (which I would expect), I believe it's better to include OF support into ehci-platform and drop ehci-vt8500 completely after existing boards are converted to Device Tree. When writing ehci-vt8500, I mostly only copied stuff from the PCI version and made it initialize from the platform bus (nothing specific to vt8500). Thanks, Alexey ----- Alexey, The biggest problem I have at the moment is that its very hard to test anything as I only have a WM8650 which isn't supported in mainline. I think I have a local copy of 'our' repo on my laptop - If I do, I'll try changing the platform_device to use ehci_platform and see if it works. Arnd, There isn't any reason why it couldn't be uhci_of. I was simply trying to preserve our existing platform support without having to introduce more patches for the board files. The existing uhci-grlib is probably a better candidate though as I noticed its been updated to support OF since I wrote this driver, and this driver is based off that one. Regards Tony P ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. 2012-07-19 14:45 ` Alexey Charkov 2012-07-19 14:51 ` Tony Prisk @ 2012-07-19 15:31 ` Tony Prisk 1 sibling, 0 replies; 8+ messages in thread From: Tony Prisk @ 2012-07-19 15:31 UTC (permalink / raw) To: linux-arm-kernel From: Alexey Charkov [alchark at gmail.com] Sent: 20 July 2012 02:45 To: vt8500-wm8505-linux-kernel at googlegroups.com Cc: Arnd Bergmann; linux-arm-kernel at lists.infradead.org; devicetree-discuss at lists.ozlabs.org; Tony Prisk Subject: Re: [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree. 2012/7/19 Tony Prisk <linux@prisktech.co.nz>: > Signed-off-by: Tony Prisk <linux@prisktech.co.nz> > --- > drivers/usb/host/ehci-vt8500.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Have you tried to use ehci-platform on VIA/WMT devices? If it works (which I would expect), I believe it's better to include OF support into ehci-platform and drop ehci-vt8500 completely after existing boards are converted to Device Tree. When writing ehci-vt8500, I mostly only copied stuff from the PCI version and made it initialize from the platform bus (nothing specific to vt8500). Thanks, Alexey ----- The ehci-platform device requires platform_data be passed at probe. While its generic enought , it puts requirements on the device-tree to setup the private data, which would be messy to get approved I suspect. Regards Tony P ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-07-21 2:00 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-21 2:00 [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Tony Prisk 2012-07-21 2:00 ` [PATCHv3 2/2] ARM: vt8500: Add support for UHCI companion controller Tony Prisk -- strict thread matches above, loose matches on Subject: below -- 2012-07-19 16:07 [PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree Tony Prisk 2012-07-19 13:31 Tony Prisk 2012-07-19 14:23 ` Arnd Bergmann 2012-07-19 14:45 ` Alexey Charkov 2012-07-19 14:51 ` Tony Prisk 2012-07-19 15:31 ` Tony Prisk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).