linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/21] ARM: ux500: Fork MSP platform registration for step-by-step DT enablement
Date: Thu, 26 Jul 2012 11:28:45 +0100	[thread overview]
Message-ID: <1343298534-13611-13-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1343298534-13611-1-git-send-email-lee.jones@linaro.org>

We've done this before and it worked well last time. Here we're
duplicating a complex registration function to ease the process
of enabling it for Device Tree. As there are quite a few steps
taken during the registration process, it makes sense to break
them up into more manageable chunks. This patch will aid us.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/mach-ux500/board-mop500-msp.c |   42 ++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/arch/arm/mach-ux500/board-mop500-msp.c b/arch/arm/mach-ux500/board-mop500-msp.c
index 217df1d..d0bd030 100644
--- a/arch/arm/mach-ux500/board-mop500-msp.c
+++ b/arch/arm/mach-ux500/board-mop500-msp.c
@@ -223,6 +223,48 @@ static struct msp_i2s_platform_data msp3_platform_data = {
 	.msp_i2s_exit = msp13_i2s_exit,
 };
 
+/* Due for removal once the MSP driver has been fully DT:ed. */
+void mop500_of_msp_init(struct device *parent)
+{
+	struct platform_device *msp1;
+
+	pr_info("%s: Register platform-device 'snd-soc-u8500'.\n", __func__);
+	platform_device_register(&snd_soc_mop500);
+
+	pr_info("Initialize MSP I2S-devices.\n");
+	db8500_add_msp_i2s(parent, 0, U8500_MSP0_BASE, IRQ_DB8500_MSP0,
+			   &msp0_platform_data);
+	msp1 = db8500_add_msp_i2s(parent, 1, U8500_MSP1_BASE, IRQ_DB8500_MSP1,
+			   &msp1_platform_data);
+	db8500_add_msp_i2s(parent, 2, U8500_MSP2_BASE, IRQ_DB8500_MSP2,
+			   &msp2_platform_data);
+	db8500_add_msp_i2s(parent, 3, U8500_MSP3_BASE, IRQ_DB8500_MSP1,
+			   &msp3_platform_data);
+
+	/* Get the pinctrl handle for MSP1 */
+	if (msp1) {
+		msp1_p = pinctrl_get(&msp1->dev);
+		if (IS_ERR(msp1_p))
+			dev_err(&msp1->dev, "could not get MSP1 pinctrl\n");
+		else {
+			msp1_def = pinctrl_lookup_state(msp1_p,
+							PINCTRL_STATE_DEFAULT);
+			if (IS_ERR(msp1_def)) {
+				dev_err(&msp1->dev,
+					"could not get MSP1 defstate\n");
+			}
+			msp1_sleep = pinctrl_lookup_state(msp1_p,
+							  PINCTRL_STATE_SLEEP);
+			if (IS_ERR(msp1_sleep))
+				dev_err(&msp1->dev,
+					"could not get MSP1 idlestate\n");
+		}
+	}
+
+	pr_info("%s: Register platform-device 'ux500-pcm'\n", __func__);
+	platform_device_register(&ux500_pcm);
+}
+
 void mop500_msp_init(struct device *parent)
 {
 	struct platform_device *msp1;
-- 
1.7.9.5

  parent reply	other threads:[~2012-07-26 10:28 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 10:28 [PATCH 00/21] Some fixes and DT enablement for ux500 audio Lee Jones
2012-07-26 10:28 ` [PATCH 01/21] ARM: ux500: Remove unused snowball_of_platform_devs struct Lee Jones
2012-07-26 10:28 ` [PATCH 02/21] MFD: db8500-prcmu: Ensure AB8500 platform data is passed through MFD Core Lee Jones
2012-07-26 10:28 ` [PATCH 03/21] ARM: ux500: Clean-up MSP platform code Lee Jones
2012-07-26 10:28 ` [PATCH 04/21] ASoC: ux500: Strengthen error checking after memory allocation Lee Jones
2012-07-26 11:57   ` Mark Brown
2012-07-26 10:28 ` [PATCH 05/21] ASoC: ux500: Include the correct header files Lee Jones
2012-07-26 11:58   ` Mark Brown
2012-07-26 10:28 ` [PATCH 06/21] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Lee Jones
2012-07-26 11:54   ` Mark Brown
2012-07-26 10:28 ` [PATCH 07/21] ASoC: io: Prevent use of regmap if request fails Lee Jones
2012-07-26 11:32   ` Mark Brown
2012-07-26 11:38     ` Lee Jones
2012-07-26 11:42       ` Mark Brown
2012-07-26 14:51         ` Lee Jones
2012-07-26 15:12           ` Mark Brown
2012-07-26 15:23             ` Lee Jones
2012-07-26 15:25               ` Mark Brown
2012-07-26 16:05                 ` Lee Jones
2012-07-26 20:23                   ` Mark Brown
2012-07-26 10:28 ` [PATCH 08/21] ARM: ux500: Add AB8500 CODEC node to DB8500 Device Tree Lee Jones
2012-07-26 10:28 ` [PATCH 09/21] ARM: ux500: Add MSP devices " Lee Jones
2012-07-26 10:28 ` [PATCH 10/21] ARM: ux500: Add ux500 PCM " Lee Jones
2012-07-26 10:28 ` [PATCH 11/21] ARM: ux500: Add all encompassing Sound node " Lee Jones
2012-07-26 10:28 ` Lee Jones [this message]
2012-07-26 10:28 ` [PATCH 13/21] ARM: ux500: Ensure probing of Audio devices when Device Tree is enabled Lee Jones
2012-07-26 10:28 ` [PATCH 14/21] ARM: ux500: Enable HIGHMEM on all mop500 platforms Lee Jones
2012-07-26 10:28 ` [PATCH 15/21] ARM: ux500: Pass MSP DMA platform data though AUXDATA Lee Jones
2012-07-26 10:28 ` [PATCH 16/21] ASoC: Ux500: Enable MOP500 driver for Device Tree Lee Jones
2012-07-26 11:37   ` Mark Brown
2012-07-26 13:51     ` Lee Jones
2012-07-26 13:53       ` Mark Brown
2012-07-26 14:51         ` Lee Jones
2012-07-26 10:28 ` [PATCH 17/21] ASoC: Ux500: Enable ux500 PCM " Lee Jones
2012-07-26 11:38   ` Mark Brown
2012-07-26 13:52     ` Lee Jones
2012-07-26 14:22       ` Mark Brown
2012-07-26 14:55         ` Lee Jones
2012-07-26 10:28 ` [PATCH 18/21] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-07-26 10:28 ` [PATCH 19/21] ASoC: Ux500: Enable ux500 MSP driver for Device Tree Lee Jones
2012-07-26 11:45   ` Mark Brown
2012-07-26 10:28 ` [PATCH 20/21] ASoC: codecs: Enable AB8500 CODEC " Lee Jones
2012-07-26 11:50   ` Mark Brown
2012-07-26 14:00     ` Lee Jones
2012-07-26 14:28       ` Mark Brown
2012-07-26 15:01         ` Lee Jones
2012-07-26 15:14           ` Mark Brown
2012-07-26 15:17             ` Lee Jones
2012-07-26 14:15     ` Lee Jones
2012-07-26 14:43       ` Mark Brown
2012-07-26 15:19         ` Lee Jones
2012-07-26 15:24           ` Mark Brown
2012-07-26 10:28 ` [PATCH 21/21] ARM: ux500: Rename MSP board file to something more meaningful Lee Jones
2012-07-26 11:28 ` [PATCH 00/21] Some fixes and DT enablement for ux500 audio Mark Brown
2012-07-26 11:36   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343298534-13611-13-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).