linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
Date: Fri, 27 Jul 2012 13:45:49 +0100	[thread overview]
Message-ID: <1343393162-11938-6-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1343393162-11938-1-git-send-email-lee.jones@linaro.org>

Register both parts of the MSP driver from Device Tree so that they
are probed when Device Tree is enabled. Also, as there is platform
data involved, we ensure that there is allocated memory to place the
configuration into and that the correct information is extracted from
the DT binary.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ux500/ux500_msp_dai.c |    6 ++++++
 sound/soc/ux500/ux500_msp_i2s.c |   33 ++++++++++++++++++++++++++++++---
 2 files changed, 36 insertions(+), 3 deletions(-)

diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c
index 772cb19..0f7dd49 100644
--- a/sound/soc/ux500/ux500_msp_dai.c
+++ b/sound/soc/ux500/ux500_msp_dai.c
@@ -833,10 +833,16 @@ static int __devexit ux500_msp_drv_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ux500_msp_i2c_match[] = {
+	{ .compatible = "stericsson,ux500-msp-i2s", },
+	{},
+};
+
 static struct platform_driver msp_i2s_driver = {
 	.driver = {
 		.name = "ux500-msp-i2s",
 		.owner = THIS_MODULE,
+		.of_match_table = ux500_msp_i2c_match,
 	},
 	.probe = ux500_msp_drv_probe,
 	.remove = ux500_msp_drv_remove,
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 72ad6e8..1ecdec0 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -18,6 +18,7 @@
 #include <linux/pinctrl/consumer.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/of.h>
 
 #include <mach/hardware.h>
 #include <mach/msp.h>
@@ -685,6 +686,16 @@ int ux500_msp_i2s_close(struct ux500_msp *msp, unsigned int dir)
 
 }
 
+void ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
+			struct ux500_msp *msp,
+			struct device_node *np)
+{
+	if (of_get_property(np, "stericsson,use-pinctrl", NULL))
+		msp->use_pinctrl = true;
+	else
+		msp->use_pinctrl = false;
+}
+
 int ux500_msp_i2s_init_msp(struct platform_device *pdev,
 			struct ux500_msp **msp_p,
 			struct msp_i2s_platform_data *platform_data)
@@ -692,17 +703,33 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev,
 	int ret = 0;
 	struct resource *res = NULL;
 	struct i2s_controller *i2s_cont;
+	struct device_node *np = pdev->dev.of_node;
 	struct ux500_msp *msp;
 	static int initialised = false;
 
-	dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__,
-		pdev->name, platform_data->id);
-
 	*msp_p = devm_kzalloc(&pdev->dev, sizeof(struct ux500_msp), GFP_KERNEL);
 	msp = *msp_p;
 	if (!msp)
 		return -ENOMEM;
 
+	if (np) {
+		if (!platform_data) {
+			platform_data = devm_kzalloc(&pdev->dev,
+				sizeof(struct msp_i2s_platform_data), GFP_KERNEL);
+			if (!platform_data)
+				ret = -ENOMEM;
+		}
+		ux500_msp_i2s_of_init_msp(pdev, msp, np);
+	} else
+		if (!platform_data)
+			ret = -EINVAL;
+
+	if (ret)
+		goto err_res;
+
+	dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__,
+		pdev->name, platform_data->id);
+
 	msp->id = platform_data->id;
 	msp->dev = &pdev->dev;
 	msp->use_pinctrl = platform_data->use_pinctrl;
-- 
1.7.9.5

  parent reply	other threads:[~2012-07-27 12:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 12:45 [PATCH 00/18] Configure ux500 Audio Drivers for Device Tree Lee Jones
2012-07-27 12:45 ` [PATCH 01/18] Documentation: Describe the ux500 realated audio related DT nodes Lee Jones
2012-07-29 20:31   ` Mark Brown
2012-07-30  7:38     ` Lee Jones
2012-07-30 13:48       ` Mark Brown
2012-07-30 14:32         ` Lee Jones
2012-07-30 15:07           ` Mark Brown
2012-07-27 12:45 ` [PATCH 02/18] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-07-27 12:45 ` [PATCH 03/18] ASoC: Ux500: Enable MOP500 driver for Device Tree Lee Jones
2012-07-27 12:45 ` [PATCH 04/18] ASoC: Ux500: Enable ux500 PCM " Lee Jones
2012-07-27 12:45 ` Lee Jones [this message]
2012-07-29 20:42   ` [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP " Mark Brown
2012-07-30  6:53     ` Lee Jones
2012-07-30 13:39       ` Mark Brown
2012-07-30 13:57         ` Lee Jones
2012-07-30 15:01           ` Mark Brown
2012-07-27 12:45 ` [PATCH 06/18] ASoC: codecs: Enable AB8500 CODEC " Lee Jones
2012-07-27 12:45 ` [PATCH 07/18] ARM: ux500: Clean-up MSP platform code Lee Jones
2012-07-27 12:45 ` [PATCH 08/18] ARM: ux500: Add AB8500 CODEC node to DB8500 Device Tree Lee Jones
2012-07-27 12:45 ` [PATCH 09/18] ARM: ux500: Fork MSP platform registration for step-by-step DT enablement Lee Jones
2012-07-27 12:45 ` [PATCH 10/18] ARM: ux500: Enable HIGHMEM on all mop500 platforms Lee Jones
2012-07-29 20:45   ` Mark Brown
2012-07-30  6:54     ` Lee Jones
2012-07-27 12:45 ` [PATCH 11/18] ARM: ux500: Pass MSP DMA platform data though AUXDATA Lee Jones
2012-07-27 12:45 ` [PATCH 12/18] ARM: ux500: Stop registering the MOP500 Audio driver from platform code Lee Jones
2012-07-27 12:45 ` [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree Lee Jones
2012-07-29 20:50   ` Mark Brown
2012-07-30  7:32     ` Lee Jones
2012-07-30 13:40       ` Mark Brown
2012-07-30 14:26         ` Lee Jones
2012-07-30 15:02           ` Mark Brown
2012-07-27 12:45 ` [PATCH 14/18] ARM: ux500: Stop registering the PCM driver from platform code Lee Jones
2012-07-27 12:45 ` [PATCH 15/18] ARM: ux500: Add MSP devices to DB8500 Device Tree Lee Jones
2012-07-27 12:46 ` [PATCH 16/18] ARM: ux500: Remove platform registration of MSP devices Lee Jones
2012-07-27 12:46 ` [PATCH 17/18] ARM: ux500: Add all encompassing Sound node to DB8500 Device Tree Lee Jones
2012-07-29 20:52   ` Mark Brown
2012-07-30  7:35     ` Lee Jones
2012-07-30 13:42       ` Mark Brown
2012-07-30 14:30         ` Lee Jones
2012-07-27 12:46 ` [PATCH 18/18] ARM: ux500: Rename MSP board file to something more meaningful Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343393162-11938-6-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).