From: ian.molton@codethink.co.uk (Ian Molton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] mv643xx.c: Remove magic numbers.
Date: Mon, 30 Jul 2012 16:15:55 +0100 [thread overview]
Message-ID: <1343661359-10150-3-git-send-email-ian.molton@codethink.co.uk> (raw)
In-Reply-To: <1343661359-10150-1-git-send-email-ian.molton@codethink.co.uk>
replace magic number with RX_CSUM_WITH_HEADER.
Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
---
drivers/net/ethernet/marvell/mv643xx_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index 4fbba57..92497eb 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -86,6 +86,7 @@ static char mv643xx_eth_driver_version[] = "1.4";
* port #0, 0x0800 for port #1, and 0x0c00 for port #2.
*/
#define PORT_CONFIG 0x0000
+#define RX_CSUM_WITH_HEADER 0x02000000
#define UNICAST_PROMISCUOUS_MODE 0x00000001
#define PORT_CONFIG_EXT 0x0004
#define MAC_ADDR_LOW 0x0014
@@ -1607,7 +1608,7 @@ mv643xx_eth_set_features(struct net_device *dev, netdev_features_t features)
struct mv643xx_eth_private *mp = netdev_priv(dev);
bool rx_csum = features & NETIF_F_RXCSUM;
- wrlp(mp, PORT_CONFIG, rx_csum ? 0x02000000 : 0x00000000);
+ wrlp(mp, PORT_CONFIG, rx_csum ? RX_CSUM_WITH_HEADER : 0x00000000);
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-07-30 15:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 15:15 [PATCH 0/6] mv643xx Ethernet DT support and CSB1724 board support Ian Molton
2012-07-30 15:15 ` [PATCH 1/6] Initial csb1724 board support (FDT) Ian Molton
2012-07-30 15:28 ` Andrew Lunn
2012-07-30 16:28 ` Ian Molton
2012-07-31 11:27 ` Arnd Bergmann
2012-07-30 15:15 ` Ian Molton [this message]
2012-07-30 15:15 ` [PATCH 3/6] mv643xx.c: Add basic device tree support Ian Molton
2012-07-30 15:39 ` Andrew Lunn
2012-07-30 16:49 ` Ian Molton
2012-07-30 16:19 ` Amar Nath
2012-07-30 16:32 ` Ian Molton
2012-07-31 15:12 ` Florian Fainelli
2012-07-31 7:14 ` Arnaud Patard (Rtp)
2012-07-31 8:19 ` Ian Molton
2012-07-31 8:27 ` Andrew Lunn
2012-07-31 8:45 ` Ian Molton
2012-07-31 8:58 ` Arnaud Patard (Rtp)
2012-07-31 9:14 ` Ian Molton
2012-07-31 14:30 ` Ben Dooks
2012-07-31 15:04 ` Arnaud Patard (Rtp)
2012-07-30 15:15 ` [PATCH 4/6] kirkwood: setup clock only in eth helpers Ian Molton
2012-07-30 16:12 ` Andrew Lunn
2012-07-30 16:52 ` Ian Molton
2012-07-30 19:10 ` Andrew Lunn
2012-07-30 16:46 ` Josh Coombs
2012-07-31 8:23 ` Ian Molton
2012-07-31 11:04 ` Ian Molton
2012-07-31 11:08 ` Andrew Lunn
2012-07-31 11:39 ` Ian Molton
2012-07-30 15:15 ` [PATCH 5/6] csb1724: Enable device tree based mv643xx ethernet support Ian Molton
2012-07-30 15:55 ` Andrew Lunn
2012-07-30 16:58 ` Ian Molton
2012-07-30 16:17 ` Andrew Lunn
2012-07-30 16:57 ` Ian Molton
2012-07-30 15:15 ` [PATCH 6/6] DT: Convert all kirkwood boards with mv643xx that use DT Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343661359-10150-3-git-send-email-ian.molton@codethink.co.uk \
--to=ian.molton@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).