Re: [PATCH v8 18/23] drm/mediatek: Add Padding to OVL adaptor

From: "Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>
To: "CK Hu (胡俊光)" <ck.hu@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "Yongqiang Niu (牛永强)" <yongqiang.niu@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
	"Moudy Ho (何宗原)" <Moudy.Ho@mediatek.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Nathan Lu (呂東霖)" <Nathan.Lu@mediatek.com>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"sean@poorly.run" <sean@poorly.run>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"fshao@chromium.org" <fshao@chromium.org>,
	"johnson.wang@mediatek.corp-partner.google.com"
	<johnson.wang@mediatek.corp-partner.google.com>
Subject: Re: [PATCH v8 18/23] drm/mediatek: Add Padding to OVL adaptor
Date: Tue, 17 Oct 2023 11:09:34 +0000	[thread overview]
Message-ID: <1343d1aff7beb2f85d5a45f300a9f14f11e85531.camel@mediatek.com> (raw)
In-Reply-To: <97dae7c0-0bcb-456f-b808-b794ba9e3c8a@collabora.com>

Hi Angelo,

On Tue, 2023-10-17 at 11:47 +0200, AngeloGioacchino Del Regno wrote:
> Il 16/10/23 12:40, Hsiao Chien Sung ha scritto:
> > Add MT8188 Padding to OVL adaptor to probe the driver.
> > 
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.
> > ---
> >   .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   | 26
> > +++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > index 354ba6186166..b80425360e76 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > @@ -29,6 +29,7 @@ enum mtk_ovl_adaptor_comp_type {
> >   	OVL_ADAPTOR_TYPE_ETHDR,
> >   	OVL_ADAPTOR_TYPE_MDP_RDMA,
> >   	OVL_ADAPTOR_TYPE_MERGE,
> > +	OVL_ADAPTOR_TYPE_PADDING,
> >   	OVL_ADAPTOR_TYPE_NUM,
> >   };
> >   
> > @@ -46,6 +47,14 @@ enum mtk_ovl_adaptor_comp_id {
> >   	OVL_ADAPTOR_MERGE1,
> >   	OVL_ADAPTOR_MERGE2,
> >   	OVL_ADAPTOR_MERGE3,
> > +	OVL_ADAPTOR_PADDING0,
> > +	OVL_ADAPTOR_PADDING1,
> > +	OVL_ADAPTOR_PADDING2,
> > +	OVL_ADAPTOR_PADDING3,
> > +	OVL_ADAPTOR_PADDING4,
> > +	OVL_ADAPTOR_PADDING5,
> > +	OVL_ADAPTOR_PADDING6,
> > +	OVL_ADAPTOR_PADDING7,
> >   	OVL_ADAPTOR_ID_MAX
> >   };
> >   
> > @@ -66,6 +75,7 @@ static const char * const
> > private_comp_stem[OVL_ADAPTOR_TYPE_NUM] = {
> >   	[OVL_ADAPTOR_TYPE_ETHDR]	= "ethdr",
> >   	[OVL_ADAPTOR_TYPE_MDP_RDMA]	= "vdo1-rdma",
> >   	[OVL_ADAPTOR_TYPE_MERGE]	= "merge",
> > +	[OVL_ADAPTOR_TYPE_PADDING]	= "padding",
> >   };
> >   
> >   static const struct mtk_ddp_comp_funcs _ethdr = {
> > @@ -80,6 +90,13 @@ static const struct mtk_ddp_comp_funcs _merge =
> > {
> >   	.clk_disable = mtk_merge_clk_disable,
> >   };
> >   
> > +static const struct mtk_ddp_comp_funcs _padding = {
> 
> Please, _padding -> padding or mtk_padding
> 
> 
> Thanks,
> Angelo

Got it. Will change in the next version.

Thanks,
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel