From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] cpufreq: OMAP: Handle missing frequency table on SMP systems
Date: Wed, 8 Aug 2012 16:24:13 +0530 [thread overview]
Message-ID: <1344423254-3475-2-git-send-email-rnayak@ti.com> (raw)
In-Reply-To: <1344423254-3475-1-git-send-email-rnayak@ti.com>
On OMAP4, if the first CPU fails to get a valid frequency table (this
could happen if the platform does not register any OPP table), the
subsequent CPU instances end up dealing with a NULL freq_table and
crash. Add a check for a NULL freq_table to help error the rest
of the CPU instances out.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Cc: <linux-pm@vger.kernel.org>
---
drivers/cpufreq/omap-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
index 17fa04d..0ee824c 100644
--- a/drivers/cpufreq/omap-cpufreq.c
+++ b/drivers/cpufreq/omap-cpufreq.c
@@ -221,7 +221,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
if (atomic_inc_return(&freq_table_users) == 1)
result = opp_init_cpufreq_table(mpu_dev, &freq_table);
- if (result) {
+ if (result || !freq_table) {
dev_err(mpu_dev, "%s: cpu%d: failed creating freq table[%d]\n",
__func__, policy->cpu, result);
goto fail_ck;
--
1.7.9.5
next prev parent reply other threads:[~2012-08-08 10:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 10:54 [PATCH 0/2] OMAP cpufreq fixes Rajendra Nayak
2012-08-08 10:54 ` Rajendra Nayak [this message]
2012-08-08 11:30 ` [PATCH 1/2] cpufreq: OMAP: Handle missing frequency table on SMP systems Shilimkar, Santosh
2012-08-08 17:28 ` Kevin Hilman
2012-08-09 5:27 ` Shilimkar, Santosh
2012-08-08 10:54 ` [PATCH 2/2] ARM: OMAP4: Register the OPP table only for 4430 device Rajendra Nayak
2012-08-08 17:18 ` Kevin Hilman
2012-08-09 7:23 ` Rajendra Nayak
2012-08-09 15:01 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344423254-3475-2-git-send-email-rnayak@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).