From: richard.genoud@gmail.com (Richard Genoud)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev
Date: Fri, 17 Aug 2012 16:35:21 +0200 [thread overview]
Message-ID: <1345214124-5478-6-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1345214124-5478-1-git-send-email-richard.genoud@gmail.com>
max_beb_per1024 shouldn't be negative, and a 0 value will be treated as
the default value.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/mtd/ubi/build.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 58fe53d..ec7311f 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -855,6 +855,16 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
struct ubi_device *ubi;
int i, err, ref = 0;
+ if (max_beb_per1024 < 0)
+ return -EINVAL;
+
+ /*
+ * A value of 0 is forced to the default value to keep the same
+ * behavior between ubiattach command and module parameter
+ */
+ if (!max_beb_per1024)
+ max_beb_per1024 = CONFIG_MTD_UBI_BEB_LIMIT;
+
/*
* Check if we already have the same MTD device attached.
*
--
1.7.2.5
next prev parent reply other threads:[~2012-08-17 14:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 14:35 [PATCH 0/8] UBI: add max_beb_per1024 parameter / ioctl Richard Genoud
2012-08-17 14:35 ` [PATCH 1/8] arm: sam9_l9260_defconfig: adjust UBI bad eraseblocks limit Richard Genoud
2012-08-19 19:21 ` Artem Bityutskiy
2012-08-19 19:29 ` Artem Bityutskiy
2012-08-20 7:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-17 14:35 ` [PATCH 2/8] UBI: separate bad_peb_limit in a function Richard Genoud
2012-08-19 7:20 ` Shmulik Ladkani
2012-08-19 19:19 ` Artem Bityutskiy
2012-08-17 14:35 ` [PATCH 3/8] UBI: introduce MTD_PARAM_MAX_COUNT Richard Genoud
2012-08-19 19:32 ` Artem Bityutskiy
2012-08-19 19:32 ` Artem Bityutskiy
2012-08-17 14:35 ` [PATCH 4/8] UBI: prepare for max_beb_per1024 module parameter addition Richard Genoud
2012-08-19 9:01 ` Shmulik Ladkani
2012-08-17 14:35 ` Richard Genoud [this message]
2012-08-19 9:08 ` [PATCH 5/8] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev Shmulik Ladkani
2012-08-20 6:31 ` Richard Genoud
2012-08-20 8:25 ` Artem Bityutskiy
2012-08-20 8:29 ` Artem Bityutskiy
2012-08-17 14:35 ` [PATCH 6/8] UBI: replace MTD_UBI_BEB_LIMIT with module parameter Richard Genoud
2012-08-19 9:26 ` Shmulik Ladkani
2012-08-20 7:38 ` Richard Genoud
2012-08-20 8:21 ` Richard Genoud
2012-08-17 14:35 ` [PATCH 7/8] UBI: add ioctl for max_beb_per1024 Richard Genoud
2012-08-17 14:35 ` [PATCH 8/8] UBI: drop CONFIG_MTD_UBI_BEB_LIMIT Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345214124-5478-6-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).