From: vinod.koul@linux.intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] spi: spi-davinci: convert to DMA engine API
Date: Wed, 22 Aug 2012 09:15:22 +0530 [thread overview]
Message-ID: <1345607122.1895.44.camel@vkoul-udesk3> (raw)
In-Reply-To: <1345574589-24757-4-git-send-email-mporter@ti.com>
On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote:
> Removes use of the DaVinci EDMA private DMA API and replaces
> it with use of the DMA engine API.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
> ---
> + struct dma_slave_config dma_rx_conf = {
> + .direction = DMA_DEV_TO_MEM,
> + .src_addr = (unsigned long)dspi->pbase + SPIBUF,
> + .src_addr_width = data_type,
> + .src_maxburst = 1,
what does 1 mean in this context? We define as number of units that
needs to be transfered, so are you sure that you want only one unit to
be dma'ed in a single burst. that seems like killing your dmac,
shouldn't you be using larger bursts for a better dma performance?
--
~Vinod
next prev parent reply other threads:[~2012-08-22 3:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 18:43 [PATCH v2 0/3] DaVinci DMA engine conversion Matt Porter
2012-08-21 18:43 ` [PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver Matt Porter
2012-08-22 3:39 ` Vinod Koul
2012-08-22 16:21 ` Matt Porter
2012-08-22 12:37 ` Hebbar, Gururaja
2012-08-22 17:10 ` Matt Porter
2012-08-21 18:43 ` [PATCH v2 2/3] mmc: davinci_mmc: convert to DMA engine API Matt Porter
2012-08-22 18:53 ` Koen Kooi
2012-09-17 7:52 ` Chris Ball
2012-08-21 18:43 ` [PATCH v2 3/3] spi: spi-davinci: " Matt Porter
2012-08-22 3:45 ` Vinod Koul [this message]
2012-08-22 16:04 ` Matt Porter
2012-08-23 3:59 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345607122.1895.44.camel@vkoul-udesk3 \
--to=vinod.koul@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox