* [PATCH] imx21ads : avoid overlapping static i/o mappings
@ 2012-08-26 21:35 Jaccon Bastiaansen
2012-08-28 6:47 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Jaccon Bastiaansen @ 2012-08-26 21:35 UTC (permalink / raw)
To: linux-arm-kernel
The static I/O mappings for the cs89x0 ethernet controller and the
secondary AHB port 1 (SAHB1) overlapped, causing a kernel crash
at startup. This is fixed by mapping the cs89x0 to 0xf6000000 (which
is free to use according to arch/arm/plat-mxc/include/mach/hardware.h).
Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
---
arch/arm/mach-imx/mach-mx21ads.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-imx/mach-mx21ads.c b/arch/arm/mach-imx/mach-mx21ads.c
index ed22e3f..712c90e 100644
--- a/arch/arm/mach-imx/mach-mx21ads.c
+++ b/arch/arm/mach-imx/mach-mx21ads.c
@@ -31,7 +31,7 @@
/*
* Memory-mapped I/O on MX21ADS base board
*/
-#define MX21ADS_MMIO_BASE_ADDR 0xf5000000
+#define MX21ADS_MMIO_BASE_ADDR 0xf6000000
#define MX21ADS_MMIO_SIZE 0xc00000
#define MX21ADS_REG_ADDR(offset) (void __force __iomem *) \
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] imx21ads : avoid overlapping static i/o mappings
2012-08-26 21:35 [PATCH] imx21ads : avoid overlapping static i/o mappings Jaccon Bastiaansen
@ 2012-08-28 6:47 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-08-28 6:47 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 26, 2012 at 11:35:38PM +0200, Jaccon Bastiaansen wrote:
> The static I/O mappings for the cs89x0 ethernet controller and the
> secondary AHB port 1 (SAHB1) overlapped, causing a kernel crash
> at startup. This is fixed by mapping the cs89x0 to 0xf6000000 (which
> is free to use according to arch/arm/plat-mxc/include/mach/hardware.h).
>
> Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
> ---
> arch/arm/mach-imx/mach-mx21ads.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mach-mx21ads.c b/arch/arm/mach-imx/mach-mx21ads.c
> index ed22e3f..712c90e 100644
> --- a/arch/arm/mach-imx/mach-mx21ads.c
> +++ b/arch/arm/mach-imx/mach-mx21ads.c
> @@ -31,7 +31,7 @@
> /*
> * Memory-mapped I/O on MX21ADS base board
> */
> -#define MX21ADS_MMIO_BASE_ADDR 0xf5000000
> +#define MX21ADS_MMIO_BASE_ADDR 0xf6000000
I would prefer to ioremap the region instead. This makes sure this
problem is solved once and for all.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-28 6:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-26 21:35 [PATCH] imx21ads : avoid overlapping static i/o mappings Jaccon Bastiaansen
2012-08-28 6:47 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).