linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: convert ARM RealView to common clk
Date: Thu, 30 Aug 2012 13:33:47 +0100	[thread overview]
Message-ID: <1346330027.2623.4.camel@hornet> (raw)
In-Reply-To: <1344270728-7550-1-git-send-email-linus.walleij@stericsson.com>

Hi Linus,

I'm working on moving the VE clocking into driver/clk on top of your
Realview change, and just spotted one minor issue...

On Mon, 2012-08-06 at 17:32 +0100, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> This converts the ARM RealView machine over to using the common
> clock. The approach is similar to the one used for the Integrator,
> and we're reusing the ICST wrapper code.
[...]
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 7f0b5ca..89b726d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -40,4 +40,11 @@ config COMMON_CLK_WM831X
>            Supports the clocking subsystem of the WM831x/2x series of
>           PMICs from Wolfson Microlectronics.
> 
> +config COMMON_CLK_VERSATILE
> +       tristate "Clock driver for ARM Reference designs"

It can't really be a "tristate", can it? To my mind there is no way of
making it a module, so a "bool" seems more appropriate?

> +       depends on ARCH_INTEGRATOR || ARCH_REALVIEW
> +       ---help---
> +          Supports clocking on ARM Reference designs Integrator/AP,
> +         Integrator/CP, RealView PB1176, EB, PB11MP and PBX.
> +
>  endmenu

Cheers!

Pawe?

  parent reply	other threads:[~2012-08-30 12:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 16:32 [PATCH] clk: convert ARM RealView to common clk Linus Walleij
2012-08-08 11:48 ` Pawel Moll
2012-08-08 11:52   ` Pawel Moll
2012-08-08 11:55     ` Linus Walleij
2012-08-08 13:06       ` Pawel Moll
2012-08-16 12:56 ` Linus Walleij
2012-08-22 12:09   ` Linus Walleij
2012-08-24 23:51     ` Mike Turquette
2012-08-30 12:33 ` Pawel Moll [this message]
2012-08-30 17:24   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346330027.2623.4.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).