From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c-omap: Fix incorrect adapter id when booting from a device tree
Date: Fri, 31 Aug 2012 09:52:54 +0200 [thread overview]
Message-ID: <1346399575-7285-2-git-send-email-florian.vaussard@epfl.ch> (raw)
In-Reply-To: <1346399575-7285-1-git-send-email-florian.vaussard@epfl.ch>
When booting from a device tree, the omap driver is using pdev->id,
which is incorrect. The proposed patch uses aliases, as done in
omap-serial.
Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
---
drivers/i2c/busses/i2c-omap.c | 19 +++++++++++++++----
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 5d19a49..9445d1f 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1064,9 +1064,6 @@ omap_i2c_probe(struct platform_device *pdev)
goto err_unuse_clocks;
}
- dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", pdev->id,
- dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
-
adap = &dev->adapter;
i2c_set_adapdata(adap, dev);
adap->owner = THIS_MODULE;
@@ -1076,8 +1073,22 @@ omap_i2c_probe(struct platform_device *pdev)
adap->dev.parent = &pdev->dev;
adap->dev.of_node = pdev->dev.of_node;
+ if (adap->dev.of_node)
+ adap->nr = of_alias_get_id(adap->dev.of_node, "i2c");
+ else
+ adap->nr = pdev->id;
+
+ if (adap->nr < 0) {
+ dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n",
+ adap->nr);
+ r = -ENODEV;
+ goto err_free_irq;
+ }
+
+ dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", adap->nr,
+ dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
+
/* i2c device drivers may be active on return from add_adapter() */
- adap->nr = pdev->id;
r = i2c_add_numbered_adapter(adap);
if (r) {
dev_err(dev->dev, "failure adding adapter\n");
--
1.7.5.4
next prev parent reply other threads:[~2012-08-31 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 7:52 [PATCH 0/2] dts for i2c-omap: fix incorrect adapter id Florian Vaussard
2012-08-31 7:52 ` Florian Vaussard [this message]
2012-08-31 9:14 ` [PATCH 1/2] i2c-omap: Fix incorrect adapter id when booting from a device tree Benoit Cousson
2012-08-31 9:53 ` Florian Vaussard
2012-08-31 7:52 ` [PATCH 2/2] arm/dts: Add i2c aliases for OMAP3 and OMAP4/AM33xx Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346399575-7285-2-git-send-email-florian.vaussard@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).