[PATCH] arm: mxs: Fix MMC WP pin being inverted

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Marek Vasut]

The MMC WP is active high on the m28evk, fix this.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
---
 arch/arm/boot/dts/imx28-m28evk.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-m28evk.dts b/arch/arm/boot/dts/imx28-m28evk.dts
index 845bb42..10868f1 100644
--- a/arch/arm/boot/dts/imx28-m28evk.dts
+++ b/arch/arm/boot/dts/imx28-m28evk.dts
@@ -63,7 +63,7 @@
 					     &mmc0_cd_cfg
 					     &mmc0_sck_cfg>;
 				bus-width = <8>;
-				wp-gpios = <&gpio3 10 1>;
+				wp-gpios = <&gpio3 10 0>;
 				vmmc-supply = <&reg_vddio_sd0>;
 				status = "okay";
 			};
-- 
1.7.10.4

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Shawn Guo]

Please resend with subject "arm: " changing to "ARM: ", or even better
the one below.

  ARM: dts: m28evk: ...

On Wed, Sep 05, 2012 at 04:11:22AM +0200, Marek Vasut wrote:
> The MMC WP is active high on the m28evk, fix this.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> ---
>  arch/arm/boot/dts/imx28-m28evk.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-m28evk.dts b/arch/arm/boot/dts/imx28-m28evk.dts
> index 845bb42..10868f1 100644
> --- a/arch/arm/boot/dts/imx28-m28evk.dts
> +++ b/arch/arm/boot/dts/imx28-m28evk.dts
> @@ -63,7 +63,7 @@
>  					     &mmc0_cd_cfg
>  					     &mmc0_sck_cfg>;
>  				bus-width = <8>;
> -				wp-gpios = <&gpio3 10 1>;
> +				wp-gpios = <&gpio3 10 0>;
>  				vmmc-supply = <&reg_vddio_sd0>;
>  				status = "okay";
>  			};
> -- 
> 1.7.10.4
> 

-- 
Regards,
Shawn

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Marek Vasut]

Dear Shawn Guo,

> Please resend with subject "arm: " changing to "ARM: ", or even better
> the one below.
> 
>   ARM: dts: m28evk: ...

I really don't like this game ...

> 
> On Wed, Sep 05, 2012 at 04:11:22AM +0200, Marek Vasut wrote:
> > The MMC WP is active high on the m28evk, fix this.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > 
> >  arch/arm/boot/dts/imx28-m28evk.dts |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx28-m28evk.dts
> > b/arch/arm/boot/dts/imx28-m28evk.dts index 845bb42..10868f1 100644
> > --- a/arch/arm/boot/dts/imx28-m28evk.dts
> > +++ b/arch/arm/boot/dts/imx28-m28evk.dts
> > @@ -63,7 +63,7 @@
> > 
> >  					     &mmc0_cd_cfg
> >  					     &mmc0_sck_cfg>;
> >  				
> >  				bus-width = <8>;
> > 
> > -				wp-gpios = <&gpio3 10 1>;
> > +				wp-gpios = <&gpio3 10 0>;
> > 
> >  				vmmc-supply = <&reg_vddio_sd0>;
> >  				status = "okay";
> >  			
> >  			};

Best regards,
Marek Vasut

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Shawn Guo]

On Wed, Sep 05, 2012 at 04:57:03AM +0200, Marek Vasut wrote:
> Dear Shawn Guo,
> 
> > Please resend with subject "arm: " changing to "ARM: ", or even better
> > the one below.
> > 
> >   ARM: dts: m28evk: ...
> 
> I really don't like this game ...
> 
You either stay out of the game or play it well.

-- 
Regards,
Shawn

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Marek Vasut]

Dear Shawn Guo,

> On Wed, Sep 05, 2012 at 04:57:03AM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> > 
> > > Please resend with subject "arm: " changing to "ARM: ", or even better
> > > the one below.
> > > 
> > >   ARM: dts: m28evk: ...
> > 
> > I really don't like this game ...
> 
> You either stay out of the game or play it well.

You know, as I already complained, well defined rules would be welcome.

All these tags seem to me just as a tool for maintainers to unnecesarily torture 
people. I'd be much happier if we had a tool or something that'd either check 
them or generate them -- that'd make my life much easier. I think I'm not alone 
here.

Maybe a checkpatch-alike tool? But we have no list of valid tags, so, there're 
no well-defined rules, only some unspoken agreement :-(

Best regards,
Marek Vasut

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Shawn Guo]

On Wed, Sep 05, 2012 at 05:55:30AM +0200, Marek Vasut wrote:
> You know, as I already complained, well defined rules would be welcome.
> 
> All these tags seem to me just as a tool for maintainers to unnecesarily torture 
> people. I'd be much happier if we had a tool or something that'd either check 
> them or generate them -- that'd make my life much easier. I think I'm not alone 
> here.
> 
> Maybe a checkpatch-alike tool? But we have no list of valid tags, so, there're 
> no well-defined rules, only some unspoken agreement :-(
> 
I'm pretty sure you know the rule, since I have been told you time and
time again.

It's not about rule but attitude, really.

-- 
Regards,
Shawn

[PATCH] arm: mxs: Fix MMC WP pin being inverted

[Marek Vasut]

Dear Shawn Guo,

> On Wed, Sep 05, 2012 at 05:55:30AM +0200, Marek Vasut wrote:
> > You know, as I already complained, well defined rules would be welcome.
> > 
> > All these tags seem to me just as a tool for maintainers to unnecesarily
> > torture people. I'd be much happier if we had a tool or something that'd
> > either check them or generate them -- that'd make my life much easier. I
> > think I'm not alone here.
> > 
> > Maybe a checkpatch-alike tool? But we have no list of valid tags, so,
> > there're no well-defined rules, only some unspoken agreement :-(
> 
> I'm pretty sure you know the rule, since I have been told you time and
> time again.

It takes practice ... still, I have a feeling some of the tags emerge at random.

> It's not about rule but attitude, really.

Hihihi, I think we can agree on that :-D

Best regards,
Marek Vasut