From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/25] macintosh/mediabay: add a const qualifier
Date: Wed, 05 Sep 2012 19:23:43 +1000 [thread overview]
Message-ID: <1346837023.2257.57.camel@pasglop> (raw)
In-Reply-To: <20120905080249.GI28643@pengutronix.de>
On Wed, 2012-09-05 at 10:02 +0200, Uwe Kleine-K?nig wrote:
> Hello,
>
> On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:
> > On Mon, 2012-07-23 at 11:13 +0200, Uwe Kleine-K?nig wrote:
> > > This prepares *of_device_id.data becoming const. Without this change
> > > the following warning would occur:
> > >
> > > drivers/macintosh/mediabay.c: In function 'media_bay_attach':
> > > drivers/macintosh/mediabay.c:589:11: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
> > >
> > > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > > ---
> >
> > Ack all of these assuming you test built (I didn't).
> "all" means the two mediabay patches? And yes, they are all built
> tested.
Yeah, anything powerpc you had in your series, but the two mediabay ones
are what I spotted when digging through stuff today :-)
> > Do you need me to
> > carry any of this via the powerpc tree ?
> The patch that adds the const to of_device_id depends[1] on this patch.
> And the other mediabay is only valid after that const is added. So the
> easiest is if the series is pulled in one go. Arnd intended to let Linus
> pull it for 3.6-rc1 but it was missed because of a communication
> problem. So I intend to get it in during the 3.7 merge window.
Ok, I'm happy for Arnd to carry all of these, I trust his
judgement/review for that stuff including for ppc specific bits.
Cheers,
Ben.
> Best regards
> Uwe
>
> [1] it's only a soft depend, because the result is "only" a warning, but
> still.
>
next prev parent reply other threads:[~2012-09-05 9:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 9:13 [PATCH v2 00/25] make *struct of_device_id.data const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 01/25] spi/imx: make spi_imx_data.devtype_data member point to const data Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 02/25] spi/spi-omap2-mcspi: add a const qualifier Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 03/25] serial/imx: make imx_port.devdata member point to const data Uwe Kleine-König
2012-07-23 15:31 ` Greg Kroah-Hartman
2012-07-23 9:13 ` [PATCH 04/25] serial/mpc52xx_uart: add a const qualifier Uwe Kleine-König
2012-07-23 15:31 ` Greg Kroah-Hartman
2012-07-23 9:13 ` [PATCH 05/25] ARM: cache-l2x0: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 06/25] misc/atmel_tc: make atmel_tc.tcb_config member point to const data Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 07/25] gpio/gpio-omap.c: add a const qualifier Uwe Kleine-König
2012-07-29 16:13 ` Linus Walleij
2012-07-30 8:18 ` Santosh Shilimkar
2012-07-23 9:13 ` [PATCH 08/25] gpio/mpc8xxx: " Uwe Kleine-König
2012-07-29 16:13 ` Linus Walleij
2012-07-23 9:13 ` [PATCH 09/25] i2c/i2c-omap: " Uwe Kleine-König
2012-07-23 17:27 ` Datta, Shubhrajyoti
2012-07-23 9:13 ` [PATCH 10/25] i2c/mpc: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 11/25] dmaengine: at_hdmac: add a few const qualifiers Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 12/25] mmc/omap_hsmmc: add a const qualifier Uwe Kleine-König
2012-07-23 15:41 ` S, Venkatraman
2012-07-23 9:13 ` [PATCH 13/25] macintosh/mediabay: " Uwe Kleine-König
2012-09-05 2:40 ` Benjamin Herrenschmidt
2012-09-05 8:02 ` Uwe Kleine-König
2012-09-05 9:23 ` Benjamin Herrenschmidt [this message]
2012-09-11 6:56 ` Uwe Kleine-König
2012-09-11 7:08 ` Benjamin Herrenschmidt
2012-07-23 9:13 ` [PATCH 14/25] powerpc/83xx: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 15/25] powerpc/fsl_msi: " Uwe Kleine-König
2012-10-15 16:14 ` Tabi Timur-B04825
2012-07-23 9:13 ` [PATCH 16/25] powerpc/celleb_pci: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 17/25] watchdog/mpc8xxx: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 18/25] can: mpc5xxx_can: make data in mpc5xxx_can_probe const Uwe Kleine-König
2012-07-23 9:17 ` Marc Kleine-Budde
2012-07-23 9:13 ` [PATCH 19/25] of: add const to struct *of_device_id.data Uwe Kleine-König
2012-07-23 15:32 ` Greg Kroah-Hartman
2012-07-23 9:13 ` [PATCH 20/25] gpio/gpio-omap: make platformdata used as *of_device_id.data const Uwe Kleine-König
2012-07-29 16:15 ` Linus Walleij
2012-07-29 21:27 ` Shilimkar, Santosh
2012-07-30 7:17 ` Uwe Kleine-König
2012-07-30 7:20 ` Shilimkar, Santosh
2012-07-23 9:13 ` [PATCH 21/25] powerpc/fsl_msi: drop unneeded cast to non-const pointer Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 22/25] mfd/da9052: make i2c_device_id array const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 23/25] i2c/mpc: make data used as *of_device_id.data const Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 24/25] macintosh/mediabay: " Uwe Kleine-König
2012-07-23 9:13 ` [PATCH 25/25] can: mpc5xxx_can: " Uwe Kleine-König
2012-07-23 9:20 ` Marc Kleine-Budde
2012-07-24 15:01 ` [PATCH v2 00/25] make *struct of_device_id.data const Arnd Bergmann
2012-08-05 8:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346837023.2257.57.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).