From: thomas.abraham@linaro.org (Thomas Abraham)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface
Date: Thu, 06 Sep 2012 14:53:00 +0530 [thread overview]
Message-ID: <1346923381-14144-2-git-send-email-thomas.abraham@linaro.org> (raw)
In-Reply-To: <1346923381-14144-1-git-send-email-thomas.abraham@linaro.org>
Add optional support for i2c bus pin configuration using pinctrl interface
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
---
drivers/i2c/busses/i2c-s3c2410.c | 19 ++++++++++++++++---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 5ae3b02..f4b2d6f 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -38,6 +38,7 @@
#include <linux/io.h>
#include <linux/of_i2c.h>
#include <linux/of_gpio.h>
+#include <linux/pinctrl/consumer.h>
#include <asm/irq.h>
@@ -83,6 +84,8 @@ struct s3c24xx_i2c {
struct s3c2410_platform_i2c *pdata;
int gpios[2];
+ struct pinctrl *pctrl;
+ struct pinctrl_state *pctrl_state;
#ifdef CONFIG_CPU_FREQ
struct notifier_block freq_transition;
#endif
@@ -859,11 +862,17 @@ static int s3c24xx_i2c_init(struct s3c24xx_i2c *i2c)
/* inititalise the gpio */
- if (pdata->cfg_gpio)
+ if (pdata->cfg_gpio) {
pdata->cfg_gpio(to_platform_device(i2c->dev));
- else
- if (s3c24xx_i2c_parse_dt_gpio(i2c))
+ } else if (!IS_ERR_OR_NULL(i2c->pctrl) &&
+ !IS_ERR_OR_NULL(i2c->pctrl_state)) {
+ if (pinctrl_select_state(i2c->pctrl, i2c->pctrl_state)) {
+ dev_err(i2c->dev, "failed to configure io-pins\n");
+ return -ENXIO;
+ }
+ } else if (s3c24xx_i2c_parse_dt_gpio(i2c)) {
return -EINVAL;
+ }
/* write slave address */
@@ -1013,6 +1022,10 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
i2c->adap.algo_data = i2c;
i2c->adap.dev.parent = &pdev->dev;
+ i2c->pctrl = devm_pinctrl_get(i2c->dev);
+ if (!IS_ERR_OR_NULL(i2c->pctrl))
+ i2c->pctrl_state = pinctrl_lookup_state(i2c->pctrl, "default");
+
/* initialise the i2c controller */
ret = s3c24xx_i2c_init(i2c);
--
1.6.6.rc2
next prev parent reply other threads:[~2012-09-06 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 9:22 [PATCH 0/2] i2c: s3c2410: allow pin pin configuration using pinctrl Thomas Abraham
2012-09-06 9:23 ` Thomas Abraham [this message]
2012-09-06 9:34 ` [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface Tomasz Figa
2012-09-06 11:06 ` Thomas Abraham
2012-09-06 12:28 ` Tomasz Figa
2012-09-10 19:55 ` Linus Walleij
2012-09-10 19:21 ` Stephen Warren
2012-09-17 7:28 ` Thomas Abraham
2012-09-10 20:02 ` Linus Walleij
2012-09-17 7:52 ` Thomas Abraham
2012-09-06 9:23 ` [PATCH 2/2] ARM: dts: exynos4: allow i2c0 bus to be configured " Thomas Abraham
2012-09-06 10:13 ` Tomasz Figa
2012-09-06 11:14 ` Thomas Abraham
2012-09-10 19:23 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346923381-14144-2-git-send-email-thomas.abraham@linaro.org \
--to=thomas.abraham@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).