From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF355C6FD19 for ; Sun, 12 Mar 2023 21:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MX28wpW6VYzH/pvjzMCCVslWSFef0wgn4tTuxPZss9k=; b=ZsWok2F/EM4WSQ Ftvyy469jQYTtM3TkCkfbn+EaYmJcLKjSuEWq1UXsw0R/ADf05CnBFncynXjg9cCMZggA3wmPAq5u UgRmHE1wNh7pCKlAlpseGYnZ5Pd7rRpz7nR7i2+D86u9Tqp15FCTTK1SO28P1o2zQTfShu9q5d/he 6zOMNXk940Zic0enfIMv6/9620cpAAUDTFzLaoEcDaqKAhdEQzQlWazGxN/GtuTfWLfXQCP5gYPAD z5hhd5s8NyrfKHC4I+ndw9sIehUHcgUxpgz1uQzl8hOIeOFwnzG3jiVV6bptcD1RaH5lWzztyugSb y+CAiA+LHl/refJSnZbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbSq0-003aVD-Bb; Sun, 12 Mar 2023 21:02:40 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbSpv-003aR0-Kf for linux-arm-kernel@lists.infradead.org; Sun, 12 Mar 2023 21:02:37 +0000 Received: by mail-ed1-x52b.google.com with SMTP id s11so41071088edy.8 for ; Sun, 12 Mar 2023 14:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678654946; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qj1cXXqLyWgdPfJI5vrHGJXiCzlKmBf4u+Esl1s34b8=; b=T1OZkXIBCs09tAfYSkatz+1Mz2Ikbdu8dhgkALbsDPtxy0ZsMa2o2phIJvAuCHG0tS KAxemf+GOfyP97Ws1Zjsp6elR476GQFXhXzfQyONzRsdEQ4KuB+NTMFUhCGLpGDE93iH l7heYL65QyTwYW36ZZl6ca17hUtwkCckPEIsmbg92gals1GvlTUrEoJfk8ZPkhLg+r4a EyKy4JBJesuzbGBHYJGYOH1LJSRwRfntFtwRL7k6BdF2pSnjsp/xpnWVGaQZgReVLf6y TPtUeQBm1M8H49k77eODeQap+iIWJNul9SynRQG9yFBiZdnCjdRPLTtQwHMgzbI2YLcB RUMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678654946; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qj1cXXqLyWgdPfJI5vrHGJXiCzlKmBf4u+Esl1s34b8=; b=K/eBxrnlzsYQ9IluFnC+U+oQx1Qgbo9ithRdIhC3QZFaQta5HfA9OkhPhPCoaIMQli KitTuCt+BMdivAORZG37MGFJuA1J0rHPElQedGFjwJCr2MAwOuiCmSADSBCB9Oc1Nvwl 8fUXc7VlPpzKJKi1SrCoWDf1QyzfvIvpxqnw0t/w9N+kPqJ4KTRkJBSITObH3npKkm1M w9cEFkF7KmlerwUQEQZLoFYQB4MMbw9pTM7IngyJpLi0cmyB6cz8Sq4UZzUci7iZgl+Z 6sISzG8L9M+TTYHU4imfGULxp1rIHacC1SQOYJpExBy0OXiYLgD+GIevAttFY6ooGNus TZjQ== X-Gm-Message-State: AO0yUKUHL8WfV45LaWiQe1Gw4OjaXTShCo5PjK7ZG8I266FsnaNtxSr7 lDJ0yuJ2UwQRSguHC71aX21+fDa7A6DauxPkBp4= X-Google-Smtp-Source: AK7set96PFCqqF1MKJuHdirnlZrt7ztdx50WnXYftY1biggqu8CPFxeJo84vWtfKtF9PWzj6YOCVBQ== X-Received: by 2002:a17:907:6289:b0:91d:9745:407e with SMTP id nd9-20020a170907628900b0091d9745407emr9747007ejc.18.1678654946126; Sun, 12 Mar 2023 14:02:26 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d9f6:3e61:beeb:295a? ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id sg42-20020a170907a42a00b009202ce3c8adsm2322785ejc.27.2023.03.12.14.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 14:02:25 -0700 (PDT) Message-ID: <1346ce4e-f1fd-1a77-f38e-cd87efc59082@linaro.org> Date: Sun, 12 Mar 2023 22:02:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison Content-Language: en-US To: Andreas Kemnade , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, marex@denx.de, max.krummenacher@toradex.com, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230312205236.2281466-1-andreas@kemnade.info> <20230312205236.2281466-3-andreas@kemnade.info> From: Krzysztof Kozlowski In-Reply-To: <20230312205236.2281466-3-andreas@kemnade.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230312_140235_722807_407589E9 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/03/2023 21:52, Andreas Kemnade wrote: > This adds a devicetree for the Kobo Aura 2 Ebook reader. It is based > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL > SoC. > Thank you for your patch. There is something to discuss/improve. > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wifi_reset>; > + post-power-on-delay-ms = <20>; > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names = "default","sleep"; > + pinctrl-0 = <&pinctrl_i2c1>; > + pinctrl-1 = <&pinctrl_i2c1_sleep>; > + status = "okay"; > + > + touchscreen@15 { > + reg = <0x15>; > + compatible = "elan,ektf2132"; compatible first, then reg. > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ts>; > + power-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH>; > + interrupts-extended = <&gpio5 6 IRQ_TYPE_EDGE_FALLING>; > + }; > + > + accelerometer@1d { > + reg = <0x1d>; > + compatible = "fsl,mma8652"; > + }; > +}; > + > +&i2c2 { > + pinctrl-names = "default","sleep"; > + pinctrl-0 = <&pinctrl_i2c2>; > + pinctrl-1 = <&pinctrl_i2c2_sleep>; > + clock-frequency = <100000>; > + status = "okay"; > +}; > + > +&i2c3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c3>; > + clock-frequency = <100000>; > + status = "okay"; > + > + ec: embedded-controller@43 { > + compatible = "netronix,ntxec"; > + reg = <0x43>; > + #pwm-cells = <2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ec>; > + interrupts-extended = <&gpio5 11 IRQ_TYPE_EDGE_FALLING>; > + system-power-controller; > + }; > +}; > + > +&snvs_rtc { > + /* > + * We are using the RTC in the PMIC, but this one is not disabled > + * in imx6sl.dtsi. > + */ > + status = "disabled"; > +}; > + > +&uart1 { > + /* J4 */ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + status = "okay"; > +}; > + > +&uart4 { > + /* J9 */ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart4>; > + status = "okay"; > +}; > + > +&usdhc2 { > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > + pinctrl-3 = <&pinctrl_usdhc2_sleep>; > + cd-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>; > + status = "okay"; > + > + /* removable uSD card */ > +}; > + > +&usdhc3 { > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > + pinctrl-3 = <&pinctrl_usdhc3_sleep>; > + vmmc-supply = <®_wifi>; > + mmc-pwrseq = <&wifi_pwrseq>; > + cap-power-off-card; > + non-removable; > + status = "okay"; > + > + /* CyberTan WC121 (BCM43362) SDIO WiFi */ > +}; > + > +&usdhc4 { > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > + pinctrl-0 = <&pinctrl_usdhc4>; > + pinctrl-1 = <&pinctrl_usdhc4_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc4_200mhz>; > + pinctrl-3 = <&pinctrl_usdhc4_sleep>; > + bus-width = <8>; > + no-1-8-v; > + non-removable; > + status = "okay"; > + > + /* internal eMMC */ > +}; > + > +&usbotg1 { > + pinctrl-names = "default"; > + disable-over-current; > + srp-disable; > + hnp-disable; > + adp-disable; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl_backlight_power: backlight-powergrp { > + fsl,pins = < > + MX6SL_PAD_EPDC_PWRCTRL3__GPIO2_IO10 0x10059 > + >; > + }; > + > + pinctrl_ec: ecgrp { > + fsl,pins = < > + MX6SL_PAD_SD1_DAT0__GPIO5_IO11 0x17000 > + >; > + }; > + > + pinctrl_gpio_keys: gpio-keysgrp { > + fsl,pins = < > + MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x110B0 > + MX6SL_PAD_SD1_DAT4__GPIO5_IO12 0x110B0 > + MX6SL_PAD_KEY_COL1__GPIO3_IO26 0x11030 > + >; > + }; > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX6SL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1 > + MX6SL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1 > + >; > + }; > + > + pinctrl_i2c1_sleep: i2c1grp-sleep { > + fsl,pins = < > + MX6SL_PAD_I2C1_SCL__I2C1_SCL 0x400108b1 > + MX6SL_PAD_I2C1_SDA__I2C1_SDA 0x400108b1 > + >; > + }; > + > + pinctrl_i2c2: i2c2grp { > + fsl,pins = < > + MX6SL_PAD_I2C2_SCL__I2C2_SCL 0x4001f8b1 > + MX6SL_PAD_I2C2_SDA__I2C2_SDA 0x4001f8b1 > + >; > + }; > + > + pinctrl_i2c2_sleep: i2c2grp-sleep { Shouldn't all groups end with 'grp' suffix? Are you sure this passes dtbs_check? ... > + > + pinctrl_usdhc2_100mhz: usdhc2grp-100mhz { Name looks wrong. Same in other places further. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel