linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on"
@ 2012-09-25  2:52 Fabio Estevam
  2012-09-25  2:52 ` [PATCH 2/2] ARM: dts: imx23-olinuxino: Use pinctrl for gpio-led Fabio Estevam
  2012-09-25  7:51 ` [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on" Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-09-25  2:52 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@freescale.com>

The initial state of the gpio led can be set directly in "gpios" node.

Hence, linux,default-trigger can be removed.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index 384d8b6..35489a1 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -94,8 +94,7 @@
 
 		user {
 			label = "green";
-			gpios = <&gpio2 1 0>;
-			linux,default-trigger = "default-on";
+			gpios = <&gpio2 1 1>;
 		};
 	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: imx23-olinuxino: Use pinctrl for gpio-led
  2012-09-25  2:52 [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on" Fabio Estevam
@ 2012-09-25  2:52 ` Fabio Estevam
  2012-09-25  7:51 ` [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on" Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-09-25  2:52 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@freescale.com>

Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led driver 
has pinctrl support, so setup the gpio led pin via pinctrl and avoid the 
following warning:

leds-gpio leds.5: pins are not configured from the driver

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index 35489a1..8bd56fc 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -40,6 +40,15 @@
 					reg = <0>;
 					fsl,pinmux-ids = <
 						0x2013 /* MX23_PAD_SSP1_DETECT__GPIO_2_1 */
+					>;
+					fsl,drive-strength = <0>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <0>;
+				};
+
+				led_pin_gpio0_17: led_gpio0_17 at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
 						0x0113 /* MX23_PAD_GPMI_ALE__GPIO_0_17 */
 					>;
 					fsl,drive-strength = <0>;
@@ -91,6 +100,8 @@
 
 	leds {
 		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&led_pin_gpio0_17>;
 
 		user {
 			label = "green";
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on"
  2012-09-25  2:52 [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on" Fabio Estevam
  2012-09-25  2:52 ` [PATCH 2/2] ARM: dts: imx23-olinuxino: Use pinctrl for gpio-led Fabio Estevam
@ 2012-09-25  7:51 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2012-09-25  7:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 24, 2012 at 11:52:19PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The initial state of the gpio led can be set directly in "gpios" node.
> 
> Hence, linux,default-trigger can be removed.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Queued both for 3.8, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-09-25  7:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25  2:52 [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on" Fabio Estevam
2012-09-25  2:52 ` [PATCH 2/2] ARM: dts: imx23-olinuxino: Use pinctrl for gpio-led Fabio Estevam
2012-09-25  7:51 ` [PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on" Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).