* [PATCH RESEND] gpio-lpc32xx: Fix value handling of gpio_direction_output()
@ 2012-09-25 7:53 Roland Stigge
2012-09-26 7:01 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Roland Stigge @ 2012-09-25 7:53 UTC (permalink / raw)
To: linux-arm-kernel
For GPIOs of gpio-lpc32xx, gpio_direction_output() ignores the value argument
(initial value of output). This patch fixes this by setting the level
accordingly.
Signed-off-by: Roland Stigge <stigge@antcom.de>
Acked-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
Applies to v3.6-rc7
drivers/gpio/gpio-lpc32xx.c | 5 +++++
1 file changed, 5 insertions(+)
--- linux-2.6.orig/drivers/gpio/gpio-lpc32xx.c
+++ linux-2.6/drivers/gpio/gpio-lpc32xx.c
@@ -308,6 +308,7 @@ static int lpc32xx_gpio_dir_output_p012(
{
struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
+ __set_gpio_level_p012(group, pin, value);
__set_gpio_dir_p012(group, pin, 0);
return 0;
@@ -318,6 +319,7 @@ static int lpc32xx_gpio_dir_output_p3(st
{
struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
+ __set_gpio_level_p3(group, pin, value);
__set_gpio_dir_p3(group, pin, 0);
return 0;
@@ -326,6 +328,9 @@ static int lpc32xx_gpio_dir_output_p3(st
static int lpc32xx_gpio_dir_out_always(struct gpio_chip *chip, unsigned pin,
int value)
{
+ struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
+
+ __set_gpo_level_p3(group, pin, value);
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH RESEND] gpio-lpc32xx: Fix value handling of gpio_direction_output()
2012-09-25 7:53 [PATCH RESEND] gpio-lpc32xx: Fix value handling of gpio_direction_output() Roland Stigge
@ 2012-09-26 7:01 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-09-26 7:01 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 25, 2012 at 9:53 AM, Roland Stigge <stigge@antcom.de> wrote:
> For GPIOs of gpio-lpc32xx, gpio_direction_output() ignores the value argument
> (initial value of output). This patch fixes this by setting the level
> accordingly.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
> Acked-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
>
> ---
> Applies to v3.6-rc7
I will attempt to funnel this to Torvalds today.
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-26 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 7:53 [PATCH RESEND] gpio-lpc32xx: Fix value handling of gpio_direction_output() Roland Stigge
2012-09-26 7:01 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).