From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks
Date: Fri, 28 Sep 2012 18:23:11 +0530 [thread overview]
Message-ID: <1348836795-4783-3-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1348836795-4783-1-git-send-email-kishon@ti.com>
Before accessing any register, runtime API's should be invoked to enable
the clocks. runtime API's are added here to prevent abort during register
access.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 34578de..6a0e17f 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -43,6 +43,7 @@
#include <linux/spinlock.h>
#include <linux/platform_device.h>
#include <linux/platform_data/dwc3-omap.h>
+#include <linux/pm_runtime.h>
#include <linux/dma-mapping.h>
#include <linux/ioport.h>
#include <linux/io.h>
@@ -281,6 +282,13 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
omap->irq = irq;
omap->base = base;
+ pm_runtime_enable(dev);
+ ret = pm_runtime_get_sync(dev);
+ if (ret < 0) {
+ dev_err(dev, "get_sync failed with err %d\n", ret);
+ goto err1;
+ }
+
reg = dwc3_omap_readl(omap->base, USBOTGSS_UTMI_OTG_STATUS);
utmi_mode = of_get_property(node, "utmi-mode", &size);
@@ -354,6 +362,8 @@ err1:
static int __devexit dwc3_omap_remove(struct platform_device *pdev)
{
device_for_each_child(&pdev->dev, NULL, dwc3_remove_core);
+ pm_runtime_put(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
return 0;
}
--
1.7.10.4
next prev parent reply other threads:[~2012-09-28 12:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:53 [PATCH 0/6] usb: dwc3-omap: add dt support Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev Kishon Vijay Abraham I
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-10-01 8:50 ` Felipe Balbi
2012-09-28 12:53 ` Kishon Vijay Abraham I [this message]
2012-09-28 12:58 ` [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53 ` [PATCH 3/6] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox Kishon Vijay Abraham I
2012-09-28 12:59 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53 ` [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core Kishon Vijay Abraham I
2012-09-28 13:02 ` Felipe Balbi
2012-09-28 13:32 ` ABRAHAM, KISHON VIJAY
2012-09-30 16:47 ` Sergei Shtylyov
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348836795-4783-3-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).