linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: usb: uhci-platform driver fails after patch changes during merge
Date: Thu, 04 Oct 2012 19:38:11 +1300	[thread overview]
Message-ID: <1349332691.7583.3.camel@gitbox> (raw)

Mike,

I see someone made changes to the uhci-platform.c driver I submitted
during v3.7 which results in it not working on mach-vt8500.

Could you clarify why the changes were made, and what the suggested
resolution would be to solve the problem that it introduced?

Lines indicated by ---> below were removed from the patch, which means
that on arch-vt8500 there is no dma_mask set, and its fails to
communicate with attached devices.

Regards

Tony P


static int __devinit uhci_hcd_platform_probe(struct platform_device
*pdev)
...
	if (usb_disabled())
		return -ENODEV;
--->
	/* Right now device-tree probed devices don't get dma_mask set.
	 * Since shared usb code relies on it, set it here for now.
	 * Once we have dma capability bindings this can go away.
	 */
	if (!pdev->dev.dma_mask)
		pdev->dev.dma_mask = &platform_uhci_dma_mask;
--->
	hcd = usb_create_hcd(&uhci_platform_hc_driver, &pdev->dev,
				pdev->name);
...

             reply	other threads:[~2012-10-04  6:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04  6:38 Tony Prisk [this message]
2012-10-04  6:48 ` usb: uhci-platform driver fails after patch changes during merge Tony Prisk
2012-10-04  6:55 ` Tony Prisk
2012-10-04 14:26   ` Greg KH
2012-10-04 17:42     ` Tony Prisk
2012-10-04 17:52       ` Greg KH
2012-10-04 19:01         ` linux at prisktech.co.nz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349332691.7583.3.camel@gitbox \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).