From: rahul.sharma@samsung.com (Rahul Sharma)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 03/14] drm: exynos: hdmi: fix interrupt handling
Date: Thu, 04 Oct 2012 21:12:41 +0530 [thread overview]
Message-ID: <1349365372-21417-4-git-send-email-rahul.sharma@samsung.com> (raw)
In-Reply-To: <1349365372-21417-1-git-send-email-rahul.sharma@samsung.com>
From: Tomasz Stanislawski <t.stanislaws@samsung.com>
This patch fixes 'unsigned < 0' check in probe. Moreover it
releases an interrupt at remove.
Signed-off-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index b3a802b..3902917 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -64,8 +64,8 @@ struct hdmi_context {
struct mutex hdmi_mutex;
void __iomem *regs;
- unsigned int external_irq;
- unsigned int internal_irq;
+ int external_irq;
+ int internal_irq;
struct i2c_client *ddc_port;
struct i2c_client *hdmiphy_port;
@@ -2424,6 +2424,7 @@ static int __devexit hdmi_remove(struct platform_device *pdev)
pm_runtime_disable(dev);
free_irq(hdata->internal_irq, hdata);
+ free_irq(hdata->external_irq, hdata);
hdmi_resources_cleanup(hdata);
--
1.7.0.4
next prev parent reply other threads:[~2012-10-04 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 15:42 [PATCH v1 00/14] drm: exynos: hdmi: add dt based support for exynos5 hdmi Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 01/14] media: s5p-hdmi: add HPD GPIO to platform data Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 02/14] drm: exynos: hdmi: support for platform variants Rahul Sharma
2012-10-04 15:42 ` Rahul Sharma [this message]
2012-10-04 15:42 ` [PATCH v1 04/14] drm: exynos: hdmi: use s5p-hdmi platform data Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 05/14] drm: exynos: hdmi: turn off HPD interrupt in HDMI chip Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 06/14] drm: exynos: remove drm hdmi platform data struct Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 07/14] drm: exynos: hdmi: add support for exynos5 ddc Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 08/14] drm: exynos: hdmi: add support for exynos5 hdmiphy Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 09/14] drm: exynos: hdmi: add support for platform variants for mixer Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 10/14] drm: exynos: hdmi: add support to disable video processor in mixer Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 11/14] drm: exynos: hdmi: add support for exynos5 mixer Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 12/14] drm: exynos: hdmi: replace is_v13 with version check in hdmi Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 13/14] drm: exynos: hdmi: add support for exynos5 hdmi Rahul Sharma
2012-10-04 15:42 ` [PATCH v1 14/14] drm: exynos: hdmi: remove drm common hdmi platform data struct Rahul Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349365372-21417-4-git-send-email-rahul.sharma@samsung.com \
--to=rahul.sharma@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox