linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm: vt8500: Convert irq.c for multiplatform integration
Date: Thu, 11 Oct 2012 06:54:33 +1300	[thread overview]
Message-ID: <1349891673.22215.2.camel@gitbox> (raw)
In-Reply-To: <1349856509-20480-1-git-send-email-linux@prisktech.co.nz>

I did have one bit I wasn't sure about:

On Wed, 2012-10-10 at 21:08 +1300, Tony Prisk wrote:
> This patch converts arch-vt8500/irq.c to MULTI_IRQ_HANDLER and
> SPARSE_IRQ. IRQ domain is changed from legacy to linear.
> 
> Also, remove legacy code in include/mach/entry-macro.S and
> include/mach/irq.h to prepare for multiplatform.
> 
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
>  ...
>  
> diff --git a/arch/arm/mach-vt8500/common.h b/arch/arm/mach-vt8500/common.h
> index 2b24196..6f2b843 100644
> --- a/arch/arm/mach-vt8500/common.h
> +++ b/arch/arm/mach-vt8500/common.h
> @@ -25,4 +25,7 @@ int __init vt8500_irq_init(struct device_node *node,
>  /* defined in drivers/clk/clk-vt8500.c */
>  void __init vtwm_clk_init(void __iomem *pmc_base);
>  
> +/* defined in irq.c */
> +asmlinkage void vt8500_handle_irq(struct pt_regs *regs);

Should asmlinkage be used here in the header or is it unnecessary?

> +
>  #endif


Regards
Tony P

  parent reply	other threads:[~2012-10-10 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10  8:08 [RFC PATCH] arm: vt8500: Convert irq.c for multiplatform integration Tony Prisk
2012-10-10  8:35 ` Arnd Bergmann
2012-10-10 17:51   ` Tony Prisk
2012-10-10 17:54 ` Tony Prisk [this message]
2012-10-10 18:39   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349891673.22215.2.camel@gitbox \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).