* [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework [not found] ` <1347899860-24358-2-git-send-email-m-karicheri2@ti.com> @ 2012-09-28 16:10 ` Karicheri, Muralidharan 2012-10-11 9:57 ` Artem Bityutskiy 2012-10-09 13:03 ` [PATCH " Sekhar Nori 1 sibling, 1 reply; 6+ messages in thread From: Karicheri, Muralidharan @ 2012-09-28 16:10 UTC (permalink / raw) To: linux-arm-kernel >> -----Original Message----- >> From: Karicheri, Muralidharan >> Sent: Monday, September 17, 2012 12:38 PM >> To: dwmw2 at infradead.org; artem.bityutskiy at linux.intel.com; hs at denx.de; >> mikedunn at newsguy.com; linux-mtd at lists.infradead.org; linux-kernel at vger.kernel.org; >> davinci-linux-open-source at linux.davincidsp.com; linux-arm-kernel at lists.infradead.org >> Cc: Karicheri, Muralidharan >> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework >> >> As a first step towards migrating davinci platforms to use common clock >> framework, replace all instances of clk_enable() with clk_prepare_enable() >> and clk_disable() with clk_disable_unprepare(). Until the platform is >> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just >> adds a might_sleep() call and would work without any issues. >> >> This will make it easy later to switch to common clk based implementation >> of clk driver from DaVinci specific driver. >> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> Reviewed-by: Mike Turquette <mturquette@linaro.org> >> >> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c >> index f386b3c..df1ab7d 100644 >> --- a/drivers/mtd/nand/davinci_nand.c >> +++ b/drivers/mtd/nand/davinci_nand.c >> @@ -724,7 +724,7 @@ static int __init nand_davinci_probe(struct platform_device >> *pdev) >> goto err_clk; >> } >> >> - ret = clk_enable(info->clk); >> + ret = clk_prepare_enable(info->clk); >> if (ret < 0) { >> dev_dbg(&pdev->dev, "unable to enable AEMIF clock, err %d\n", >> ret); >> @@ -835,7 +835,7 @@ syndrome_done: >> >> err_scan: >> err_timing: >> - clk_disable(info->clk); >> + clk_disable_unprepare(info->clk); >> >> err_clk_enable: >> clk_put(info->clk); >> @@ -872,7 +872,7 @@ static int __exit nand_davinci_remove(struct platform_device >> *pdev) >> >> nand_release(&info->mtd); >> >> - clk_disable(info->clk); >> + clk_disable_unprepare(info->clk); >> clk_put(info->clk); >> >> kfree(info); >> -- >> 1.7.9.5 Could you please review and apply this patch to mtd subsystem tree for linux-next? Murali Karicheri Software Design Engineer ^ permalink raw reply [flat|nested] 6+ messages in thread
* [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework 2012-09-28 16:10 ` [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework Karicheri, Muralidharan @ 2012-10-11 9:57 ` Artem Bityutskiy 2012-10-11 10:07 ` Sekhar Nori 0 siblings, 1 reply; 6+ messages in thread From: Artem Bityutskiy @ 2012-10-11 9:57 UTC (permalink / raw) To: linux-arm-kernel On Fri, 2012-09-28 at 16:10 +0000, Karicheri, Muralidharan wrote: > >> -----Original Message----- > >> From: Karicheri, Muralidharan > >> Sent: Monday, September 17, 2012 12:38 PM > >> To: dwmw2 at infradead.org; artem.bityutskiy at linux.intel.com; hs at denx.de; > >> mikedunn at newsguy.com; linux-mtd at lists.infradead.org; linux-kernel at vger.kernel.org; > >> davinci-linux-open-source at linux.davincidsp.com; linux-arm-kernel at lists.infradead.org > >> Cc: Karicheri, Muralidharan > >> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework I do not see this patch in my mailbox. Can you please re-send with all the acks? -- Best Regards, Artem Bityutskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121011/7d5ad1bf/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework 2012-10-11 9:57 ` Artem Bityutskiy @ 2012-10-11 10:07 ` Sekhar Nori 2012-10-11 10:09 ` Artem Bityutskiy 0 siblings, 1 reply; 6+ messages in thread From: Sekhar Nori @ 2012-10-11 10:07 UTC (permalink / raw) To: linux-arm-kernel Hi Artem, On 10/11/2012 3:27 PM, Artem Bityutskiy wrote: > On Fri, 2012-09-28 at 16:10 +0000, Karicheri, Muralidharan wrote: >>>> -----Original Message----- >>>> From: Karicheri, Muralidharan >>>> Sent: Monday, September 17, 2012 12:38 PM >>>> To: dwmw2 at infradead.org; artem.bityutskiy at linux.intel.com; hs at denx.de; >>>> mikedunn at newsguy.com; linux-mtd at lists.infradead.org; linux-kernel at vger.kernel.org; >>>> davinci-linux-open-source at linux.davincidsp.com; linux-arm-kernel at lists.infradead.org >>>> Cc: Karicheri, Muralidharan >>>> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework > > I do not see this patch in my mailbox. Can you please re-send with all > the acks? This patch is already applied to linux-next. Do you need it still? http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=ea73fe7f0d562154975a77fe77ae3da6ab4d3e77 Thanks, Sekhar ^ permalink raw reply [flat|nested] 6+ messages in thread
* [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework 2012-10-11 10:07 ` Sekhar Nori @ 2012-10-11 10:09 ` Artem Bityutskiy 0 siblings, 0 replies; 6+ messages in thread From: Artem Bityutskiy @ 2012-10-11 10:09 UTC (permalink / raw) To: linux-arm-kernel On Thu, 2012-10-11 at 15:37 +0530, Sekhar Nori wrote: > Hi Artem, > > On 10/11/2012 3:27 PM, Artem Bityutskiy wrote: > > On Fri, 2012-09-28 at 16:10 +0000, Karicheri, Muralidharan wrote: > >>>> -----Original Message----- > >>>> From: Karicheri, Muralidharan > >>>> Sent: Monday, September 17, 2012 12:38 PM > >>>> To: dwmw2 at infradead.org; artem.bityutskiy at linux.intel.com; hs at denx.de; > >>>> mikedunn at newsguy.com; linux-mtd at lists.infradead.org; linux-kernel at vger.kernel.org; > >>>> davinci-linux-open-source at linux.davincidsp.com; linux-arm-kernel at lists.infradead.org > >>>> Cc: Karicheri, Muralidharan > >>>> Subject: [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework > > > > I do not see this patch in my mailbox. Can you please re-send with all > > the acks? > > This patch is already applied to linux-next. Do you need it still? > > http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=ea73fe7f0d562154975a77fe77ae3da6ab4d3e77 Ah, right, no, I don't, thanks! -- Best Regards, Artem Bityutskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121011/684817ab/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework [not found] ` <1347899860-24358-2-git-send-email-m-karicheri2@ti.com> 2012-09-28 16:10 ` [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework Karicheri, Muralidharan @ 2012-10-09 13:03 ` Sekhar Nori 2012-10-09 13:09 ` Sekhar Nori 1 sibling, 1 reply; 6+ messages in thread From: Sekhar Nori @ 2012-10-09 13:03 UTC (permalink / raw) To: linux-arm-kernel On 9/17/2012 10:07 PM, Murali Karicheri wrote: > As a first step towards migrating davinci platforms to use common clock > framework, replace all instances of clk_enable() with clk_prepare_enable() > and clk_disable() with clk_disable_unprepare(). Until the platform is > switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just > adds a might_sleep() call and would work without any issues. > > This will make it easy later to switch to common clk based implementation > of clk driver from DaVinci specific driver. > > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> > Reviewed-by: Mike Turquette <mturquette@linaro.org> Tested this using NAND flash on DA850 EVM. Acked-by: Sekhar Nori <nsekhar@ti.com> Any chance this can make into the v3.7 kernel? Thanks, Sekhar ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework 2012-10-09 13:03 ` [PATCH " Sekhar Nori @ 2012-10-09 13:09 ` Sekhar Nori 0 siblings, 0 replies; 6+ messages in thread From: Sekhar Nori @ 2012-10-09 13:09 UTC (permalink / raw) To: linux-arm-kernel On 10/9/2012 6:33 PM, Sekhar Nori wrote: > On 9/17/2012 10:07 PM, Murali Karicheri wrote: >> As a first step towards migrating davinci platforms to use common clock >> framework, replace all instances of clk_enable() with clk_prepare_enable() >> and clk_disable() with clk_disable_unprepare(). Until the platform is >> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just >> adds a might_sleep() call and would work without any issues. >> >> This will make it easy later to switch to common clk based implementation >> of clk driver from DaVinci specific driver. >> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> Reviewed-by: Mike Turquette <mturquette@linaro.org> > > Tested this using NAND flash on DA850 EVM. > > Acked-by: Sekhar Nori <nsekhar@ti.com> > > Any chance this can make into the v3.7 kernel? Just noticed another thread where Artem replied saying this patch is pushed. Sorry about the noise. Thanks, Sekhar ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-11 10:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1347899860-24358-1-git-send-email-m-karicheri2@ti.com>
[not found] ` <1347899860-24358-2-git-send-email-m-karicheri2@ti.com>
2012-09-28 16:10 ` [REMINDER: PATCH 1/1] mtd:nand:clk: preparation for switch to common clock framework Karicheri, Muralidharan
2012-10-11 9:57 ` Artem Bityutskiy
2012-10-11 10:07 ` Sekhar Nori
2012-10-11 10:09 ` Artem Bityutskiy
2012-10-09 13:03 ` [PATCH " Sekhar Nori
2012-10-09 13:09 ` Sekhar Nori
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).