From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BF7C433DF for ; Fri, 9 Oct 2020 23:41:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D285422245 for ; Fri, 9 Oct 2020 23:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WqVKrMoE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hDmBTJvL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D285422245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1SOuU9IpuUva4T09iHMebcxW66+rJIh1C9ByeFTy2xQ=; b=WqVKrMoEVJDgsYSXTaluN7kv8 uS2amSZYA+uKn2XXrgHNvBxgxrAGfJi4hj9iCdpzsZ+77hgkuaTfpqWAr3IPO4L4b35tXhSOaCnTO /dYkJix91z35BZYs+6ZxbjYeY7L7DVBuP4cTapwFxAlAv648Kdu6zSYPekBbId4FNzMthyg60+Paq 9z+nuGMvHKZQXejm47krIdIGBQkDgUdJrn9R3yvZRaw7PwjeUJq/yKh78IesmZCTaM8GRMu9qU3yk yHCYR/hm2XI8nM7TMxozPLUJMLMKtRfHoSV3i9c8VaxLtkIBELOLXGJ/u+T1TDhbzndQFzWh/qIwQ 9JddEV3tg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kR1zk-0004iL-RS; Fri, 09 Oct 2020 23:40:16 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kR1zh-0004hj-MF for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 23:40:14 +0000 Received: by mail-pg1-x544.google.com with SMTP id o25so8525855pgm.0 for ; Fri, 09 Oct 2020 16:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MQ0KpWnDNeVxw8ddnKLR7x7PrOHy9mrx1gHHEVR4YTk=; b=hDmBTJvLU+MIdtrIERvGrZtc+8C0P9oZrj1hYTssasKwOlKfF6VIa9dbL0mgxWU9w9 1+b5srOqfK9+VBMHs+kNLk3kQP8fhH/xwuJohUlgZF4iKjas0F8Mdam3nDoIk5i8Wts7 6Ney0/ge19sTB785apk8kXZpnEHrUyXocc6qIXmhJN6ZHN6xPXAPq2AY2PcW5rg+H2tj d827grvw4cHpteJ9p0wKAaFYYvLIAtHTlETEK4Tc8JcH8FAyzhcWDRJwyCEY0p8VeuDj JOa+o+Dg5+/hq+bcq4JNCjgzVcPUfEBaLy53AZXyougFBlMb8p7V7hhFRDvg2hcVGyuO UWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MQ0KpWnDNeVxw8ddnKLR7x7PrOHy9mrx1gHHEVR4YTk=; b=QMq8z/RSH2eznaZOV/AtUPutkA+Lwja919VPSmqZWFkYe0E8r6m7V8qyrhWiLNuMgY 2PWk+vla8COYGT+7nzM7rVfb7fE6XMLnjhlHpVW5YoV212cZrFiX3tLusIcBW/ZTHCHS 0NU/Bd7VCDPySNMEOB/8Sc+CeYnL3+DSkMJqSx71uVfeQsolBn13OdZgtDWBsvdu3Oiq 1dTD69CsHPJPtyDiMrMXbGzTWssf9VJKF3tiWseJhOeloF9vseABxE5Oxp/Yrpwxfasy qYWyRdTGOU0Fh5O4xxnmE/jgNvjBYzpKwxw13lqAP5doLr4ZMm5FIDIhJZtq8XNaghCj HmGg== X-Gm-Message-State: AOAM530Yk86lSFmjDU6Z+6FbT5tBIcK3TpRuLk5So2O/dynV6JbXKxCr keY6/dtQBsNwOSDB9lqKv5Y= X-Google-Smtp-Source: ABdhPJwFQIBy/uYMt1NSfSfYgTEXiSJCzmSoTmkhClRQ3AbICj+NmlbuQ/4Npd8rPY1ODaGP3HOLnw== X-Received: by 2002:a17:90a:a394:: with SMTP id x20mr7043686pjp.213.1602286811513; Fri, 09 Oct 2020 16:40:11 -0700 (PDT) Received: from [10.230.29.112] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id jx17sm12684399pjb.10.2020.10.09.16.40.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2020 16:40:10 -0700 (PDT) Subject: Re: [PATCH v2 2/2] usb: Add driver to allow any GPIO to be used for 7211 USB signals To: Al Cooper , linux-kernel@vger.kernel.org References: <20201009190839.12612-1-alcooperx@gmail.com> <20201009190839.12612-3-alcooperx@gmail.com> From: Florian Fainelli Message-ID: <134cbb66-6d46-bef5-fa4c-eeae78ec1b53@gmail.com> Date: Fri, 9 Oct 2020 16:40:08 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201009190839.12612-3-alcooperx@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_194013_736432_50ECD9FA X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/9/2020 12:08 PM, Al Cooper wrote: > The Broadcom 7211 has new functionality that allows some USB low > speed side band signals, that go from the XHCI host controller to > pins on the chip, to be remapped to use any GPIO pin instead of the > limited set selectable by hardware. This can be done without changing > the standard driver for the host controller. There is currently > support for three USB signals, PWRON, VBUS_PRESENT and PWRFLT. This > driver will allow the remapping of any of these three signals based > on settings in the Device Tree node for the driver. The driver was > written so that it could handle additional signals added in the > future by just adding the correct properties to the DT node. > > Below is an example of a DT node that would remap all three > signals: > > usb_pinmap: usb-pinmap@22000d0 { > compatible = "brcm,usb-pinmap"; > reg = <0x22000d0 0x4>; > in-gpios = <&gpio 18 0>, <&gpio 19 0>; > brcm,in-functions = "VBUS", "PWRFLT"; > brcm,in-masks = <0x8000 0x40000 0x10000 0x80000>; > out-gpios = <&gpio 20 0>; > brcm,out-functions = "PWRON"; > brcm,out-masks = <0x20000 0x800000 0x400000 0x200000>; > interrupts = <0x0 0xb2 0x4>; > }; > > Signed-off-by: Al Cooper > --- [snip] > +config BRCM_USB_PINMAP > + tristate "Broadcom pinmap driver support" > + depends on (ARCH_BRCMSTB && PHY_BRCM_USB) || COMPILE_TEST > + default y if (ARCH_BRCMSTB && PHY_BRCM_USB) default ARCH_BRCMSTB && PHY_BRCM_USB should work as well. > +static int __init brcmstb_usb_pinmap_init(void) > +{ > + return platform_driver_probe(&brcmstb_usb_pinmap_driver, > + brcmstb_usb_pinmap_probe); > +} > + > +module_init(brcmstb_usb_pinmap_init); You would need MODULE_AUTHOR(), LICENSE and DESCRIPTION() in case you make this modular. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel