From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03914C433E0 for ; Fri, 12 Mar 2021 18:37:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97A9664F5D for ; Fri, 12 Mar 2021 18:37:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97A9664F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=15hSLriz1DfAloJXqlKJcVz3KjZXXvLobDs2dTtYV0A=; b=aoK4bIY7hdzPt4GYL8f+QzlYC xLjGKp7282R08ZmszLJlwF4zQwp0StXPCFa/yUQQUs1Vh5s2mjMot/DvTdZ3Gg17mz6GPvslEqnL1 7bRLg5wxycLfm9sEijeBOlngK4ov2E3h+yIv2GnF0yERibJ7Z81BZo46dt8z/lqOLhHrKb6vySCc7 rWF2bZfmcekvIZ3xXi7Ag4Q4JxygIGIX29dmJ7Fun7U62vKCOfo0hSgCREyD2A3llaP56tjDh8NcL /KN+YFxThyCRBRDIjC+V8FCpJqGN09L46E/nOkX+RX99011maK6ijZ8g+YeXBJpH5+Ww5h5cSB+mY bUkTO5Zvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKmdZ-00CDLd-V3; Fri, 12 Mar 2021 18:35:50 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKmdW-00CDL6-6H for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 18:35:48 +0000 Received: by mail-pf1-x433.google.com with SMTP id 18so2446511pfo.6 for ; Fri, 12 Mar 2021 10:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=edAAh8F5zzqoy3v4SwV/G5d3/7qdwdw3lH+6LgmNvvU=; b=U34KQ5YnKGn0zaSU1tpcVT9OsTo4BjjeQIZWQBtpwnJdUnvVbmJyjw5dgG9xmgf93B ZbJlINt5l0G2r1298M0241k7Za6h9sE2dRZxB6KTAwu3w1D8AyddHjLcBmsYp/EiepS2 T8MSPWEeDP5SCkwIFvEujrSr2PwhHPWGKtI1pIbwBcN7eklNvbIyYmeDGNRcdDQThO9V NEo+7faY1djzA3T9+X8qUOhR+6nEbLm/jc0OhEQugPnanYGFQMicws4v57p9Yzs0elIH rl8xP2ou8XM8dTtlmV6yfoZ+R2arMKSIza8JxPyg0Zfj5UtC25/1YRfrNevsb1rRlvi2 Z7og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=edAAh8F5zzqoy3v4SwV/G5d3/7qdwdw3lH+6LgmNvvU=; b=BZ/OvwutYR4tVbp/bKf7M1YIh4f5+vkbTGUJO4TDEloiCuLyOlgElJnAxOT9NcJfBU 4VeSY/Y2RJNW3beDIdRHivh36pGmcUpOiCkD+OXYDImdKoHFykNxddEAkP0on05/RtHV PsXwnR++NUhUnth8zRhul1T0+CZuRIURTsu3f9wxh/Qa+q3Xki09j+mP49lokdIDxToD fn/2XFA9uVrqcRfY45pGVY9vZiO9o4Ozz84hhhON3YIk9wJtGlVOcP7emGqRCO0NhME7 ri/S6XeDyuSJH6ePPMYk9/QYQRAvaGKPU1+Y2Ub9Dn8XvIpMQzOfrpYkM94BzGen9a5j 6n8Q== X-Gm-Message-State: AOAM531ApzzzTHhiegLwSQrkr8UxbFwdqqct8pA35dweyAwq/3lGX9RF LgUhJU9TvMw/zdxziPrs+Rw= X-Google-Smtp-Source: ABdhPJyl3PQB/5si0USgGvWCMkWEk3uE9jUnOj0DpOLkNTyf1G7+/NbXrOofo6Iso0eKXpi1WWaGSg== X-Received: by 2002:a65:6a0c:: with SMTP id m12mr12790546pgu.161.1615574144672; Fri, 12 Mar 2021 10:35:44 -0800 (PST) Received: from [10.67.49.104] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id p17sm2888834pjv.49.2021.03.12.10.35.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Mar 2021 10:35:44 -0800 (PST) Subject: Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support To: Qais Yousef , Alexander Sverdlin Cc: Steven Rostedt , Ingo Molnar , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ard Biesheuvel References: <20210127110944.41813-1-alexander.sverdlin@nokia.com> <20210127110944.41813-3-alexander.sverdlin@nokia.com> <20210307172650.uztx3sk5abybbp3f@e107158-lin.cambridge.arm.com> <0c122390-6e76-f773-86e9-8c085f4384f2@nokia.com> <20210309174201.n53za7mw33dqyleh@e107158-lin.cambridge.arm.com> <3eecf51d-b189-9e8b-f19d-a49d0764aae5@nokia.com> <05608bc8-f44d-5f91-15ab-af00c59b53e6@gmail.com> <20210312172401.36awjh4hmj4cs6ot@e107158-lin.cambridge.arm.com> From: Florian Fainelli Message-ID: <134e1a2c-daac-7b00-c170-bcca434d08df@gmail.com> Date: Fri, 12 Mar 2021 10:35:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210312172401.36awjh4hmj4cs6ot@e107158-lin.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_183546_279992_AF507B8C X-CRM114-Status: GOOD ( 23.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/12/21 9:24 AM, Qais Yousef wrote: > Hi Alexander > > On 03/10/21 18:17, Alexander Sverdlin wrote: >> Hi! >> >> On 10/03/2021 17:14, Florian Fainelli wrote: >>>>>>> I tried on 5.12-rc2 and 5.11 but couldn't reproduce the problem using your >>>>> I still can't reproduce on 5.12-rc2. >>>>> >>>>> I do have CONFIG_ARM_MODULE_PLTS=y. Do you need to do something else after >>>>> loading the module? I tried starting ftrace, but maybe there's a particular >>>>> combination required? >>>> You need to load a BIG module, so big that it has no place in the modules area >>>> any more and goes to vmalloc area. >>> You absolutely need a very big module maybe more than one. When I tested >>> this, I could use the two proprietary modules (*sigh*) that I needed to >>> exercise against and loading one but not the other was not enough to >>> make the second module loading spill into vmalloc space. >> >> Here is what I use instead of these real world "proprietary" modules (which of course >> were the real trigger for the patch): >> >> https://www.spinics.net/lists/arm-kernel/msg878599.html > > I am testing with your module. I can't reproduce the problem you describe with > it as I stated. > > I will try to spend more time on it on the weekend. Alexander, do you load one or multiple instances of that fat module? The test module does a 6 * 1024 * 1024 / 2 = 3 million repetitions of the "nop" instruction which should be 32-bits wide in ARM mode and 16-bits wide in Thumb mode, right? In ARM mode we have a 14MB module space, so 3 * 1024 * 1024 * 4 = 12MB, which should still fit within if you have no module loaded, however a second instance of the module should make us spill into vmalloc space. In Thumb mode, we have a 6MB module space, so 3 * 1024 * 1024 * 2 = 6MB so we may spill, but maybe not. I was not able to reproduce the warning with just one module, but with two (cannot have the same name BTW), it kicked in. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel