linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH for 3.7] dtb: fix interrupt assignment for ehci/uhci on wm8505
@ 2012-10-13  4:18 Tony Prisk
  2012-10-13  5:00 ` Tony Prisk
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Prisk @ 2012-10-13  4:18 UTC (permalink / raw)
  To: linux-arm-kernel

EHCI and UHCI devices in wm8505.dtsi should use IRQ 0 & 1
respectively - not 43 as used on newer models.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
---
 arch/arm/boot/dts/wm8505.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
index b459691..330f833 100644
--- a/arch/arm/boot/dts/wm8505.dtsi
+++ b/arch/arm/boot/dts/wm8505.dtsi
@@ -71,13 +71,13 @@
 		ehci at d8007100 {
 			compatible = "via,vt8500-ehci";
 			reg = <0xd8007100 0x200>;
-			interrupts = <43>;
+			interrupts = <1>;
 		};
 
 		uhci at d8007300 {
 			compatible = "platform-uhci";
 			reg = <0xd8007300 0x200>;
-			interrupts = <43>;
+			interrupts = <0>;
 		};
 
 		fb at d8050800 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH for 3.7] dtb: fix interrupt assignment for ehci/uhci on wm8505
  2012-10-13  4:18 [PATCH for 3.7] dtb: fix interrupt assignment for ehci/uhci on wm8505 Tony Prisk
@ 2012-10-13  5:00 ` Tony Prisk
  2012-10-16  4:14   ` Olof Johansson
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Prisk @ 2012-10-13  5:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, 2012-10-13 at 17:18 +1300, Tony Prisk wrote:
> EHCI and UHCI devices in wm8505.dtsi should use IRQ 0 & 1
> respectively - not 43 as used on newer models.

Oops - should have been IRQ 1 & 0 - fixed locally.
> 
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
>  arch/arm/boot/dts/wm8505.dtsi |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
> index b459691..330f833 100644
> --- a/arch/arm/boot/dts/wm8505.dtsi
> +++ b/arch/arm/boot/dts/wm8505.dtsi
> @@ -71,13 +71,13 @@
>  		ehci at d8007100 {
>  			compatible = "via,vt8500-ehci";
>  			reg = <0xd8007100 0x200>;
> -			interrupts = <43>;
> +			interrupts = <1>;
>  		};
>  
>  		uhci at d8007300 {
>  			compatible = "platform-uhci";
>  			reg = <0xd8007300 0x200>;
> -			interrupts = <43>;
> +			interrupts = <0>;
>  		};
>  
>  		fb at d8050800 {

I assume the usb subsystem doesn't fault when IRQ's aren't recieved as
this did give any error messages, it just made the USB extremely slow -
like it was timing-out between requests.

Regards
Tony P

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH for 3.7] dtb: fix interrupt assignment for ehci/uhci on wm8505
  2012-10-13  5:00 ` Tony Prisk
@ 2012-10-16  4:14   ` Olof Johansson
  0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2012-10-16  4:14 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Oct 13, 2012 at 06:00:30PM +1300, Tony Prisk wrote:
> On Sat, 2012-10-13 at 17:18 +1300, Tony Prisk wrote:
> > EHCI and UHCI devices in wm8505.dtsi should use IRQ 0 & 1
> > respectively - not 43 as used on newer models.
> 
> Oops - should have been IRQ 1 & 0 - fixed locally.
> > 
> > Signed-off-by: Tony Prisk <linux@prisktech.co.nz>

Applied to fixes with the commit message edited as above.


Thanks,

-Olof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-16  4:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-13  4:18 [PATCH for 3.7] dtb: fix interrupt assignment for ehci/uhci on wm8505 Tony Prisk
2012-10-13  5:00 ` Tony Prisk
2012-10-16  4:14   ` Olof Johansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).