From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: vt8500: Convert arch-vt8500 to multiplatform
Date: Sat, 13 Oct 2012 17:58:11 +1300 [thread overview]
Message-ID: <1350104291.6448.1.camel@gitbox> (raw)
In-Reply-To: <201210120752.25450.arnd@arndb.de>
On Fri, 2012-10-12 at 07:52 +0000, Arnd Bergmann wrote:
> On Thursday 11 October 2012, linux at prisktech.co.nz wrote:
> > To clarify what you said (because I'm not sure I got it the first time)...
> >
> > Keep ARCH_VT8500 as the single-platform Kconfig option.
> > Add a new ARCH_VT8500_MULTI (for example) as the multiplatform Kconfig option.
> >
> > Have ARCH_VT8500_MULTI select ARCH_VT8500??
> >
> > The last bit confuses me (and seems a little backwards, although I suspect it
> > would work since none of the options would cause conflicts). Without ARCH_VT8500
> > selected, we have no driver options without changing all the Kconfig's.
> >
> > If this is correct, we are basically using _MULTI to add more options on top of
> > _VT8500.
>
> No, this would not work, because Kconfig does not let you 'select' a symbol
> that is inside of a 'choice' list.
>
> The other way round works though: rename the existing ARCH_VT8500 to
> ARCH_VT8500_SINGLE, and add a new symbol in arch/arm/mach-vt8500/Kconfig
> like
>
> config VT8500
> bool "Via/Wondermedia VT8500 / WM8505 / WM8650" if ARCH_MULTI_V5
> default ARCH_VT8500_SINGLE
>
> This one becomes visible when ARCH_MULTI_V5 is set but invisible in a
> other cases. The 'default ARCH_VT8500_SINGLE' statement means it is
> automatically enabled (but still invisible) if ARCH_VT8500_SINGLE
> is selected in the 'choice', and it's invisible and disabled in all
> other cases.
>
> Arnd
I will leave the patch as is unless someone specifically needs
earlyprintk in the mean time - at the moment, I don't need it again
until we look to add WM8750 and WM8850 (Framebuffer problems at the
moment).
There is plenty of other stuff to do for the existing platforms, and
earlyprintk will be re-enabled once the support is readded.
Tony P
prev parent reply other threads:[~2012-10-13 4:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 7:17 [RFC PATCH] ARM: vt8500: Convert arch-vt8500 to multiplatform Tony Prisk
2012-10-11 7:25 ` Alexey Charkov
2012-10-11 7:47 ` Arnd Bergmann
2012-10-11 18:17 ` Tony Prisk
2012-10-11 20:29 ` Arnd Bergmann
2012-10-11 22:33 ` linux at prisktech.co.nz
2012-10-12 7:52 ` Arnd Bergmann
2012-10-13 4:58 ` Tony Prisk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350104291.6448.1.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).