From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] pinctrl: remove mutex lock in groups show
Date: Thu, 18 Oct 2012 17:07:01 +0800 [thread overview]
Message-ID: <1350551224-12857-7-git-send-email-haojian.zhuang@gmail.com> (raw)
In-Reply-To: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com>
Mutex is locked duplicatly by pinconf_groups_show() and
pin_config_group_get(). It results dead lock. So avoid to lock mutex
in pinconf_groups_show().
Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
---
drivers/pinctrl/pinconf.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 43f474c..baee2cc 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -537,8 +537,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
seq_puts(s, "Pin config settings per pin group\n");
seq_puts(s, "Format: group (name): configs\n");
- mutex_lock(&pinctrl_mutex);
-
while (selector < ngroups) {
const char *gname = pctlops->get_group_name(pctldev, selector);
@@ -549,8 +547,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
selector++;
}
- mutex_unlock(&pinctrl_mutex);
-
return 0;
}
--
1.7.0.4
next prev parent reply other threads:[~2012-10-18 9:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:06 [PATCH 01/10] pinctrl: use postcore_initcall Haojian Zhuang
2012-10-18 9:06 ` [PATCH 02/10] ARM: mmp: select pinctrl driver Haojian Zhuang
2012-10-18 9:06 ` [PATCH 03/10] tty: pxa: configure pin Haojian Zhuang
2012-10-18 18:21 ` Linus Walleij
2012-10-18 22:20 ` Stephen Warren
2012-10-22 8:45 ` Linus Walleij
2012-10-22 20:26 ` Stephen Warren
2012-10-23 9:26 ` Linus Walleij
2012-10-23 9:37 ` Mark Brown
2012-10-23 9:59 ` Linus Walleij
2012-10-23 11:58 ` Mark Brown
2012-10-24 5:43 ` Linus Walleij
2012-10-18 9:06 ` [PATCH 04/10] i2c: pxa: configure pins Haojian Zhuang
2012-10-18 18:22 ` Linus Walleij
2012-10-18 9:06 ` [PATCH 05/10] i2c: pxa: use devm_kzalloc Haojian Zhuang
2012-10-18 22:27 ` Stephen Warren
2012-10-19 1:16 ` Haojian Zhuang
2012-10-18 9:07 ` [PATCH 06/10] pinctrl: single: support gpio request and free Haojian Zhuang
2012-10-19 22:37 ` Tony Lindgren
2012-10-18 9:07 ` Haojian Zhuang [this message]
2012-10-18 18:29 ` [PATCH 07/10] pinctrl: remove mutex lock in groups show Linus Walleij
2012-10-18 22:26 ` Stephen Warren
2012-10-22 8:53 ` Linus Walleij
2012-10-18 9:07 ` [PATCH 08/10] pinctrl: single: support pinconf generic Haojian Zhuang
2012-10-18 18:30 ` Linus Walleij
2012-10-18 22:29 ` Tony Lindgren
2012-10-19 2:23 ` Haojian Zhuang
2012-10-19 2:40 ` Tony Lindgren
2012-10-19 18:44 ` Tony Lindgren
2012-10-19 18:53 ` Tony Lindgren
2012-10-19 19:13 ` Tony Lindgren
2012-10-22 10:09 ` Haojian Zhuang
2012-10-22 17:09 ` Tony Lindgren
2012-10-25 23:43 ` Tony Lindgren
2012-10-26 1:47 ` Haojian Zhuang
2012-10-26 17:29 ` Tony Lindgren
2012-10-31 22:37 ` Haojian Zhuang
2012-10-18 9:07 ` [PATCH 09/10] ARM: dts: support pinctrl single in pxa910 Haojian Zhuang
2012-10-18 9:07 ` [PATCH 10/10] document: devicetree: bind pinconf in pinctrl single Haojian Zhuang
2012-10-19 22:40 ` Tony Lindgren
2012-10-18 18:20 ` [PATCH 01/10] pinctrl: use postcore_initcall Linus Walleij
2012-10-18 22:18 ` Stephen Warren
2012-10-18 22:28 ` Tony Lindgren
2012-10-19 2:16 ` Haojian Zhuang
2012-10-19 2:38 ` Tony Lindgren
2012-10-19 2:53 ` Haojian Zhuang
2012-10-19 17:41 ` Tony Lindgren
2012-10-19 2:24 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350551224-12857-7-git-send-email-haojian.zhuang@gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).