From: mporter@ti.com (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3 03/16] ARM: edma: remove unused transfer controller handlers
Date: Thu, 18 Oct 2012 09:26:42 -0400 [thread overview]
Message-ID: <1350566815-409-4-git-send-email-mporter@ti.com> (raw)
In-Reply-To: <1350566815-409-1-git-send-email-mporter@ti.com>
Fix build on OMAP, the irqs are undefined on AM33xx.
These error interrupt handlers were hardcoded as disabled
so since they are unused code, simply remove them.
Signed-off-by: Matt Porter <mporter@ti.com>
---
arch/arm/common/edma.c | 37 -------------------------------------
1 file changed, 37 deletions(-)
diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index 4411087..a3d189d 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
@@ -494,26 +494,6 @@ static irqreturn_t dma_ccerr_handler(int irq, void *data)
return IRQ_HANDLED;
}
-/******************************************************************************
- *
- * Transfer controller error interrupt handlers
- *
- *****************************************************************************/
-
-#define tc_errs_handled false /* disabled as long as they're NOPs */
-
-static irqreturn_t dma_tc0err_handler(int irq, void *data)
-{
- dev_dbg(data, "dma_tc0err_handler\n");
- return IRQ_HANDLED;
-}
-
-static irqreturn_t dma_tc1err_handler(int irq, void *data)
-{
- dev_dbg(data, "dma_tc1err_handler\n");
- return IRQ_HANDLED;
-}
-
static int reserve_contiguous_slots(int ctlr, unsigned int id,
unsigned int num_slots,
unsigned int start_slot)
@@ -1538,23 +1518,6 @@ static int __init edma_probe(struct platform_device *pdev)
arch_num_cc++;
}
- if (tc_errs_handled) {
- status = request_irq(IRQ_TCERRINT0, dma_tc0err_handler, 0,
- "edma_tc0", &pdev->dev);
- if (status < 0) {
- dev_dbg(&pdev->dev, "request_irq %d failed --> %d\n",
- IRQ_TCERRINT0, status);
- return status;
- }
- status = request_irq(IRQ_TCERRINT, dma_tc1err_handler, 0,
- "edma_tc1", &pdev->dev);
- if (status < 0) {
- dev_dbg(&pdev->dev, "request_irq %d --> %d\n",
- IRQ_TCERRINT, status);
- return status;
- }
- }
-
return 0;
fail:
--
1.7.9.5
next prev parent reply other threads:[~2012-10-18 13:26 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 13:26 [RFC PATCH v3 00/16] DMA Engine support for AM33XX Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 01/16] dmaengine: edma: fix slave config dependency on direction Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 02/16] ARM: davinci: move private EDMA API to arm/common Matt Porter
2012-10-28 8:17 ` Sekhar Nori
2012-11-16 16:49 ` Matt Porter
2013-01-10 23:51 ` Matt Porter
2013-01-22 15:40 ` Sekhar Nori
[not found] ` <d631bf39a8b8474bae448d089497fe0e@DLEE74.ent.ti.com>
2013-01-23 21:00 ` Matt Porter
2012-10-18 13:26 ` Matt Porter [this message]
2012-10-18 13:26 ` [RFC PATCH v3 04/16] ARM: edma: add DT and runtime PM support for AM33XX Matt Porter
2012-10-28 11:03 ` Sekhar Nori
2013-01-10 19:18 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 05/16] ARM: edma: add AM33XX crossbar event support Matt Porter
2012-10-26 12:53 ` Hebbar, Gururaja
2012-10-28 11:11 ` Sekhar Nori
2013-01-10 22:54 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 06/16] dmaengine: edma: enable build for AM33XX Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 07/16] dmaengine: edma: Add TI EDMA device tree binding Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 08/16] ARM: dts: add AM33XX EDMA support Matt Porter
2012-10-28 11:16 ` Sekhar Nori
2013-01-10 19:27 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 09/16] dmaengine: add dma_request_slave_channel_compat() Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 10/16] mmc: omap_hsmmc: convert to dma_request_slave_channel_compat() Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC Matt Porter
2012-10-29 8:18 ` Sekhar Nori
2013-01-10 19:30 ` Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 12/16] mmc: omap_hsmmc: add generic DMA request support to the DT binding Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 13/16] ARM: dts: add AM33XX MMC support Matt Porter
2012-10-30 5:33 ` AnilKumar, Chimata
2013-01-10 20:26 ` Matt Porter
2013-01-03 10:03 ` Hebbar, Gururaja
2012-10-18 13:26 ` [RFC PATCH v3 14/16] spi: omap2-mcspi: convert to dma_request_slave_channel_compat() Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 15/16] spi: omap2-mcspi: add generic DMA request support to the DT binding Matt Porter
2012-10-18 13:26 ` [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support Matt Porter
2012-10-28 11:31 ` Sekhar Nori
2013-01-10 19:35 ` Matt Porter
2013-01-10 19:46 ` Nishanth Menon
2013-01-10 20:49 ` Matt Porter
2013-01-10 20:49 ` Nishanth Menon
2012-10-29 9:11 ` Philip, Avinash
2012-10-30 9:41 ` Philip, Avinash
2012-10-31 10:16 ` Benoit Cousson
2012-10-31 10:35 ` Benoit Cousson
2012-10-31 11:03 ` Philip, Avinash
2012-10-19 10:26 ` [RFC PATCH v3 00/16] DMA Engine support for AM33XX Bedia, Vaibhav
2012-10-19 11:15 ` Matt Porter
2012-10-19 12:02 ` Bedia, Vaibhav
2012-10-19 16:46 ` Matt Porter
2012-10-22 5:53 ` Bedia, Vaibhav
2012-10-26 8:32 ` Russ Dill
2012-11-05 7:19 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350566815-409-4-git-send-email-mporter@ti.com \
--to=mporter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).