From: vkoul@infradead.org (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dmaengine: sirf: fix a typo in moving running dma_desc to active queue
Date: Wed, 24 Oct 2012 16:33:31 +0530 [thread overview]
Message-ID: <1351076611.5263.58.camel@vkoul-udesk3> (raw)
In-Reply-To: <1348734970-20050-1-git-send-email-Barry.Song@csr.com>
On Thu, 2012-09-27 at 16:36 +0800, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
>
> list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued)
> undefined, we either should change it to:
> list_move_tail(schan->queued.next, &schan->active)
> or
> list_move_tail(&sdesc->node, &schan->active)
>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
> drivers/dma/sirf-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
> index 35a329d..c439489 100644
> --- a/drivers/dma/sirf-dma.c
> +++ b/drivers/dma/sirf-dma.c
> @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan)
> sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,
> node);
> /* Move the first queued descriptor to active list */
> - list_move_tail(&schan->queued, &schan->active);
> + list_move_tail(&sdesc->node, &schan->active);
>
> /* Start the DMA transfer */
> writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +
applied thanks
--
Vinod Koul
Intel Corp.
prev parent reply other threads:[~2012-10-24 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 8:36 [PATCH 2/3] dmaengine: sirf: fix a typo in moving running dma_desc to active queue Barry Song
2012-10-24 11:03 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351076611.5263.58.camel@vkoul-udesk3 \
--to=vkoul@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox