From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm:socfpga: Enable SMP for socfpga
Date: Thu, 25 Oct 2012 10:25:56 -0600 [thread overview]
Message-ID: <1351182356.15182.7.camel@dinh-ubuntu> (raw)
In-Reply-To: <50887348.9070904@gmail.com>
Hi Rob,
On Wed, 2012-10-24 at 18:01 -0500, Rob Herring wrote:
> On 10/18/2012 12:32 PM, dinguyen at altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> >
> > Enable SMP for the SOCFPGA platform.
> >
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > ---
> > v2:
> > -Remove pen_release code
> > -Remove code that was already done by v7_setup
> > -Add bindings document for reset and system manager
> > -Move socfpga_sysmgr_init from platsmp.c to socfpga.c, because
> > we will need to use the reset and system manager for more than SMP.
> > -Move core.h to mach-socfpga from mach-socfpga/include/mach
>
> Just some lingering comments on the defconfig. Otherwise,
>
> Reviewed-by: Rob Herring <rob.herring@calxeda.com>
>
> > diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
> > index 0ac1293..349ac22 100644
> > --- a/arch/arm/configs/socfpga_defconfig
> > +++ b/arch/arm/configs/socfpga_defconfig
>
> I'm still not clear why multi_v7 config does not work for you?
multi_v7 works fine for me. But I need
+#CONFIG_ARCH_VEXPRESS_CORTEX_A5_A9_ERRATA is not set
in order for SMP to work correctly on our platform.
>
> > @@ -1,5 +1,5 @@
> > CONFIG_EXPERIMENTAL=y
> > -CONFIG_SYSVIPC=y
> > +CONFIG_NO_HZ=y
> > CONFIG_IKCONFIG=y
> > CONFIG_IKCONFIG_PROC=y
> > CONFIG_LOG_BUF_SHIFT=14
> > @@ -16,10 +16,13 @@ CONFIG_MODULE_UNLOAD=y
> > # CONFIG_IOSCHED_DEADLINE is not set
> > # CONFIG_IOSCHED_CFQ is not set
> > CONFIG_ARCH_SOCFPGA=y
> > -CONFIG_MACH_SOCFPGA_CYCLONE5=y
> > -CONFIG_ARM_THUMBEE=y
> > +# CONFIG_ARCH_VEXPRESS_CORTEX_A5_A9_ERRATA is not set
> > # CONFIG_CACHE_L2X0 is not set
> > CONFIG_HIGH_RES_TIMERS=y
> > +CONFIG_SMP=y
> > +CONFIG_ARM_ARCH_TIMER=y
>
> You're an A9, right? You don't have arch timers.
Yes, will remove in v3.
>
> > +CONFIG_HIGHMEM=y
>
> How much RAM? You need more than 2GB with CONFIG_VMSPLIT_2G.
1G for RAM only, so will remove in v3.
Thanks,
Dinh
>
> > +CONFIG_HIGHPTE=y
> > CONFIG_VMSPLIT_2G=y
> > CONFIG_NR_CPUS=2
> > CONFIG_AEABI=y
>
>
next prev parent reply other threads:[~2012-10-25 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 17:32 [PATCHv2] arm:socfpga: Enable SMP for socfpga dinguyen at altera.com
2012-10-24 22:43 ` Pavel Machek
2012-10-24 22:57 ` Thomas Petazzoni
2012-10-25 16:21 ` Dinh Nguyen
2012-10-24 23:01 ` Rob Herring
2012-10-25 16:25 ` Dinh Nguyen [this message]
2012-10-25 15:41 ` Rob Herring
2012-10-25 17:49 ` Dinh Nguyen
2012-10-27 11:43 ` ERRATA_751472 was " Pavel Machek
2012-10-25 13:56 ` Arnd Bergmann
2012-10-25 16:29 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351182356.15182.7.camel@dinh-ubuntu \
--to=dinguyen@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).