From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h
Date: Thu, 25 Oct 2012 22:22:48 +0200 [thread overview]
Message-ID: <1351198976.2hJjhe5gKC@avalon> (raw)
In-Reply-To: <20121025165643.GP11928@atomide.com>
Hi Tony,
On Thursday 25 October 2012 09:56:44 Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121025 01:39]:
> > I still think you should split this in two files, omap-iommu.h and omap-
> > iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h
> > moved to include/linux.h.
>
> Can you please explain a bit more why you're thinking a separate
> omap-iovmm.h is needed in addtion to omap-iommu.h?
The IOVMM API is layered top of the IOMMU API. It's really a separate API, so
two header files make sense. This patch creates a hybrid omap-iommu.h header
with mixed definitions, it just doesn't feel right :-) I won't insist for a
split though, if you think it's better to have a single header we can keep it
that way.
> My reasoning for not adding it is that neither intel nor amd needs
> more than intel-iommu.h and amd-iommu.h. And hopefully the iommu
> framework will eventually provide the API needed. And I'd rather
> not be the person introducing this second new file into
> include/linux :)
>
> Joerg and Ohad, do you have any opinions on this?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-10-25 20:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 0:20 [PATCH v4 0/6] omap iommu changes to remove plat includes Tony Lindgren
2012-10-25 0:20 ` [PATCH 1/6] ARM: OMAP: Merge iommu2.h into iommu.h Tony Lindgren
2012-10-25 0:20 ` [PATCH 2/6] ARM: OMAP2+: Move iopgtable header to drivers/iommu/ Tony Lindgren
2012-10-25 0:20 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-25 8:39 ` Laurent Pinchart
2012-10-25 16:56 ` Tony Lindgren
2012-10-25 20:22 ` Laurent Pinchart [this message]
2012-10-25 21:39 ` Tony Lindgren
2012-10-26 5:50 ` Ohad Ben-Cohen
2012-10-26 9:35 ` Laurent Pinchart
2012-10-26 9:54 ` Ohad Ben-Cohen
2012-10-26 18:00 ` Tony Lindgren
2012-10-30 16:29 ` Tony Lindgren
2012-11-02 18:55 ` Tony Lindgren
2012-10-25 0:20 ` [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c Tony Lindgren
2012-10-25 0:21 ` [PATCH 5/6] ARM: OMAP2+: Make some definitions local Tony Lindgren
2012-10-25 0:21 ` [PATCH 6/6] ARM: OMAP2+: Move iommu/iovmm headers to platform_data Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2012-11-02 19:23 [PATCH v5 0/6] Move rest of omap-iommu to live in drivers/iommu Tony Lindgren
2012-11-02 19:24 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-18 20:28 [PATCH v3 0/6] omap iommu changes to remove plat includes Tony Lindgren
2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-18 20:56 ` Mauro Carvalho Chehab
2012-10-18 22:11 ` Tony Lindgren
2012-10-19 9:40 ` Laurent Pinchart
2012-10-19 16:14 ` Tony Lindgren
2012-10-24 22:34 ` Tony Lindgren
2012-10-24 23:53 ` Laurent Pinchart
2012-10-25 0:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351198976.2hJjhe5gKC@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox