From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: vt8500: Remove dependancy on pmc_base
Date: Mon, 29 Oct 2012 10:40:31 +1300 [thread overview]
Message-ID: <1351460431-1048-2-git-send-email-linux@prisktech.co.nz> (raw)
In-Reply-To: <1351460431-1048-1-git-send-email-linux@prisktech.co.nz>
This patch removes the requirement to pass a Power Management
Controller base address to vtwm_clk_init(), in preparation of
separating the power management code from arch-vt8500/vt8500.c.
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
---
Mike,
Do you mind if this patch goes through arm-soc, given it is self-contained,
so I can base the other PM changes off it?
Regards
Tony P
arch/arm/mach-vt8500/common.h | 2 +-
arch/arm/mach-vt8500/vt8500.c | 2 +-
drivers/clk/clk-vt8500.c | 20 ++++++++++++++++----
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-vt8500/common.h b/arch/arm/mach-vt8500/common.h
index 2b24196..e38b17f 100644
--- a/arch/arm/mach-vt8500/common.h
+++ b/arch/arm/mach-vt8500/common.h
@@ -23,6 +23,6 @@ int __init vt8500_irq_init(struct device_node *node,
struct device_node *parent);
/* defined in drivers/clk/clk-vt8500.c */
-void __init vtwm_clk_init(void __iomem *pmc_base);
+void __init vtwm_clk_init(void);
#endif
diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
index 8d3871f..0ee2a16 100644
--- a/arch/arm/mach-vt8500/vt8500.c
+++ b/arch/arm/mach-vt8500/vt8500.c
@@ -162,7 +162,7 @@ void __init vt8500_init(void)
else
pr_err("%s: PMC Hibernation register could not be remapped, not enabling power off!\n", __func__);
- vtwm_clk_init(pmc_base);
+ vtwm_clk_init();
of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
}
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index fe25570..820f39a 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
@@ -15,6 +15,7 @@
#include <linux/io.h>
#include <linux/of.h>
+#include <linux/of_address.h>
#include <linux/slab.h>
#include <linux/bitops.h>
#include <linux/clkdev.h>
@@ -517,12 +518,23 @@ static const __initconst struct of_device_id clk_match[] = {
{ /* sentinel */ }
};
-void __init vtwm_clk_init(void __iomem *base)
+void __init vtwm_clk_init(void)
{
- if (!base)
- return;
+ struct device_node *np =
+ of_find_compatible_node(NULL, NULL, "via,vt8500-pmc");
+
+ if (!np) {
+ pr_err("%s: power management device node missing\n", __func__);
+ return -ENODEV;
+ }
- pmc_base = base;
+ pmc_base = of_iomap(np, 0);
+ of_node_put(np);
+
+ if (!pmc_base) {
+ pr_err("%s: of_iomap(pmc) failed\n", __func__);
+ return -ENOMEM;
+ }
of_clk_init(clk_match);
}
--
1.7.9.5
prev parent reply other threads:[~2012-10-28 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 21:40 [PATCH RESEND 1/2] clk: vt8500: Fix SDMMC clock special cases Tony Prisk
2012-10-28 21:40 ` Tony Prisk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351460431-1048-2-git-send-email-linux@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).