From: alban.bedel@avionic-design.de (Alban Bedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] lpc32xx: irq - Set the chain handlers after setting up the IRQ domain
Date: Thu, 1 Nov 2012 13:23:46 +0100 [thread overview]
Message-ID: <1351772626-12615-1-git-send-email-alban.bedel@avionic-design.de> (raw)
Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
---
arch/arm/mach-lpc32xx/irq.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-lpc32xx/irq.c b/arch/arm/mach-lpc32xx/irq.c
index 3c63327..b92dc25 100644
--- a/arch/arm/mach-lpc32xx/irq.c
+++ b/arch/arm/mach-lpc32xx/irq.c
@@ -448,10 +448,6 @@ void __init lpc32xx_init_irq(void)
__raw_writel(0, LPC32XX_INTC_MASK(LPC32XX_SIC1_BASE));
__raw_writel(0, LPC32XX_INTC_MASK(LPC32XX_SIC2_BASE));
- /* MIC SUBIRQx interrupts will route handling to the chain handlers */
- irq_set_chained_handler(IRQ_LPC32XX_SUB1IRQ, lpc32xx_sic1_handler);
- irq_set_chained_handler(IRQ_LPC32XX_SUB2IRQ, lpc32xx_sic2_handler);
-
/* Initially disable all wake events */
__raw_writel(0, LPC32XX_CLKPWR_P01_ER);
__raw_writel(0, LPC32XX_CLKPWR_INT_ER);
@@ -485,6 +481,12 @@ void __init lpc32xx_init_irq(void)
irq_base, 0,
&irq_domain_simple_ops,
NULL);
- if (!lpc32xx_mic_domain)
+ if (!lpc32xx_mic_domain) {
panic("Unable to add MIC irq domain\n");
+ return;
+ }
+
+ /* MIC SUBIRQx interrupts will route handling to the chain handlers */
+ irq_set_chained_handler(IRQ_LPC32XX_SUB1IRQ, lpc32xx_sic1_handler);
+ irq_set_chained_handler(IRQ_LPC32XX_SUB2IRQ, lpc32xx_sic2_handler);
}
--
1.7.0.4
next reply other threads:[~2012-11-01 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 12:23 Alban Bedel [this message]
2012-11-02 9:01 ` [PATCH] lpc32xx: irq - Set the chain handlers after setting up the IRQ domain Roland Stigge
2012-11-05 17:00 ` Alban Bedel
2012-11-05 17:35 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351772626-12615-1-git-send-email-alban.bedel@avionic-design.de \
--to=alban.bedel@avionic-design.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).