linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/9] ARM: integrator: Remove unused icst_params lclk_params structure
       [not found] <1351980150-24145-1-git-send-email-lee.jones@linaro.org>
@ 2012-11-03 22:02 ` Lee Jones
  2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
  1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-03 22:02 UTC (permalink / raw)
  To: linux-arm-kernel

This was introduced way back before 2005 and has remained unused for
over 7 years. Let's remove it.

Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/mach-integrator/cpu.c |   12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm/mach-integrator/cpu.c b/arch/arm/mach-integrator/cpu.c
index 590c192..4e0a689 100644
--- a/arch/arm/mach-integrator/cpu.c
+++ b/arch/arm/mach-integrator/cpu.c
@@ -30,18 +30,6 @@ static struct cpufreq_driver integrator_driver;
 #define CM_STAT __io_address(INTEGRATOR_HDR_STAT)
 #define CM_LOCK __io_address(INTEGRATOR_HDR_LOCK)
 
-static const struct icst_params lclk_params = {
-	.ref		= 24000000,
-	.vco_max	= ICST525_VCO_MAX_5V,
-	.vco_min	= ICST525_VCO_MIN,
-	.vd_min		= 8,
-	.vd_max		= 132,
-	.rd_min		= 24,
-	.rd_max		= 24,
-	.s2div		= icst525_s2div,
-	.idx2s		= icst525_idx2s,
-};
-
 static const struct icst_params cclk_params = {
 	.ref		= 24000000,
 	.vco_max	= ICST525_VCO_MAX_5V,
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources
       [not found] <1351980150-24145-1-git-send-email-lee.jones@linaro.org>
  2012-11-03 22:02 ` [PATCH 1/9] ARM: integrator: Remove unused icst_params lclk_params structure Lee Jones
@ 2012-11-03 22:02 ` Lee Jones
  2012-11-04 10:15   ` Jean-Christophe PLAGNIOL-VILLARD
  2012-11-05  8:13   ` Josh Wu
  1 sibling, 2 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-03 22:02 UTC (permalink / raw)
  To: linux-arm-kernel

This the at91sam9g45_isi_device structure and its associated resources
were added in 2008 and have been unused ever since. Let's remove them.

Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/mach-at91/at91sam9263_devices.c |   20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
index cb85da2..0562a9d 100644
--- a/arch/arm/mach-at91/at91sam9263_devices.c
+++ b/arch/arm/mach-at91/at91sam9263_devices.c
@@ -901,26 +901,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) {}
 
 #if defined(CONFIG_VIDEO_AT91_ISI) || defined(CONFIG_VIDEO_AT91_ISI_MODULE)
 
-struct resource isi_resources[] = {
-	[0] = {
-		.start	= AT91SAM9263_BASE_ISI,
-		.end	= AT91SAM9263_BASE_ISI + SZ_16K - 1,
-		.flags	= IORESOURCE_MEM,
-	},
-	[1] = {
-		.start	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
-		.end	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
-		.flags	= IORESOURCE_IRQ,
-	},
-};
-
-static struct platform_device at91sam9263_isi_device = {
-	.name		= "at91_isi",
-	.id		= -1,
-	.resource	= isi_resources,
-	.num_resources	= ARRAY_SIZE(isi_resources),
-};
-
 void __init at91_add_device_isi(struct isi_platform_data *data,
 		bool use_pck_as_mck)
 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources
  2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
@ 2012-11-04 10:15   ` Jean-Christophe PLAGNIOL-VILLARD
  2012-11-04 10:57     ` Lee Jones
  2012-11-05  8:13   ` Josh Wu
  1 sibling, 1 reply; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-11-04 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

On 23:02 Sat 03 Nov     , Lee Jones wrote:
> This the at91sam9g45_isi_device structure and its associated resources
> were added in 2008 and have been unused ever since. Let's remove them.
next time you need to Cc the matinaers

NACK

Best Regards,
J.
> 
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/mach-at91/at91sam9263_devices.c |   20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> index cb85da2..0562a9d 100644
> --- a/arch/arm/mach-at91/at91sam9263_devices.c
> +++ b/arch/arm/mach-at91/at91sam9263_devices.c
> @@ -901,26 +901,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) {}
>  
>  #if defined(CONFIG_VIDEO_AT91_ISI) || defined(CONFIG_VIDEO_AT91_ISI_MODULE)
>  
> -struct resource isi_resources[] = {
> -	[0] = {
> -		.start	= AT91SAM9263_BASE_ISI,
> -		.end	= AT91SAM9263_BASE_ISI + SZ_16K - 1,
> -		.flags	= IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> -		.end	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> -		.flags	= IORESOURCE_IRQ,
> -	},
> -};
> -
> -static struct platform_device at91sam9263_isi_device = {
> -	.name		= "at91_isi",
> -	.id		= -1,
> -	.resource	= isi_resources,
> -	.num_resources	= ARRAY_SIZE(isi_resources),
> -};
> -
>  void __init at91_add_device_isi(struct isi_platform_data *data,
>  		bool use_pck_as_mck)
>  {
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources
  2012-11-04 10:15   ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-11-04 10:57     ` Lee Jones
  0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-04 10:57 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, 04 Nov 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 23:02 Sat 03 Nov     , Lee Jones wrote:
> > This the at91sam9g45_isi_device structure and its associated resources
> > were added in 2008 and have been unused ever since. Let's remove them.
> next time you need to Cc the matinaers

I did:

$ git show <sha1> | scripts/get_maintainer.pl
  Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
  linux-arm-kernel at lists.infradead.org (moderated list:ARM SUB-ARCHITECT...)
  linux-kernel at vger.kernel.org (open list)

> NACK

Any particular reason?

> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  arch/arm/mach-at91/at91sam9263_devices.c |   20 --------------------
> >  1 file changed, 20 deletions(-)
> > 
> > diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> > index cb85da2..0562a9d 100644
> > --- a/arch/arm/mach-at91/at91sam9263_devices.c
> > +++ b/arch/arm/mach-at91/at91sam9263_devices.c
> > @@ -901,26 +901,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) {}
> >  
> >  #if defined(CONFIG_VIDEO_AT91_ISI) || defined(CONFIG_VIDEO_AT91_ISI_MODULE)
> >  
> > -struct resource isi_resources[] = {
> > -	[0] = {
> > -		.start	= AT91SAM9263_BASE_ISI,
> > -		.end	= AT91SAM9263_BASE_ISI + SZ_16K - 1,
> > -		.flags	= IORESOURCE_MEM,
> > -	},
> > -	[1] = {
> > -		.start	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> > -		.end	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> > -		.flags	= IORESOURCE_IRQ,
> > -	},
> > -};
> > -
> > -static struct platform_device at91sam9263_isi_device = {
> > -	.name		= "at91_isi",
> > -	.id		= -1,
> > -	.resource	= isi_resources,
> > -	.num_resources	= ARRAY_SIZE(isi_resources),
> > -};
> > -
> >  void __init at91_add_device_isi(struct isi_platform_data *data,
> >  		bool use_pck_as_mck)
> >  {
> > -- 
> > 1.7.9.5
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources
  2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
  2012-11-04 10:15   ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-11-05  8:13   ` Josh Wu
  2012-11-05  8:19     ` Lee Jones
  1 sibling, 1 reply; 6+ messages in thread
From: Josh Wu @ 2012-11-05  8:13 UTC (permalink / raw)
  To: linux-arm-kernel

Hi, Lee Jones

On 11/4/2012 6:02 AM, Lee Jones wrote:
> This the at91sam9g45_isi_device structure and its associated resources
> were added in 2008 and have been unused ever since. Let's remove them.

I'm the maintainer of the Atmel ISI driver. Currently the ISI still not 
work on at91sam9263 board.
But this task is in my plan. So keep those code and I will enable ISI 
support for 9263 in the future. Thanks.

Best Regards,
Josh Wu

> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   arch/arm/mach-at91/at91sam9263_devices.c |   20 --------------------
>   1 file changed, 20 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> index cb85da2..0562a9d 100644
> --- a/arch/arm/mach-at91/at91sam9263_devices.c
> +++ b/arch/arm/mach-at91/at91sam9263_devices.c
> @@ -901,26 +901,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) {}
>   
>   #if defined(CONFIG_VIDEO_AT91_ISI) || defined(CONFIG_VIDEO_AT91_ISI_MODULE)
>   
> -struct resource isi_resources[] = {
> -	[0] = {
> -		.start	= AT91SAM9263_BASE_ISI,
> -		.end	= AT91SAM9263_BASE_ISI + SZ_16K - 1,
> -		.flags	= IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> -		.end	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> -		.flags	= IORESOURCE_IRQ,
> -	},
> -};
> -
> -static struct platform_device at91sam9263_isi_device = {
> -	.name		= "at91_isi",
> -	.id		= -1,
> -	.resource	= isi_resources,
> -	.num_resources	= ARRAY_SIZE(isi_resources),
> -};
> -
>   void __init at91_add_device_isi(struct isi_platform_data *data,
>   		bool use_pck_as_mck)
>   {

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources
  2012-11-05  8:13   ` Josh Wu
@ 2012-11-05  8:19     ` Lee Jones
  0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-05  8:19 UTC (permalink / raw)
  To: linux-arm-kernel

> >This the at91sam9g45_isi_device structure and its associated resources
> >were added in 2008 and have been unused ever since. Let's remove them.
> 
> I'm the maintainer of the Atmel ISI driver. Currently the ISI still
> not work on at91sam9263 board.
> But this task is in my plan. So keep those code and I will enable
> ISI support for 9263 in the future. Thanks.

No problem at all. Thanks for getting back to me Josh.

Kind regards,
Lee

> >Cc: Russell King <linux@arm.linux.org.uk>
> >Cc: linux-arm-kernel at lists.infradead.org
> >Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >---
> >  arch/arm/mach-at91/at91sam9263_devices.c |   20 --------------------
> >  1 file changed, 20 deletions(-)
> >
> >diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> >index cb85da2..0562a9d 100644
> >--- a/arch/arm/mach-at91/at91sam9263_devices.c
> >+++ b/arch/arm/mach-at91/at91sam9263_devices.c
> >@@ -901,26 +901,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) {}
> >  #if defined(CONFIG_VIDEO_AT91_ISI) || defined(CONFIG_VIDEO_AT91_ISI_MODULE)
> >-struct resource isi_resources[] = {
> >-	[0] = {
> >-		.start	= AT91SAM9263_BASE_ISI,
> >-		.end	= AT91SAM9263_BASE_ISI + SZ_16K - 1,
> >-		.flags	= IORESOURCE_MEM,
> >-	},
> >-	[1] = {
> >-		.start	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> >-		.end	= NR_IRQS_LEGACY + AT91SAM9263_ID_ISI,
> >-		.flags	= IORESOURCE_IRQ,
> >-	},
> >-};
> >-
> >-static struct platform_device at91sam9263_isi_device = {
> >-	.name		= "at91_isi",
> >-	.id		= -1,
> >-	.resource	= isi_resources,
> >-	.num_resources	= ARRAY_SIZE(isi_resources),
> >-};
> >-
> >  void __init at91_add_device_isi(struct isi_platform_data *data,
> >  		bool use_pck_as_mck)
> >  {
> 

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-05  8:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1351980150-24145-1-git-send-email-lee.jones@linaro.org>
2012-11-03 22:02 ` [PATCH 1/9] ARM: integrator: Remove unused icst_params lclk_params structure Lee Jones
2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
2012-11-04 10:15   ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-04 10:57     ` Lee Jones
2012-11-05  8:13   ` Josh Wu
2012-11-05  8:19     ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).