* [PATCH 0/4] mx5x usb{misc} devictree bindings and clocks
@ 2012-11-15 14:00 Michael Grzeschik
2012-11-15 14:00 ` [PATCH 1/4] ARM: imx: add imx5x usb controller clock lookups Michael Grzeschik
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Michael Grzeschik @ 2012-11-15 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Michael Grzeschik (4):
ARM: imx: add imx5x usb controller clock lookups
ARM: imx: add imx5x usbmisc clock lookups
ARM: dts: imx: rename imx5x usb entries as in imx6q.dtsi
ARM: dts: imx: add imx5x phy-mode entries
arch/arm/boot/dts/imx51.dtsi | 14 ++++++++++----
arch/arm/boot/dts/imx53.dtsi | 14 ++++++++++----
arch/arm/mach-imx/clk-imx51-imx53.c | 30 ++++++++++++++++++++++++++++++
3 files changed, 50 insertions(+), 8 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/4] ARM: imx: add imx5x usb controller clock lookups
2012-11-15 14:00 [PATCH 0/4] mx5x usb{misc} devictree bindings and clocks Michael Grzeschik
@ 2012-11-15 14:00 ` Michael Grzeschik
2012-11-15 14:00 ` [PATCH 2/4] ARM: imx: add imx5x usbmisc " Michael Grzeschik
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Michael Grzeschik @ 2012-11-15 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
arch/arm/mach-imx/clk-imx51-imx53.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
index a0bf848..3edd11c 100644
--- a/arch/arm/mach-imx/clk-imx51-imx53.c
+++ b/arch/arm/mach-imx/clk-imx51-imx53.c
@@ -353,6 +353,18 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
clk_register_clkdev(clk[ipu_di0_gate], "di0", "imx51-ipu");
clk_register_clkdev(clk[ipu_di1_gate], "di1", "imx51-ipu");
clk_register_clkdev(clk[ipu_gate], "hsp", "imx51-ipu");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80600.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80600.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80600.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80400.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80400.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80400.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80200.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80200.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80200.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
clk_register_clkdev(clk[usb_phy_gate], "phy", "mxc-ehci.0");
clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx51.0");
clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx51.0");
@@ -446,6 +458,18 @@ int __init mx53_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
clk_register_clkdev(clk[ipu_di0_gate], "di0", "imx53-ipu");
clk_register_clkdev(clk[ipu_di1_gate], "di1", "imx53-ipu");
clk_register_clkdev(clk[ipu_gate], "hsp", "imx53-ipu");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80600.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80600.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80600.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80400.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80400.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80400.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80200.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80200.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80200.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80000.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80000.usb");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80000.usb");
clk_register_clkdev(clk[usb_phy1_gate], "usb_phy1", "mxc-ehci.0");
clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx53.0");
clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx53.0");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/4] ARM: imx: add imx5x usbmisc clock lookups
2012-11-15 14:00 [PATCH 0/4] mx5x usb{misc} devictree bindings and clocks Michael Grzeschik
2012-11-15 14:00 ` [PATCH 1/4] ARM: imx: add imx5x usb controller clock lookups Michael Grzeschik
@ 2012-11-15 14:00 ` Michael Grzeschik
2012-11-16 9:25 ` Sascha Hauer
2012-11-15 14:00 ` [PATCH 3/4] ARM: dts: imx: rename imx5x usb entries as in imx6q.dtsi Michael Grzeschik
2012-11-15 14:00 ` [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries Michael Grzeschik
3 siblings, 1 reply; 12+ messages in thread
From: Michael Grzeschik @ 2012-11-15 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
arch/arm/mach-imx/clk-imx51-imx53.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
index 3edd11c..33c3c9b 100644
--- a/arch/arm/mach-imx/clk-imx51-imx53.c
+++ b/arch/arm/mach-imx/clk-imx51-imx53.c
@@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
clk_register_clkdev(clk[usb_phy_gate], "phy", "mxc-ehci.0");
clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx51.0");
clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx51.0");
@@ -470,6 +473,9 @@ int __init mx53_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80000.usb");
clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80000.usb");
clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80000.usb");
+ clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80800.usbmisc");
+ clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80800.usbmisc");
+ clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80800.usbmisc");
clk_register_clkdev(clk[usb_phy1_gate], "usb_phy1", "mxc-ehci.0");
clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx53.0");
clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx53.0");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/4] ARM: dts: imx: rename imx5x usb entries as in imx6q.dtsi
2012-11-15 14:00 [PATCH 0/4] mx5x usb{misc} devictree bindings and clocks Michael Grzeschik
2012-11-15 14:00 ` [PATCH 1/4] ARM: imx: add imx5x usb controller clock lookups Michael Grzeschik
2012-11-15 14:00 ` [PATCH 2/4] ARM: imx: add imx5x usbmisc " Michael Grzeschik
@ 2012-11-15 14:00 ` Michael Grzeschik
2012-11-15 14:00 ` [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries Michael Grzeschik
3 siblings, 0 replies; 12+ messages in thread
From: Michael Grzeschik @ 2012-11-15 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
arch/arm/boot/dts/imx51.dtsi | 12 ++++++++----
arch/arm/boot/dts/imx53.dtsi | 12 ++++++++----
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 75d069f..366b8d3 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -21,6 +21,10 @@
gpio1 = &gpio2;
gpio2 = &gpio3;
gpio3 = &gpio4;
+ usb0 = &usbotg;
+ usb1 = &usbhost1;
+ usb2 = &usbhost2;
+ usb3 = &usbhost3;
};
tzic: tz-interrupt-controller at e0000000 {
@@ -130,28 +134,28 @@
};
};
- usb at 73f80000 {
+ usbotg: usb at 73f80000 {
compatible = "fsl,imx51-usb", "fsl,imx27-usb";
reg = <0x73f80000 0x0200>;
interrupts = <18>;
status = "disabled";
};
- usb at 73f80200 {
+ usbhost1: usb at 73f80200 {
compatible = "fsl,imx51-usb", "fsl,imx27-usb";
reg = <0x73f80200 0x0200>;
interrupts = <14>;
status = "disabled";
};
- usb at 73f80400 {
+ usbhost2: usb at 73f80400 {
compatible = "fsl,imx51-usb", "fsl,imx27-usb";
reg = <0x73f80400 0x0200>;
interrupts = <16>;
status = "disabled";
};
- usb at 73f80600 {
+ usbhost3: usb at 73f80600 {
compatible = "fsl,imx51-usb", "fsl,imx27-usb";
reg = <0x73f80600 0x0200>;
interrupts = <17>;
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 76ebb1a..2faa193 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -26,6 +26,10 @@
gpio4 = &gpio5;
gpio5 = &gpio6;
gpio6 = &gpio7;
+ usb0 = &usbotg;
+ usb1 = &usbhost1;
+ usb2 = &usbhost2;
+ usb3 = &usbhost3;
};
tzic: tz-interrupt-controller at 0fffc000 {
@@ -135,28 +139,28 @@
};
};
- usb at 53f80000 {
+ usbotg: usb at 53f80000 {
compatible = "fsl,imx53-usb", "fsl,imx27-usb";
reg = <0x53f80000 0x0200>;
interrupts = <18>;
status = "disabled";
};
- usb at 53f80200 {
+ usbhost1: usb at 53f80200 {
compatible = "fsl,imx53-usb", "fsl,imx27-usb";
reg = <0x53f80200 0x0200>;
interrupts = <14>;
status = "disabled";
};
- usb at 53f80400 {
+ usbhost2: usb at 53f80400 {
compatible = "fsl,imx53-usb", "fsl,imx27-usb";
reg = <0x53f80400 0x0200>;
interrupts = <16>;
status = "disabled";
};
- usb at 53f80600 {
+ usbhost3: usb at 53f80600 {
compatible = "fsl,imx53-usb", "fsl,imx27-usb";
reg = <0x53f80600 0x0200>;
interrupts = <17>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries
2012-11-15 14:00 [PATCH 0/4] mx5x usb{misc} devictree bindings and clocks Michael Grzeschik
` (2 preceding siblings ...)
2012-11-15 14:00 ` [PATCH 3/4] ARM: dts: imx: rename imx5x usb entries as in imx6q.dtsi Michael Grzeschik
@ 2012-11-15 14:00 ` Michael Grzeschik
2012-11-16 7:15 ` Shawn Guo
3 siblings, 1 reply; 12+ messages in thread
From: Michael Grzeschik @ 2012-11-15 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
arch/arm/boot/dts/imx51.dtsi | 2 ++
arch/arm/boot/dts/imx53.dtsi | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 366b8d3..ffc6bc8 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -145,6 +145,7 @@
compatible = "fsl,imx51-usb", "fsl,imx27-usb";
reg = <0x73f80200 0x0200>;
interrupts = <14>;
+ phy-mode = "utmiw";
status = "disabled";
};
@@ -152,6 +153,7 @@
compatible = "fsl,imx51-usb", "fsl,imx27-usb";
reg = <0x73f80400 0x0200>;
interrupts = <16>;
+ phy-mode = "utmi";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 2faa193..1da8e12 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -143,6 +143,7 @@
compatible = "fsl,imx53-usb", "fsl,imx27-usb";
reg = <0x53f80000 0x0200>;
interrupts = <18>;
+ phy-mode = "utmiw";
status = "disabled";
};
@@ -150,6 +151,7 @@
compatible = "fsl,imx53-usb", "fsl,imx27-usb";
reg = <0x53f80200 0x0200>;
interrupts = <14>;
+ phy-mode = "utmi";
status = "disabled";
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries
2012-11-15 14:00 ` [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries Michael Grzeschik
@ 2012-11-16 7:15 ` Shawn Guo
2012-11-16 9:28 ` Marc Kleine-Budde
0 siblings, 1 reply; 12+ messages in thread
From: Shawn Guo @ 2012-11-16 7:15 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 15, 2012 at 03:00:14PM +0100, Michael Grzeschik wrote:
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> arch/arm/boot/dts/imx51.dtsi | 2 ++
> arch/arm/boot/dts/imx53.dtsi | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> index 366b8d3..ffc6bc8 100644
> --- a/arch/arm/boot/dts/imx51.dtsi
> +++ b/arch/arm/boot/dts/imx51.dtsi
> @@ -145,6 +145,7 @@
> compatible = "fsl,imx51-usb", "fsl,imx27-usb";
> reg = <0x73f80200 0x0200>;
> interrupts = <14>;
> + phy-mode = "utmiw";
I tried to grep "phy-mode" and "utmiw" on linux-next and found nothing.
So it's not something we can take for 3.8, right?
PS. Instead, I found something like phy_type = "utmi_wide" in
fsl-usb.txt and fsl-mph-dr-of.c. Should these be consolidated into
a common binding?
Shawn
> status = "disabled";
> };
>
> @@ -152,6 +153,7 @@
> compatible = "fsl,imx51-usb", "fsl,imx27-usb";
> reg = <0x73f80400 0x0200>;
> interrupts = <16>;
> + phy-mode = "utmi";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 2faa193..1da8e12 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -143,6 +143,7 @@
> compatible = "fsl,imx53-usb", "fsl,imx27-usb";
> reg = <0x53f80000 0x0200>;
> interrupts = <18>;
> + phy-mode = "utmiw";
> status = "disabled";
> };
>
> @@ -150,6 +151,7 @@
> compatible = "fsl,imx53-usb", "fsl,imx27-usb";
> reg = <0x53f80200 0x0200>;
> interrupts = <14>;
> + phy-mode = "utmi";
> status = "disabled";
> };
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/4] ARM: imx: add imx5x usbmisc clock lookups
2012-11-15 14:00 ` [PATCH 2/4] ARM: imx: add imx5x usbmisc " Michael Grzeschik
@ 2012-11-16 9:25 ` Sascha Hauer
2012-11-16 14:28 ` Shawn Guo
0 siblings, 1 reply; 12+ messages in thread
From: Sascha Hauer @ 2012-11-16 9:25 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 15, 2012 at 03:00:12PM +0100, Michael Grzeschik wrote:
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> arch/arm/mach-imx/clk-imx51-imx53.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> index 3edd11c..33c3c9b 100644
> --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> @@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
> clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
> clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
> clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
> + clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
> + clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
> + clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
Shawn, do you have plans to move the clock lookups to devicetree like
you did on i.MX6? It would be nice to get rid of patches like this.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries
2012-11-16 7:15 ` Shawn Guo
@ 2012-11-16 9:28 ` Marc Kleine-Budde
2012-11-16 14:33 ` Shawn Guo
0 siblings, 1 reply; 12+ messages in thread
From: Marc Kleine-Budde @ 2012-11-16 9:28 UTC (permalink / raw)
To: linux-arm-kernel
On 11/16/2012 08:15 AM, Shawn Guo wrote:
> On Thu, Nov 15, 2012 at 03:00:14PM +0100, Michael Grzeschik wrote:
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> ---
>> arch/arm/boot/dts/imx51.dtsi | 2 ++
>> arch/arm/boot/dts/imx53.dtsi | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
>> index 366b8d3..ffc6bc8 100644
>> --- a/arch/arm/boot/dts/imx51.dtsi
>> +++ b/arch/arm/boot/dts/imx51.dtsi
>> @@ -145,6 +145,7 @@
>> compatible = "fsl,imx51-usb", "fsl,imx27-usb";
>> reg = <0x73f80200 0x0200>;
>> interrupts = <14>;
>> + phy-mode = "utmiw";
>
> I tried to grep "phy-mode" and "utmiw" on linux-next and found nothing.
> So it's not something we can take for 3.8, right?
But it wouldn't hurt, if we agree on a common usb phy-mode binding helper.
> PS. Instead, I found something like phy_type = "utmi_wide" in
> fsl-usb.txt and fsl-mph-dr-of.c. Should these be consolidated into
> a common binding?
This is exactly what Michael is trying to do:
http://permalink.gmane.org/gmane.linux.usb.general/74747
If there already is "umti_wide" we should use that, instead of "umtiw".
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121116/756d635d/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/4] ARM: imx: add imx5x usbmisc clock lookups
2012-11-16 14:28 ` Shawn Guo
@ 2012-11-16 14:19 ` Sascha Hauer
2012-11-16 17:48 ` Fabio Estevam
0 siblings, 1 reply; 12+ messages in thread
From: Sascha Hauer @ 2012-11-16 14:19 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 16, 2012 at 10:28:48PM +0800, Shawn Guo wrote:
> On Fri, Nov 16, 2012 at 10:25:15AM +0100, Sascha Hauer wrote:
> > On Thu, Nov 15, 2012 at 03:00:12PM +0100, Michael Grzeschik wrote:
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > > ---
> > > arch/arm/mach-imx/clk-imx51-imx53.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> > > index 3edd11c..33c3c9b 100644
> > > --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> > > +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> > > @@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
> > > clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
> > > clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
> > > clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
> > > + clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
> > > + clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
> > > + clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
> >
> > Shawn, do you have plans to move the clock lookups to devicetree like
> > you did on i.MX6? It would be nice to get rid of patches like this.
> >
> Right. But I will not be able to resume the IMX cleanup work like this
> any soon, as I have some FSL internal stuff to sort out. So please go
> ahead to do it.
I didn't have the intention to volunteer for this job ;)
Anyway, I'll see if I find time for this.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/4] ARM: imx: add imx5x usbmisc clock lookups
2012-11-16 9:25 ` Sascha Hauer
@ 2012-11-16 14:28 ` Shawn Guo
2012-11-16 14:19 ` Sascha Hauer
0 siblings, 1 reply; 12+ messages in thread
From: Shawn Guo @ 2012-11-16 14:28 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 16, 2012 at 10:25:15AM +0100, Sascha Hauer wrote:
> On Thu, Nov 15, 2012 at 03:00:12PM +0100, Michael Grzeschik wrote:
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> > arch/arm/mach-imx/clk-imx51-imx53.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> > index 3edd11c..33c3c9b 100644
> > --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> > +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> > @@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
> > clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
> > clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
> > clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
> > + clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
> > + clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
> > + clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
>
> Shawn, do you have plans to move the clock lookups to devicetree like
> you did on i.MX6? It would be nice to get rid of patches like this.
>
Right. But I will not be able to resume the IMX cleanup work like this
any soon, as I have some FSL internal stuff to sort out. So please go
ahead to do it.
Shawn
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries
2012-11-16 9:28 ` Marc Kleine-Budde
@ 2012-11-16 14:33 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2012-11-16 14:33 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 16, 2012 at 10:28:28AM +0100, Marc Kleine-Budde wrote:
> On 11/16/2012 08:15 AM, Shawn Guo wrote:
> > On Thu, Nov 15, 2012 at 03:00:14PM +0100, Michael Grzeschik wrote:
> >> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> >> ---
> >> arch/arm/boot/dts/imx51.dtsi | 2 ++
> >> arch/arm/boot/dts/imx53.dtsi | 2 ++
> >> 2 files changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> >> index 366b8d3..ffc6bc8 100644
> >> --- a/arch/arm/boot/dts/imx51.dtsi
> >> +++ b/arch/arm/boot/dts/imx51.dtsi
> >> @@ -145,6 +145,7 @@
> >> compatible = "fsl,imx51-usb", "fsl,imx27-usb";
> >> reg = <0x73f80200 0x0200>;
> >> interrupts = <14>;
> >> + phy-mode = "utmiw";
> >
> > I tried to grep "phy-mode" and "utmiw" on linux-next and found nothing.
> > So it's not something we can take for 3.8, right?
>
> But it wouldn't hurt, if we agree on a common usb phy-mode binding helper.
>
Generally, I intend to only take the dts changes which have the
corresponding binding merged by subsystems, so that we can avoid
the possible noisy patches to adopt binding changes back and forth.
Shawn
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/4] ARM: imx: add imx5x usbmisc clock lookups
2012-11-16 14:19 ` Sascha Hauer
@ 2012-11-16 17:48 ` Fabio Estevam
0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2012-11-16 17:48 UTC (permalink / raw)
To: linux-arm-kernel
Sascha,
On Fri, Nov 16, 2012 at 12:19 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> I didn't have the intention to volunteer for this job ;)
> Anyway, I'll see if I find time for this.
I sent a RFC patch for this conversion. Only built-tested, as I don't
have access to any mx5 board now.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-11-16 17:48 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-15 14:00 [PATCH 0/4] mx5x usb{misc} devictree bindings and clocks Michael Grzeschik
2012-11-15 14:00 ` [PATCH 1/4] ARM: imx: add imx5x usb controller clock lookups Michael Grzeschik
2012-11-15 14:00 ` [PATCH 2/4] ARM: imx: add imx5x usbmisc " Michael Grzeschik
2012-11-16 9:25 ` Sascha Hauer
2012-11-16 14:28 ` Shawn Guo
2012-11-16 14:19 ` Sascha Hauer
2012-11-16 17:48 ` Fabio Estevam
2012-11-15 14:00 ` [PATCH 3/4] ARM: dts: imx: rename imx5x usb entries as in imx6q.dtsi Michael Grzeschik
2012-11-15 14:00 ` [PATCH 4/4] ARM: dts: imx: add imx5x phy-mode entries Michael Grzeschik
2012-11-16 7:15 ` Shawn Guo
2012-11-16 9:28 ` Marc Kleine-Budde
2012-11-16 14:33 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).