From: qianfan <qianfanguijin@163.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: linux-sunxi@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board
Date: Fri, 13 May 2022 15:48:50 +0800 [thread overview]
Message-ID: <1352b9d7-5219-af09-948b-6462def39ea5@163.com> (raw)
In-Reply-To: <20220513073849.cu4jzykefat2sepg@houat>
在 2022/5/13 15:38, Maxime Ripard 写道:
> Hi,
>
> On Thu, May 12, 2022 at 03:18:58PM +0800, qianfanguijin@163.com wrote:
>> From: qianfan Zhao <qianfanguijin@163.com>
>>
>> sun8i-r40 actived cpufreq feature now, let's add "cpu-supply" node on
>> board.
>>
>> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
>> ---
>> arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 4 ++++
>> arch/arm/boot/dts/sun8i-r40-feta40i.dtsi | 4 ++++
>> arch/arm/boot/dts/sun8i-t3-cqa3t-bv3.dts | 4 ++++
>> arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 4 ++++
>> 4 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
>> index a6a1087a0c9b..4f30018ec4a2 100644
>> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
>> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
>> @@ -113,6 +113,10 @@ &ahci {
>> status = "okay";
>> };
>>
>> +&cpu0 {
>> + cpu-supply = <®_dcdc2>;
>> +};
>> +
> This will break bisection on those boards. Indeed, you added the OPPs on
> the first patch, and if you only apply that patch, the boards in the
> second patch will be missing their CPU regulator. The kernel will then
> ramp up the frequency to the highest OPP, but will not change the
> voltage, resulting in a crash.
This is a good point and I will merge those two patch.
>
> There's a similar issue for all the boards that don't have a regulator
> in the first place.
>
> The way we worked around this for the other SoCs is to have a DTSI with
> the OPPs with a frequency higher than what U-Boot boots with (1008MHz?),
> and only include that DTSI on boards that have a CPU regulator hooked in.
Is this really necessary? It seems like every board based on sun8i-r40
have a cpu regulator.
>
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-13 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:18 [PATCH v3 1/2] ARM: dts: sun8i-r40: add opp table for cpu qianfanguijin
2022-05-12 7:18 ` [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board qianfanguijin
2022-05-13 7:38 ` Maxime Ripard
2022-05-13 7:48 ` qianfan [this message]
2022-05-13 8:15 ` Maxime Ripard
2022-05-13 8:23 ` qianfan
2022-05-16 7:53 ` Maxime Ripard
2022-05-16 15:39 ` Chen-Yu Tsai
2022-05-12 7:29 ` [PATCH v3 1/2] ARM: dts: sun8i-r40: add opp table for cpu Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352b9d7-5219-af09-948b-6462def39ea5@163.com \
--to=qianfanguijin@163.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox