* ARM: imx: ehci-imx35: fix host power mask bit
@ 2012-11-16 10:53 Christoph Fritz
2012-11-16 13:25 ` Eric Bénard
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Fritz @ 2012-11-16 10:53 UTC (permalink / raw)
To: linux-arm-kernel
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX35
Reference Manual. Falsely it was set to bit 8, but this controls pull-up
Impedance.
Reported-by: Michael Burkey <mdburkey@gmail.com>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
arch/arm/mach-imx/ehci-imx35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c
index a596f70..554e7cc 100644
--- a/arch/arm/mach-imx/ehci-imx35.c
+++ b/arch/arm/mach-imx/ehci-imx35.c
@@ -30,7 +30,7 @@
#define MX35_H1_SIC_SHIFT 21
#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
#define MX35_H1_PP_BIT (1 << 18)
-#define MX35_H1_PM_BIT (1 << 8)
+#define MX35_H1_PM_BIT (1 << 16)
#define MX35_H1_IPPUE_UP_BIT (1 << 7)
#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
#define MX35_H1_TLL_BIT (1 << 5)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ARM: imx: ehci-imx35: fix host power mask bit
2012-11-16 10:53 ARM: imx: ehci-imx35: fix host power mask bit Christoph Fritz
@ 2012-11-16 13:25 ` Eric Bénard
2012-11-16 14:39 ` [PATCH] ARM: imx: ehci: " Christoph Fritz
0 siblings, 1 reply; 5+ messages in thread
From: Eric Bénard @ 2012-11-16 13:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Christoph,
Le Fri, 16 Nov 2012 11:53:17 +0100,
Christoph Fritz <chf.fritz@googlemail.com> a ?crit :
> This patch sets HPM (Host power mask bit) to bit 16 according to i.MX35
> Reference Manual. Falsely it was set to bit 8, but this controls pull-up
> Impedance.
>
> Reported-by: Michael Burkey <mdburkey@gmail.com>
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
Acked-by: Eric B?nard <eric@eukrea.com>
the same problem exists in arch/arm/mach-imx/ehci-imx25.c may you
please also fix it in your patch at the same time ?
Thanks
Eric
> ---
> arch/arm/mach-imx/ehci-imx35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c
> index a596f70..554e7cc 100644
> --- a/arch/arm/mach-imx/ehci-imx35.c
> +++ b/arch/arm/mach-imx/ehci-imx35.c
> @@ -30,7 +30,7 @@
> #define MX35_H1_SIC_SHIFT 21
> #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
> #define MX35_H1_PP_BIT (1 << 18)
> -#define MX35_H1_PM_BIT (1 << 8)
> +#define MX35_H1_PM_BIT (1 << 16)
> #define MX35_H1_IPPUE_UP_BIT (1 << 7)
> #define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
> #define MX35_H1_TLL_BIT (1 << 5)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: imx: ehci: fix host power mask bit
2012-11-16 13:25 ` Eric Bénard
@ 2012-11-16 14:39 ` Christoph Fritz
2012-11-16 14:55 ` Sascha Hauer
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Fritz @ 2012-11-16 14:39 UTC (permalink / raw)
To: linux-arm-kernel
This patch sets HPM (Host power mask bit) to bit 16 according to i.MX
Reference Manual. Falsely it was set to bit 8, but this controls pull-up
Impedance.
Reported-by: Michael Burkey <mdburkey@gmail.com>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
Acked-by: Eric B?nard <eric@eukrea.com>
---
arch/arm/mach-imx/ehci-imx25.c | 2 +-
arch/arm/mach-imx/ehci-imx35.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/ehci-imx25.c b/arch/arm/mach-imx/ehci-imx25.c
index 27e40d1..134c190 100644
--- a/arch/arm/mach-imx/ehci-imx25.c
+++ b/arch/arm/mach-imx/ehci-imx25.c
@@ -30,7 +30,7 @@
#define MX25_H1_SIC_SHIFT 21
#define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)
#define MX25_H1_PP_BIT (1 << 18)
-#define MX25_H1_PM_BIT (1 << 8)
+#define MX25_H1_PM_BIT (1 << 16)
#define MX25_H1_IPPUE_UP_BIT (1 << 7)
#define MX25_H1_IPPUE_DOWN_BIT (1 << 6)
#define MX25_H1_TLL_BIT (1 << 5)
diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c
index a596f70..554e7cc 100644
--- a/arch/arm/mach-imx/ehci-imx35.c
+++ b/arch/arm/mach-imx/ehci-imx35.c
@@ -30,7 +30,7 @@
#define MX35_H1_SIC_SHIFT 21
#define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
#define MX35_H1_PP_BIT (1 << 18)
-#define MX35_H1_PM_BIT (1 << 8)
+#define MX35_H1_PM_BIT (1 << 16)
#define MX35_H1_IPPUE_UP_BIT (1 << 7)
#define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
#define MX35_H1_TLL_BIT (1 << 5)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: imx: ehci: fix host power mask bit
2012-11-16 14:39 ` [PATCH] ARM: imx: ehci: " Christoph Fritz
@ 2012-11-16 14:55 ` Sascha Hauer
2012-11-16 18:18 ` Michael D. Burkey
0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2012-11-16 14:55 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 16, 2012 at 03:39:24PM +0100, Christoph Fritz wrote:
> This patch sets HPM (Host power mask bit) to bit 16 according to i.MX
> Reference Manual. Falsely it was set to bit 8, but this controls pull-up
> Impedance.
>
> Reported-by: Michael Burkey <mdburkey@gmail.com>
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> Acked-by: Eric B?nard <eric@eukrea.com>
Applied, thanks
Sascha
> ---
> arch/arm/mach-imx/ehci-imx25.c | 2 +-
> arch/arm/mach-imx/ehci-imx35.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/ehci-imx25.c b/arch/arm/mach-imx/ehci-imx25.c
> index 27e40d1..134c190 100644
> --- a/arch/arm/mach-imx/ehci-imx25.c
> +++ b/arch/arm/mach-imx/ehci-imx25.c
> @@ -30,7 +30,7 @@
> #define MX25_H1_SIC_SHIFT 21
> #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)
> #define MX25_H1_PP_BIT (1 << 18)
> -#define MX25_H1_PM_BIT (1 << 8)
> +#define MX25_H1_PM_BIT (1 << 16)
> #define MX25_H1_IPPUE_UP_BIT (1 << 7)
> #define MX25_H1_IPPUE_DOWN_BIT (1 << 6)
> #define MX25_H1_TLL_BIT (1 << 5)
> diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c
> index a596f70..554e7cc 100644
> --- a/arch/arm/mach-imx/ehci-imx35.c
> +++ b/arch/arm/mach-imx/ehci-imx35.c
> @@ -30,7 +30,7 @@
> #define MX35_H1_SIC_SHIFT 21
> #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
> #define MX35_H1_PP_BIT (1 << 18)
> -#define MX35_H1_PM_BIT (1 << 8)
> +#define MX35_H1_PM_BIT (1 << 16)
> #define MX35_H1_IPPUE_UP_BIT (1 << 7)
> #define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
> #define MX35_H1_TLL_BIT (1 << 5)
> --
> 1.7.10.4
>
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: imx: ehci: fix host power mask bit
2012-11-16 14:55 ` Sascha Hauer
@ 2012-11-16 18:18 ` Michael D. Burkey
0 siblings, 0 replies; 5+ messages in thread
From: Michael D. Burkey @ 2012-11-16 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Great!
Also, be aware that this bug/fix needs to be applied to both the Linux
kernel and to BareBox as well.
Thanks,
Michael Burkey
----- Original Message -----
From: "Sascha Hauer" <s.hauer@pengutronix.de>
To: "Christoph Fritz" <chf.fritz@googlemail.com>
Cc: "Eric B?nard" <eric@eukrea.com>; "Sascha Hauer" <kernel@pengutronix.de>;
"Fabio Estevam" <fabio.estevam@freescale.com>; "Michael Burkey"
<mdburkey@gmail.com>; "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>;
"Stable" <stable@vger.kernel.org>; "Hans J. Koch" <hjk@hansjkoch.de>;
"Daniel Mack" <daniel@caiaq.de>; "Christian Hemp" <c.hemp@phytec.de>;
<linux-arm-kernel@lists.infradead.org>
Sent: Friday, November 16, 2012 9:55 AM
Subject: Re: [PATCH] ARM: imx: ehci: fix host power mask bit
> On Fri, Nov 16, 2012 at 03:39:24PM +0100, Christoph Fritz wrote:
>> This patch sets HPM (Host power mask bit) to bit 16 according to i.MX
>> Reference Manual. Falsely it was set to bit 8, but this controls pull-up
>> Impedance.
>>
>> Reported-by: Michael Burkey <mdburkey@gmail.com>
>> Cc: Stable <stable@vger.kernel.org>
>> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
>> Acked-by: Eric B?nard <eric@eukrea.com>
>
> Applied, thanks
>
> Sascha
>
>> ---
>> arch/arm/mach-imx/ehci-imx25.c | 2 +-
>> arch/arm/mach-imx/ehci-imx35.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/ehci-imx25.c
>> b/arch/arm/mach-imx/ehci-imx25.c
>> index 27e40d1..134c190 100644
>> --- a/arch/arm/mach-imx/ehci-imx25.c
>> +++ b/arch/arm/mach-imx/ehci-imx25.c
>> @@ -30,7 +30,7 @@
>> #define MX25_H1_SIC_SHIFT 21
>> #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)
>> #define MX25_H1_PP_BIT (1 << 18)
>> -#define MX25_H1_PM_BIT (1 << 8)
>> +#define MX25_H1_PM_BIT (1 << 16)
>> #define MX25_H1_IPPUE_UP_BIT (1 << 7)
>> #define MX25_H1_IPPUE_DOWN_BIT (1 << 6)
>> #define MX25_H1_TLL_BIT (1 << 5)
>> diff --git a/arch/arm/mach-imx/ehci-imx35.c
>> b/arch/arm/mach-imx/ehci-imx35.c
>> index a596f70..554e7cc 100644
>> --- a/arch/arm/mach-imx/ehci-imx35.c
>> +++ b/arch/arm/mach-imx/ehci-imx35.c
>> @@ -30,7 +30,7 @@
>> #define MX35_H1_SIC_SHIFT 21
>> #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
>> #define MX35_H1_PP_BIT (1 << 18)
>> -#define MX35_H1_PM_BIT (1 << 8)
>> +#define MX35_H1_PM_BIT (1 << 16)
>> #define MX35_H1_IPPUE_UP_BIT (1 << 7)
>> #define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
>> #define MX35_H1_TLL_BIT (1 << 5)
>> --
>> 1.7.10.4
>>
>>
>>
>>
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-16 18:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-16 10:53 ARM: imx: ehci-imx35: fix host power mask bit Christoph Fritz
2012-11-16 13:25 ` Eric Bénard
2012-11-16 14:39 ` [PATCH] ARM: imx: ehci: " Christoph Fritz
2012-11-16 14:55 ` Sascha Hauer
2012-11-16 18:18 ` Michael D. Burkey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).