From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] pinctrl: mvebu: fix iomem pointer for dove pinctrl
Date: Mon, 19 Nov 2012 10:39:53 +0100 [thread overview]
Message-ID: <1353317996-20841-2-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1353317996-20841-1-git-send-email-sebastian.hesselbarth@gmail.com>
There has been a change in readl/writel to require registers
addresses marked as IOMEM(). This patch takes care of this and
also replaces ORing address offsets with adding them.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Axel Lin <axel.lin@ingics.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
drivers/pinctrl/mvebu/pinctrl-dove.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c
index ffe74b2..34693f6 100644
--- a/drivers/pinctrl/mvebu/pinctrl-dove.c
+++ b/drivers/pinctrl/mvebu/pinctrl-dove.c
@@ -22,22 +22,22 @@
#include "pinctrl-mvebu.h"
-#define DOVE_SB_REGS_VIRT_BASE 0xfde00000
-#define DOVE_MPP_VIRT_BASE (DOVE_SB_REGS_VIRT_BASE | 0xd0200)
+#define DOVE_SB_REGS_VIRT_BASE IOMEM(0xfde00000)
+#define DOVE_MPP_VIRT_BASE (DOVE_SB_REGS_VIRT_BASE + 0xd0200)
#define DOVE_PMU_MPP_GENERAL_CTRL (DOVE_MPP_VIRT_BASE + 0x10)
#define DOVE_AU0_AC97_SEL BIT(16)
-#define DOVE_GLOBAL_CONFIG_1 (DOVE_SB_REGS_VIRT_BASE | 0xe802C)
+#define DOVE_GLOBAL_CONFIG_1 (DOVE_SB_REGS_VIRT_BASE + 0xe802C)
#define DOVE_TWSI_ENABLE_OPTION1 BIT(7)
-#define DOVE_GLOBAL_CONFIG_2 (DOVE_SB_REGS_VIRT_BASE | 0xe8030)
+#define DOVE_GLOBAL_CONFIG_2 (DOVE_SB_REGS_VIRT_BASE + 0xe8030)
#define DOVE_TWSI_ENABLE_OPTION2 BIT(20)
#define DOVE_TWSI_ENABLE_OPTION3 BIT(21)
#define DOVE_TWSI_OPTION3_GPIO BIT(22)
-#define DOVE_SSP_CTRL_STATUS_1 (DOVE_SB_REGS_VIRT_BASE | 0xe8034)
+#define DOVE_SSP_CTRL_STATUS_1 (DOVE_SB_REGS_VIRT_BASE + 0xe8034)
#define DOVE_SSP_ON_AU1 BIT(0)
-#define DOVE_MPP_GENERAL_VIRT_BASE (DOVE_SB_REGS_VIRT_BASE | 0xe803c)
+#define DOVE_MPP_GENERAL_VIRT_BASE (DOVE_SB_REGS_VIRT_BASE + 0xe803c)
#define DOVE_AU1_SPDIFO_GPIO_EN BIT(1)
#define DOVE_NAND_GPIO_EN BIT(0)
-#define DOVE_GPIO_LO_VIRT_BASE (DOVE_SB_REGS_VIRT_BASE | 0xd0400)
+#define DOVE_GPIO_LO_VIRT_BASE (DOVE_SB_REGS_VIRT_BASE + 0xd0400)
#define DOVE_MPP_CTRL4_VIRT_BASE (DOVE_GPIO_LO_VIRT_BASE + 0x40)
#define DOVE_SPI_GPIO_SEL BIT(5)
#define DOVE_UART1_GPIO_SEL BIT(4)
--
1.7.10.4
next prev parent reply other threads:[~2012-11-19 9:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 9:39 [PATCH 0/4] Dove pinctrl fixes and DT enabling Sebastian Hesselbarth
2012-11-19 9:39 ` Sebastian Hesselbarth [this message]
2012-11-19 9:48 ` [PATCH 1/4] pinctrl: mvebu: fix iomem pointer for dove pinctrl Thomas Petazzoni
2012-11-21 10:00 ` Linus Walleij
2012-11-19 9:39 ` [PATCH 2/4] pinctrl: mvebu: Fix dove_audio1_ctrl_set function Sebastian Hesselbarth
2012-11-21 10:00 ` Linus Walleij
2012-11-19 9:39 ` [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl Sebastian Hesselbarth
2012-11-24 2:39 ` Jason Cooper
2012-11-24 7:02 ` Thomas Petazzoni
2012-11-24 15:00 ` Jason Cooper
2012-11-24 18:10 ` Thomas Petazzoni
2012-11-24 18:59 ` Jason Cooper
2012-11-25 10:51 ` Sebastian Hesselbarth
2012-11-25 15:28 ` Jason Cooper
2012-11-26 9:18 ` [PATCH 1/2] ARM: Dove: Add pinctrl clock to DT Sebastian Hesselbarth
2012-11-26 9:20 ` [PATCH 2/2] pinctrl: mvebu: make pdma clock on dove mandatory Sebastian Hesselbarth
2012-11-26 9:30 ` Baruch Siach
2012-11-26 19:16 ` [PATCH v2 1/2] ARM: Dove: Add pinctrl clock to DT Sebastian Hesselbarth
2012-11-26 19:16 ` [PATCH v2 2/2] pinctrl: mvebu: make pdma clock on dove mandatory Sebastian Hesselbarth
2013-01-07 16:20 ` [PATCH v2 1/2] ARM: Dove: Add pinctrl clock to DT Jason Cooper
2012-12-01 17:07 ` [PATCH " Linus Walleij
2012-12-01 18:13 ` Jason Cooper
2012-12-01 18:15 ` Sebastian Hesselbarth
2012-12-01 18:21 ` Jason Cooper
2012-11-19 9:39 ` [PATCH 4/4] ARM: Dove: Add CuBox pinhog for led Sebastian Hesselbarth
2012-11-21 9:59 ` [PATCH 0/4] Dove pinctrl fixes and DT enabling Linus Walleij
2012-11-21 10:20 ` Sebastian Hesselbarth
2012-11-21 14:45 ` Linus Walleij
2012-11-21 14:59 ` Thomas Petazzoni
2012-11-21 15:52 ` Jason Cooper
2012-11-23 7:49 ` Linus Walleij
2012-11-23 14:13 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353317996-20841-2-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).