* [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports
@ 2012-11-20 22:48 Doug Anderson
2012-11-21 7:29 ` Olof Johansson
2012-11-21 16:54 ` [PATCH v2] " Doug Anderson
0 siblings, 2 replies; 8+ messages in thread
From: Doug Anderson @ 2012-11-20 22:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Olof Johansson <olof@lixom.net>
UART3 is used for debugging on exynos5250-snow.
[dianders: cleaned commit message.]
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
arch/arm/Kconfig.debug | 11 +++++++++++
arch/arm/plat-samsung/Kconfig | 1 +
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 33a8930..35ba7dc 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -355,6 +355,17 @@ choice
The uncompressor code port configuration is now handled
by CONFIG_S3C_LOWLEVEL_UART_PORT.
+ config DEBUG_S3C_UART3
+ depends on PLAT_SAMSUNG
+ bool "Use S3C UART 3 for low-level debug"
+ help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_SOCFPGA_UART
depends on ARCH_SOCFPGA
bool "Use SOCFPGA UART for low-level debug"
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 59401e1..d342ed0 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -502,5 +502,6 @@ config DEBUG_S3C_UART
default "0" if DEBUG_S3C_UART0
default "1" if DEBUG_S3C_UART1
default "2" if DEBUG_S3C_UART2
+ default "3" if DEBUG_S3C_UART3
endif
--
1.7.7.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports
2012-11-20 22:48 [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports Doug Anderson
@ 2012-11-21 7:29 ` Olof Johansson
2012-11-21 9:49 ` Kukjin Kim
2012-11-21 16:58 ` Doug Anderson
2012-11-21 16:54 ` [PATCH v2] " Doug Anderson
1 sibling, 2 replies; 8+ messages in thread
From: Olof Johansson @ 2012-11-21 7:29 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> From: Olof Johansson <olof@lixom.net>
>
> UART3 is used for debugging on exynos5250-snow.
>
> [dianders: cleaned commit message.]
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> ---
> arch/arm/Kconfig.debug | 11 +++++++++++
> arch/arm/plat-samsung/Kconfig | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 33a8930..35ba7dc 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -355,6 +355,17 @@ choice
> The uncompressor code port configuration is now handled
> by CONFIG_S3C_LOWLEVEL_UART_PORT.
>
> + config DEBUG_S3C_UART3
> + depends on PLAT_SAMSUNG
Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
to protect users of <= 3 UART platforms to select it. An added "Depends
on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
repost, please?
-Olof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports
2012-11-21 7:29 ` Olof Johansson
@ 2012-11-21 9:49 ` Kukjin Kim
2012-11-21 16:58 ` Doug Anderson
1 sibling, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2012-11-21 9:49 UTC (permalink / raw)
To: linux-arm-kernel
Olof Johansson wrote:
>
> On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> > From: Olof Johansson <olof@lixom.net>
> >
> > UART3 is used for debugging on exynos5250-snow.
> >
> > [dianders: cleaned commit message.]
> >
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> >
> > ---
> > arch/arm/Kconfig.debug | 11 +++++++++++
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 2 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 33a8930..35ba7dc 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -355,6 +355,17 @@ choice
> > The uncompressor code port configuration is now handled
> > by CONFIG_S3C_LOWLEVEL_UART_PORT.
> >
> > + config DEBUG_S3C_UART3
> > + depends on PLAT_SAMSUNG
>
>
> Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
> to protect users of <= 3 UART platforms to select it. An added "Depends
> on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
> repost, please?
>
Yes, please :-)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports
2012-11-21 7:29 ` Olof Johansson
2012-11-21 9:49 ` Kukjin Kim
@ 2012-11-21 16:58 ` Doug Anderson
1 sibling, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2012-11-21 16:58 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 20, 2012 at 11:29 PM, Olof Johansson <olof@lixom.net> wrote:
>
> On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> > From: Olof Johansson <olof@lixom.net>
> >
> > UART3 is used for debugging on exynos5250-snow.
> >
> > [dianders: cleaned commit message.]
> >
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> >
> > ---
> > arch/arm/Kconfig.debug | 11 +++++++++++
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 2 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 33a8930..35ba7dc 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -355,6 +355,17 @@ choice
> > The uncompressor code port configuration is now handled
> > by CONFIG_S3C_LOWLEVEL_UART_PORT.
> >
> > + config DEBUG_S3C_UART3
> > + depends on PLAT_SAMSUNG
>
>
> Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
> to protect users of <= 3 UART platforms to select it. An added "Depends
> on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
> repost, please?
Doh! I hadn't even noticed that you'd already posted this--I got mine
from the Chrome OS tree directly. Sorry about that...
I've added an && for ARCH_EXYNOS which seems reasonable. I left
PLAT_SAMSUNG as a depend though technically ARCH_EXYNOS does select
PLAT_SAMSUNG through a convoluted series of other config options.
-Doug
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: exynos: add UART3 to DEBUG_LL ports
2012-11-20 22:48 [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports Doug Anderson
2012-11-21 7:29 ` Olof Johansson
@ 2012-11-21 16:54 ` Doug Anderson
2012-11-22 6:50 ` Kukjin Kim
1 sibling, 1 reply; 8+ messages in thread
From: Doug Anderson @ 2012-11-21 16:54 UTC (permalink / raw)
To: linux-arm-kernel
From: Olof Johansson <olof@lixom.net>
Add support for using UART3 for DEBUG_LL on exynos.
[dianders: added depend on ARCH_EXYNOS.]
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v2:
- Matched Olof's commit message.
- Added ARCH_EXYNOS to depend list.
arch/arm/Kconfig.debug | 11 +++++++++++
arch/arm/plat-samsung/Kconfig | 1 +
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 33a8930..f54f170 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -355,6 +355,17 @@ choice
The uncompressor code port configuration is now handled
by CONFIG_S3C_LOWLEVEL_UART_PORT.
+ config DEBUG_S3C_UART3
+ depends on PLAT_SAMSUNG && ARCH_EXYNOS
+ bool "Use S3C UART 3 for low-level debug"
+ help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_SOCFPGA_UART
depends on ARCH_SOCFPGA
bool "Use SOCFPGA UART for low-level debug"
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 59401e1..d342ed0 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -502,5 +502,6 @@ config DEBUG_S3C_UART
default "0" if DEBUG_S3C_UART0
default "1" if DEBUG_S3C_UART1
default "2" if DEBUG_S3C_UART2
+ default "3" if DEBUG_S3C_UART3
endif
--
1.7.7.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: exynos: add UART3 to DEBUG_LL ports
2012-11-21 16:54 ` [PATCH v2] " Doug Anderson
@ 2012-11-22 6:50 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2012-11-22 6:50 UTC (permalink / raw)
To: linux-arm-kernel
Doug Anderson wrote:
>
> From: Olof Johansson <olof@lixom.net>
>
> Add support for using UART3 for DEBUG_LL on exynos.
>
> [dianders: added depend on ARCH_EXYNOS.]
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> ---
> Changes in v2:
> - Matched Olof's commit message.
> - Added ARCH_EXYNOS to depend list.
>
> arch/arm/Kconfig.debug | 11 +++++++++++
> arch/arm/plat-samsung/Kconfig | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 33a8930..f54f170 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -355,6 +355,17 @@ choice
> The uncompressor code port configuration is now handled
> by CONFIG_S3C_LOWLEVEL_UART_PORT.
>
> + config DEBUG_S3C_UART3
> + depends on PLAT_SAMSUNG && ARCH_EXYNOS
> + bool "Use S3C UART 3 for low-level debug"
> + help
> + Say Y here if you want the debug print routines to direct
> + their output to UART 3. The port must have been
initialised
> + by the boot-loader before use.
> +
> + The uncompressor code port configuration is now handled
> + by CONFIG_S3C_LOWLEVEL_UART_PORT.
> +
> config DEBUG_SOCFPGA_UART
> depends on ARCH_SOCFPGA
> bool "Use SOCFPGA UART for low-level debug"
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 59401e1..d342ed0 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -502,5 +502,6 @@ config DEBUG_S3C_UART
> default "0" if DEBUG_S3C_UART0
> default "1" if DEBUG_S3C_UART1
> default "2" if DEBUG_S3C_UART2
> + default "3" if DEBUG_S3C_UART3
>
> endif
> --
> 1.7.7.3
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports
@ 2012-06-04 4:45 Olof Johansson
2012-06-19 8:55 ` Kukjin Kim
0 siblings, 1 reply; 8+ messages in thread
From: Olof Johansson @ 2012-06-04 4:45 UTC (permalink / raw)
To: linux-arm-kernel
Add support for using UART3 for DEBUG_LL on exynos.
Signed-off-by: Olof Johansson <olof@lixom.net>
---
arch/arm/Kconfig.debug | 11 +++++++++++
arch/arm/plat-samsung/Kconfig | 1 +
2 files changed, 12 insertions(+)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 01a1341..da84061 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -310,6 +310,17 @@ choice
The uncompressor code port configuration is now handled
by CONFIG_S3C_LOWLEVEL_UART_PORT.
+ config DEBUG_S3C_UART3
+ depends on PLAT_SAMSUNG
+ bool "Use S3C UART 3 for low-level debug"
+ help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_LL_UART_NONE
bool "No low-level debugging UART"
help
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index a2fae4e..ed0b695 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -505,5 +505,6 @@ config DEBUG_S3C_UART
default "0" if DEBUG_S3C_UART0
default "1" if DEBUG_S3C_UART1
default "2" if DEBUG_S3C_UART2
+ default "3" if DEBUG_S3C_UART3
endif
--
1.7.10.1.488.g05fbf7a
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports
2012-06-04 4:45 [PATCH] " Olof Johansson
@ 2012-06-19 8:55 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2012-06-19 8:55 UTC (permalink / raw)
To: linux-arm-kernel
Olof Johansson wrote:
>
> Add support for using UART3 for DEBUG_LL on exynos.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> arch/arm/Kconfig.debug | 11 +++++++++++
> arch/arm/plat-samsung/Kconfig | 1 +
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 01a1341..da84061 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -310,6 +310,17 @@ choice
> The uncompressor code port configuration is now handled
> by CONFIG_S3C_LOWLEVEL_UART_PORT.
>
> + config DEBUG_S3C_UART3
> + depends on PLAT_SAMSUNG
> + bool "Use S3C UART 3 for low-level debug"
> + help
> + Say Y here if you want the debug print routines to direct
> + their output to UART 3. The port must have been
initialised
> + by the boot-loader before use.
> +
> + The uncompressor code port configuration is now handled
> + by CONFIG_S3C_LOWLEVEL_UART_PORT.
> +
> config DEBUG_LL_UART_NONE
> bool "No low-level debugging UART"
> help
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index a2fae4e..ed0b695 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -505,5 +505,6 @@ config DEBUG_S3C_UART
> default "0" if DEBUG_S3C_UART0
> default "1" if DEBUG_S3C_UART1
> default "2" if DEBUG_S3C_UART2
> + default "3" if DEBUG_S3C_UART3
>
> endif
> --
> 1.7.10.1.488.g05fbf7a
Basically, looks ok to me, but don't we need to protect this config for 3
UARTs' Samsung SoC?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-11-22 6:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 22:48 [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports Doug Anderson
2012-11-21 7:29 ` Olof Johansson
2012-11-21 9:49 ` Kukjin Kim
2012-11-21 16:58 ` Doug Anderson
2012-11-21 16:54 ` [PATCH v2] " Doug Anderson
2012-11-22 6:50 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2012-06-04 4:45 [PATCH] " Olof Johansson
2012-06-19 8:55 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).