From: avinashphilip@ti.com (Philip, Avinash)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/11] pwm: pwm-tiehrpwm: Adding TBCLK gating support.
Date: Wed, 21 Nov 2012 18:41:05 +0530 [thread overview]
Message-ID: <1353503469-18634-9-git-send-email-avinashphilip@ti.com> (raw)
In-Reply-To: <1353503469-18634-1-git-send-email-avinashphilip@ti.com>
Some platforms (like AM33XX) requires clock gating from control module
explicitly for TBCLK. Enabling of this clock required for the
functioning of the time base sub module in EHRPWM module. So adding
optional TBCLK handling if DT node populated with tbclkgating. This
helps the driver can coexist for Davinci platforms.
Signed-off-by: Philip, Avinash <avinashphilip@ti.com>
---
Changes since v2:
- Remove DT property for tbclkgating
- Use devm_clk_get instead of clk_get
Changes since v1:
- Moved TBCLK enable from probe to .pwm_enable & disable from
remove to .pwm_disable
:100644 100644 23fd3c3... 6e90829... M drivers/pwm/pwm-tiehrpwm.c
drivers/pwm/pwm-tiehrpwm.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index 23fd3c3..6e90829 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -119,6 +119,7 @@ struct ehrpwm_pwm_chip {
void __iomem *mmio_base;
unsigned long period_cycles[NUM_PWM_CHANNEL];
enum pwm_polarity polarity[NUM_PWM_CHANNEL];
+ struct clk *tbclk;
};
static inline struct ehrpwm_pwm_chip *to_ehrpwm_pwm_chip(struct pwm_chip *chip)
@@ -339,6 +340,13 @@ static int ehrpwm_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
/* Channels polarity can be configured from action qualifier module */
configure_polarity(pc, pwm->hwpwm);
+ /*
+ * Platforms require explicit clock enabling of TBCLK has
+ * to enable TBCLK explicitly before enabling PWM device
+ */
+ if (pc->tbclk)
+ clk_enable(pc->tbclk);
+
/* Enable time counter for free_run */
ehrpwm_modify(pc->mmio_base, TBCTL, TBCTL_RUN_MASK, TBCTL_FREE_RUN);
return 0;
@@ -367,6 +375,10 @@ static void ehrpwm_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
ehrpwm_modify(pc->mmio_base, AQCSFRC, aqcsfrc_mask, aqcsfrc_val);
+ /* Disabling TBCLK on PWM disable */
+ if (pc->tbclk)
+ clk_disable(pc->tbclk);
+
/* Stop Time base counter */
ehrpwm_modify(pc->mmio_base, TBCTL, TBCTL_RUN_MASK, TBCTL_STOP_NEXT);
@@ -457,6 +469,10 @@ static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
return ret;
}
+
+ /* Populate tbclk entry for platforms require explicit tbclk gating */
+ pc->tbclk = devm_clk_get(&pdev->dev, "tbclk");
+
pm_runtime_enable(&pdev->dev);
pm_runtime_get_sync(&pdev->dev);
--
1.7.0.4
next prev parent reply other threads:[~2012-11-21 13:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:10 [PATCH v4 00/11] Support for AM33xx PWM Subsystem Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship Philip, Avinash
2012-11-22 20:47 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 02/11] ARM: am33xx: clk: Add optional clock for EHRPWM Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 03/11] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver Philip, Avinash
2012-11-22 20:57 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-22 21:46 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support Philip, Avinash
2012-11-22 20:59 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-23 10:51 ` Thierry Reding
2012-11-23 11:12 ` Philip, Avinash
2012-11-23 11:18 ` Thierry Reding
2012-11-23 12:48 ` Peter Korsgaard
2012-11-24 20:34 ` Thierry Reding
2012-11-27 14:20 ` Peter Korsgaard
2012-11-22 21:06 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver Philip, Avinash
2012-11-22 21:03 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 07/11] pwm: pwm-tiehrpwm: pinctrl support Philip, Avinash
2012-11-22 21:04 ` Thierry Reding
2012-11-21 13:11 ` Philip, Avinash [this message]
2012-11-22 21:05 ` [PATCH v4 08/11] pwm: pwm-tiehrpwm: Adding TBCLK gating support Thierry Reding
2012-11-21 13:11 ` [PATCH v4 09/11] ARM: dts: AM33XX: Add PWMSS device tree nodes Philip, Avinash
2012-11-22 21:08 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 10/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evm Philip, Avinash
2012-11-22 21:11 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 11/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evmsk Philip, Avinash
2012-11-22 21:12 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-22 21:16 ` [PATCH v4 00/11] Support for AM33xx PWM Subsystem Thierry Reding
2012-11-23 10:42 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353503469-18634-9-git-send-email-avinashphilip@ti.com \
--to=avinashphilip@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).